You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@parquet.apache.org by GitBox <gi...@apache.org> on 2020/10/15 16:31:32 UTC
[GitHub] [parquet-mr] belugabehr opened a new pull request #828: PARQUET-1925: Introduce Velocity Template Engine to Parquet Generator
belugabehr opened a new pull request #828:
URL: https://github.com/apache/parquet-mr/pull/828
Make sure you have checked _all_ steps below.
### Jira
- [X] My PR addresses the following [Parquet Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references them in the PR title. For example, "PARQUET-1234: My Parquet PR"
- https://issues.apache.org/jira/browse/PARQUET-XXX
- In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
### Tests
- [X] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
### Commits
- [X] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [X] In case of new functionality, my PR adds documentation that describes how to use it.
- All the public functions and the classes in the PR contain Javadoc that explain what it does
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] belugabehr commented on pull request #828: PARQUET-1925: Introduce Velocity Template Engine to Parquet Generator
Posted by GitBox <gi...@apache.org>.
belugabehr commented on pull request #828:
URL: https://github.com/apache/parquet-mr/pull/828#issuecomment-714581308
OK. I added a unit test. I don't love the test, but it's something (and better than nothing). I'm also not sure how good of an example it will be for future tests in this 'generator' project.
I ran into a host of issues trying to test this. It's probably best to, in the future, change `Version` to implement an interface and then use normal getters instead of static fields. Since this class is compiled without any interface, there is nothing to import into the test at compile time in order to cast it to something I can then easily test against.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] gszadovszky commented on pull request #828: PARQUET-1925: Introduce Velocity Template Engine to Parquet Generator
Posted by GitBox <gi...@apache.org>.
gszadovszky commented on pull request #828:
URL: https://github.com/apache/parquet-mr/pull/828#issuecomment-726172279
@belugabehr, are you planning to work further in this PR or shall I merge it as is?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] gszadovszky commented on pull request #828: PARQUET-1925: Introduce Velocity Template Engine to Parquet Generator
Posted by GitBox <gi...@apache.org>.
gszadovszky commented on pull request #828:
URL: https://github.com/apache/parquet-mr/pull/828#issuecomment-724140466
It looks good to me.
We already have the unit test [VersionTest](https://github.com/apache/parquet-mr/blob/master/parquet-common/src/test/java/org/apache/parquet/VersionTest.java) to validate `Version`. Writing this additional test for the code generation made me more confident accepting this change.
I am not an expert of velocity but looks much better than our original code so I would appreciate your work going forward.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] shangxinli commented on pull request #828: PARQUET-1925: Introduce Velocity Template Engine to Parquet Generator
Posted by GitBox <gi...@apache.org>.
shangxinli commented on pull request #828:
URL: https://github.com/apache/parquet-mr/pull/828#issuecomment-967286140
@belugabehr As @gszadovszky asked, do you plan to work on this further?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] belugabehr commented on pull request #828: PARQUET-1925: Introduce Velocity Template Engine to Parquet Generator
Posted by GitBox <gi...@apache.org>.
belugabehr commented on pull request #828:
URL: https://github.com/apache/parquet-mr/pull/828#issuecomment-714525290
> I like this very much. Would it be possible to have a test to check the output of the template?
Great! I started working on some of the more complex templates, but I didn't want to invest too much time before getting some buy-in on this effort.
I was manually generating and compiling the output for testing. I'll see if I can write a unit test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] belugabehr commented on pull request #828: PARQUET-1925: Introduce Velocity Template Engine to Parquet Generator
Posted by GitBox <gi...@apache.org>.
belugabehr commented on pull request #828:
URL: https://github.com/apache/parquet-mr/pull/828#issuecomment-721224913
@Fokko @gszadovszky What are your thoughts on this and moving it forward?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org