[GitHub] spark pull request #14607: [SPARK-17063] [SQL] Improve performance of MSCK R...

[rxin <gi...@git.apache.org>]

Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14607#discussion_r75233482
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
    @@ -443,6 +446,31 @@ case class AlterTableDropPartitionCommand(
     case class AlterTableRecoverPartitionsCommand(
         tableName: TableIdentifier,
         cmd: String = "ALTER TABLE RECOVER PARTITIONS") extends RunnableCommand {
    +
    +  // These are two fast stats in Hive Metastore
    +  // see https://github.com/apache/hive/blob/master/
    +  //   common/src/java/org/apache/hadoop/hive/common/StatsSetupConst.java#L88
    --- End diff --
    
    this is actually not a stable identifier (i.e. line 88 will likely change quickly) -- maybe just point to the file.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org