Re: Possibility to include AVRO-1961 in 1.8.2?

["Joseph P." <jo...@gmail.com>]

Up ^^

Review, integration in 1.8.2 or comments welcome ^^

On Mon, Apr 24, 2017 at 11:43 AM, Joseph P. <jo...@gmail.com> wrote:

> Hi
>
> AVRO-1961 [1] comes with a pull request [2] containing tests and AFAIK is
> fit for merging. If you've any comment don't hesitate :)
>
> It adds the possibility to generate Avro's Pojo with Optional, without
> requiring Java 8 for avro itself.
>
> Is it possible to include it in 1.8.2?
>
> Thanks in advance
>
> Best
> joseph
>
> [1] https://issues.apache.org/jira/browse/AVRO-1961
> [2] https://github.com/apache/avro/pull/169
>

Re: Possibility to include AVRO-1961 in 1.8.2?

["Joseph P." <jo...@gmail.com>]

Hi Sean

Thanks for the reply :) I'll review some others issues soon then. Do you
know of some you would like me to have a look at?

Regarding AVRO-1961, knowing it'll be in is already quite good. On the
other hand I had to change a few internals for it, so the earlier it's in
the better (otherwise some others may impact it in between). So maybe
pulling it in "dev" (or whatever close) just after releasing 1.8.2?

Thanks again !
Cheers

On Fri, May 5, 2017 at 6:31 PM, Sean Busbey <bu...@cloudera.com> wrote:

> Hi Joseph!
>
> The best way to help increase the speed of things getting reviewed is
> to spend a few minutes reviewing other contributions. It makes it much
> faster for committers to review something when someone else has taken
> a look at it already.
>
> AVRO-1961 looks like a great improvement, but I'm skeptical of holding
> the 1.8.2 release for anything other than correctness blockers. The
> opinion of whoever acts as release manager for the next RC is more
> important than mine, granted, but we're already so far behind on
> getting that release out the door...
>
>
> On Fri, May 5, 2017 at 10:02 AM, Joseph P. <jo...@gmail.com>
> wrote:
> > Up ^^
> >
> > Review, integration in 1.8.2 or comments welcome ^^
> >
> > On Mon, Apr 24, 2017 at 11:43 AM, Joseph P. <jo...@gmail.com>
> wrote:
> >
> >> Hi
> >>
> >> AVRO-1961 [1] comes with a pull request [2] containing tests and AFAIK
> is
> >> fit for merging. If you've any comment don't hesitate :)
> >>
> >> It adds the possibility to generate Avro's Pojo with Optional, without
> >> requiring Java 8 for avro itself.
> >>
> >> Is it possible to include it in 1.8.2?
> >>
> >> Thanks in advance
> >>
> >> Best
> >> joseph
> >>
> >> [1] https://issues.apache.org/jira/browse/AVRO-1961
> >> [2] https://github.com/apache/avro/pull/169
> >>
>
>
>
> --
> busbey
>

Re: Possibility to include AVRO-1961 in 1.8.2?

[Sean Busbey <bu...@cloudera.com>]

Hi Joseph!

The best way to help increase the speed of things getting reviewed is
to spend a few minutes reviewing other contributions. It makes it much
faster for committers to review something when someone else has taken
a look at it already.

AVRO-1961 looks like a great improvement, but I'm skeptical of holding
the 1.8.2 release for anything other than correctness blockers. The
opinion of whoever acts as release manager for the next RC is more
important than mine, granted, but we're already so far behind on
getting that release out the door...


On Fri, May 5, 2017 at 10:02 AM, Joseph P. <jo...@gmail.com> wrote:
> Up ^^
>
> Review, integration in 1.8.2 or comments welcome ^^
>
> On Mon, Apr 24, 2017 at 11:43 AM, Joseph P. <jo...@gmail.com> wrote:
>
>> Hi
>>
>> AVRO-1961 [1] comes with a pull request [2] containing tests and AFAIK is
>> fit for merging. If you've any comment don't hesitate :)
>>
>> It adds the possibility to generate Avro's Pojo with Optional, without
>> requiring Java 8 for avro itself.
>>
>> Is it possible to include it in 1.8.2?
>>
>> Thanks in advance
>>
>> Best
>> joseph
>>
>> [1] https://issues.apache.org/jira/browse/AVRO-1961
>> [2] https://github.com/apache/avro/pull/169
>>



-- 
busbey