You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/02/10 08:50:28 UTC

[GitHub] [incubator-shardingsphere] beijing-penguin opened a new pull request #4223: add revoke dcl visitor parse and test unit

beijing-penguin opened a new pull request #4223: add revoke dcl visitor parse and test unit
URL: https://github.com/apache/incubator-shardingsphere/pull/4223
 
 
   Changes proposed in this pull request:
   - add revoke.xml
   - add revoke visitor parse code
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls commented on issue #4223: add revoke DCL SQL visitor parse and test unit

Posted by GitBox <gi...@apache.org>.

coveralls commented on issue #4223: add revoke DCL SQL visitor parse and test unit
URL: https://github.com/apache/incubator-shardingsphere/pull/4223#issuecomment-584034972
 
 
   ## Pull Request Test Coverage Report for [Build 9419](https://coveralls.io/builds/28626884)
   
   * **0** of **11**   **(0.0%)**  changed or added relevant lines in **1** file are covered.
   * **223** unchanged lines in **4** files lost coverage.
   * Overall coverage decreased (**-0.2%**) to **64.429%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/MySQLDCLVisitor.java](https://coveralls.io/builds/28626884/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FMySQLDCLVisitor.java#L103) | 0 | 11 | 0.0%
   <!-- | **Total:** | **0** | **11** | **0.0%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/28626884/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L65) | 3 | 76.0% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/value/literal/impl/StringLiteralValue.java](https://coveralls.io/builds/28626884/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fvalue%2Fliteral%2Fimpl%2FStringLiteralValue.java#L33) | 3 | 0% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/MySQLDMLVisitor.java](https://coveralls.io/builds/28626884/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FMySQLDMLVisitor.java#L113) | 97 | 0% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/MySQLVisitor.java](https://coveralls.io/builds/28626884/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2FMySQLVisitor.java#L110) | 120 | 0% |
   <!-- | **Total:** | **223** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/28626884/badge)](https://coveralls.io/builds/28626884) |
   | :-- | --: |
   | Change from base [Build 808](https://coveralls.io/builds/28624460): |  -0.2% |
   | Covered Lines: | 10960 |
   | Relevant Lines: | 17011 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] tristaZero commented on issue #4223: add revoke DCL SQL visitor parse and test unit

Posted by GitBox <gi...@apache.org>.

tristaZero commented on issue #4223: add revoke DCL SQL visitor parse and test unit
URL: https://github.com/apache/incubator-shardingsphere/pull/4223#issuecomment-584149716
 
 
   Hi @beijing-penguin It is a great PR, which i can see your understanding of Visitor mechanism.
   Congrats for your grow-up!
   
   Other than that, the rule name of `onObjectClause_` should be renamed a `onObjectClause` in its g4 file. You could fix it in another PR. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4223: add revoke DCL SQL visitor parse and test unit

Posted by GitBox <gi...@apache.org>.

codecov-io commented on issue #4223: add revoke DCL SQL visitor parse and test unit
URL: https://github.com/apache/incubator-shardingsphere/pull/4223#issuecomment-584033862
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4223?src=pr&el=h1) Report
   > :exclamation: No coverage uploaded for pull request base (`master@09427f9`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `0%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4223/graphs/tree.svg?width=650&token=ZvlXpWa7so&height=150&src=pr)](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4223?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master    #4223   +/-   ##
   =========================================
     Coverage          ?   60.53%           
     Complexity        ?      352           
   =========================================
     Files             ?     1015           
     Lines             ?    17011           
     Branches          ?     3003           
   =========================================
     Hits              ?    10298           
     Misses            ?     6061           
     Partials          ?      652
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4223?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ser/sql/value/literal/impl/StringLiteralValue.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4223/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvdmFsdWUvbGl0ZXJhbC9pbXBsL1N0cmluZ0xpdGVyYWxWYWx1ZS5qYXZh) | `0% <ø> (ø)` | `0 <0> (?)` | |
   | [...l/parser/sql/value/collection/CollectionValue.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4223/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvdmFsdWUvY29sbGVjdGlvbi9Db2xsZWN0aW9uVmFsdWUuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (?)` | |
   | [...dingsphere/sql/parser/visitor/MySQLDDLVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4223/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL3Zpc2l0b3IvTXlTUUxERExWaXNpdG9yLmphdmE=) | `0% <ø> (ø)` | `0 <0> (?)` | |
   | [...apache/shardingsphere/sql/parser/MySQLVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4223/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL015U1FMVmlzaXRvci5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | |
   | [...er/sql/value/literal/impl/BooleanLiteralValue.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4223/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvdmFsdWUvbGl0ZXJhbC9pbXBsL0Jvb2xlYW5MaXRlcmFsVmFsdWUuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | |
   | [...ser/sql/value/literal/impl/NumberLiteralValue.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4223/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvdmFsdWUvbGl0ZXJhbC9pbXBsL051bWJlckxpdGVyYWxWYWx1ZS5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | |
   | [...dingsphere/sql/parser/visitor/MySQLDMLVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4223/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL3Zpc2l0b3IvTXlTUUxETUxWaXNpdG9yLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | |
   | [...dingsphere/sql/parser/visitor/MySQLDALVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4223/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL3Zpc2l0b3IvTXlTUUxEQUxWaXNpdG9yLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4223?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4223?src=pr&el=footer). Last update [09427f9...9714ccc](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4223?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] tristaZero merged pull request #4223: add revoke DCL SQL visitor parse and test unit

Posted by GitBox <gi...@apache.org>.

tristaZero merged pull request #4223: add revoke DCL SQL visitor parse and test unit
URL: https://github.com/apache/incubator-shardingsphere/pull/4223
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services