You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/12/22 06:05:04 UTC

[GitHub] [kafka] showuon commented on a change in pull request #9775: KAFKA-8460: reduce the record size and increase the delay time

showuon commented on a change in pull request #9775:
URL: https://github.com/apache/kafka/pull/9775#discussion_r547085873



##########
File path: core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala
##########
@@ -801,8 +801,10 @@ class PlaintextConsumerTest extends BaseConsumerTest {
     awaitAssignment(consumer, partitions.toSet)
 
     val producer = createProducer()
-    val producerRecords = partitions.flatMap(sendRecords(producer, numRecords = 15, _))
-    val consumerRecords = consumeRecords(consumer, producerRecords.size)
+    // we produce 10 records for each topic partition. There are 3 topics, and 30 partitions each topic,
+    // so total producerRecords size should be 10 * 3 * 30 = 900
+    val producerRecords = partitions.flatMap(sendRecords(producer, numRecords = 10, _))
+    val consumerRecords = consumeRecords(consumer, producerRecords.size, waitTimeMs = 90 * 1000)

Review comment:
       Agree! I increase to 90 secs just in case. I think reduce the record size is good enough.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org