You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/09/28 22:13:16 UTC

[GitHub] [cloudstack] nvazquez commented on a change in pull request #5501: server: check service offering (storage) tags when reallocate a ROOT disk

nvazquez commented on a change in pull request #5501:
URL: https://github.com/apache/cloudstack/pull/5501#discussion_r718003828



##########
File path: engine/schema/src/main/java/com/cloud/storage/dao/VolumeDaoImpl.java
##########
@@ -217,6 +218,15 @@ public VolumeVO findByPoolIdName(long poolId, String name) {
         return listBy(sc);
     }
 
+    @Override
+    public List<VolumeVO> findReadyAndAllocatedRootVolumesByInstance(long instanceId) {

Review comment:
       Yes, it is possible to have multiple ROOT disks for deploy-as-is templates on Vmware. However, I'm not seeing a problem as the method is returning a list of volumes




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org