You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by hu...@apache.org on 2021/10/22 16:51:40 UTC
[hbase] branch branch-2.4 updated: HBASE-26308 Sum of multiplier of cost functions is not populated prop… (#3782)
This is an automated email from the ASF dual-hosted git repository.
huaxiangsun pushed a commit to branch branch-2.4
in repository https://gitbox.apache.org/repos/asf/hbase.git
The following commit(s) were added to refs/heads/branch-2.4 by this push:
new d23a5b5 HBASE-26308 Sum of multiplier of cost functions is not populated prop… (#3782)
d23a5b5 is described below
commit d23a5b5aac4fd2b9bf7d0b4e4b46a8a68b9f5195
Author: clarax <cl...@gmail.com>
AuthorDate: Fri Oct 22 09:51:12 2021 -0700
HBASE-26308 Sum of multiplier of cost functions is not populated prop… (#3782)
Signed-off-by: Duo Zhang <zh...@apache.org>
Signed-off-by: Huaxiang Sun <hu...@apache.org>
---
.../master/balancer/StochasticLoadBalancer.java | 42 ++++++++++++----------
1 file changed, 23 insertions(+), 19 deletions(-)
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
index 216b665..8c8419d 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
@@ -149,8 +149,7 @@ public class StochasticLoadBalancer extends BaseLoadBalancer {
private List<CandidateGenerator> candidateGenerators;
private List<CostFunction> costFunctions; // FindBugs: Wants this protected; IS2_INCONSISTENT_SYNC
- // To save currently configed sum of multiplier. Defaulted at 1 for cases that carry high cost
- private float sumMultiplier = 1.0f;
+ private float sumMultiplier;
// to save and report costs to JMX
private double curOverallCost = 0d;
private double[] tempFunctionCosts;
@@ -240,8 +239,9 @@ public class StochasticLoadBalancer extends BaseLoadBalancer {
LOG.info(
"Loaded config; maxSteps=" + maxSteps + ", runMaxSteps=" + runMaxSteps +
", stepsPerRegion=" + stepsPerRegion +
- ", maxRunningTime=" + maxRunningTime + ", isByTable=" + isByTable
- + ", CostFunctions=" + Arrays.toString(getCostFunctionNames()) + " etc.");
+ ", maxRunningTime=" + maxRunningTime + ", isByTable=" + isByTable +
+ ", CostFunctions=" + Arrays.toString(getCostFunctionNames()) +
+ " , sum of multiplier of cost functions = " + sumMultiplier + " etc.");
}
private void loadCustomCostFunctions(Configuration conf) {
@@ -334,31 +334,24 @@ public class StochasticLoadBalancer extends BaseLoadBalancer {
return false;
}
if (areSomeRegionReplicasColocated(cluster)) {
- LOG.info("Running balancer because at least one server hosts replicas of the same region.");
+ LOG.info("Running balancer because at least one server hosts replicas of the same region." +
+ " function cost={}", functionCost());
return true;
}
if (idleRegionServerExist(cluster)){
- LOG.info("Running balancer because cluster has idle server(s).");
+ LOG.info("Running balancer because cluster has idle server(s)."+
+ " function cost={}", functionCost());
return true;
}
- sumMultiplier = 0.0f;
double total = 0.0;
for (CostFunction c : costFunctions) {
- float multiplier = c.getMultiplier();
- double cost = c.cost();
if (!c.isNeeded()) {
LOG.trace("{} not needed", c.getClass().getSimpleName());
continue;
}
- total += cost * multiplier;
- sumMultiplier += multiplier;
- }
- if (sumMultiplier <= 0) {
- LOG.error("At least one cost function needs a multiplier > 0. For example, set "
- + "hbase.master.balancer.stochastic.regionCountCost to a positive value or default");
- return false;
+ total += c.cost() * c.getMultiplier();
}
boolean balanced = (total / sumMultiplier < minCostNeedBalance);
@@ -434,6 +427,17 @@ public class StochasticLoadBalancer extends BaseLoadBalancer {
long startTime = EnvironmentEdgeManager.currentTime();
initCosts(cluster);
+ sumMultiplier = 0;
+ for (CostFunction c : costFunctions) {
+ if(c.isNeeded()) {
+ sumMultiplier += c.getMultiplier();
+ }
+ }
+ if (sumMultiplier <= 0) {
+ LOG.error("At least one cost function needs a multiplier > 0. For example, set "
+ + "hbase.master.balancer.stochastic.regionCountCost to a positive value or default");
+ return null;
+ }
if (!needsBalance(tableName, cluster)) {
return null;
@@ -605,8 +609,8 @@ public class StochasticLoadBalancer extends BaseLoadBalancer {
builder.append(", ");
double cost = c.cost();
builder.append("imbalance=" + cost);
- if (cost < minCostNeedBalance) {
- builder.append(", balanced");
+ if (cost >= minCostNeedBalance) {
+ builder.append(", need balance");
}
} else {
builder.append("not needed");
@@ -1229,7 +1233,7 @@ public class StochasticLoadBalancer extends BaseLoadBalancer {
}
/**
- * Class to be used for the subset of RegionLoad costs that should be treated as rates.
+ * Class to be used for the subset of RegionLoad csts that should be treated as rates.
* We do not compare about the actual rate in requests per second but rather the rate relative
* to the rest of the regions.
*/