You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by GitBox <gi...@apache.org> on 2019/12/20 15:37:57 UTC
[GitHub] [brooklyn-ui] ahgittin opened a new pull request #162: Relative
path configurable
ahgittin opened a new pull request #162: Relative path configurable
URL: https://github.com/apache/brooklyn-ui/pull/162
extends #160 offering a way for downstream projects to customize relative path if it causes issues
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [brooklyn-ui] tbouron commented on a change in pull request #162:
Relative path configurable
Posted by GitBox <gi...@apache.org>.
tbouron commented on a change in pull request #162: Relative path configurable
URL: https://github.com/apache/brooklyn-ui/pull/162#discussion_r360433627
##########
File path: pom.xml
##########
@@ -85,6 +84,8 @@
<brooklyn.version>1.0.0-SNAPSHOT</brooklyn.version><!-- BROOKLYN_VERSION -->
<build.version>${revision}</build.version>
<build.name>Apache Brooklyn</build.name>
+ <brooklyn.ui.relativePath.to.brooklyn.server.parent>../brooklyn-server/parent/</brooklyn.ui.relativePath.to.brooklyn.server.parent>
Review comment:
The name is a bit too much for my taste @ahgittin, I would use a simpler `parent.relative.path`.
But happy to go ahead and merge if it works
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [brooklyn-ui] ahgittin commented on issue #162: Relative path
configurable
Posted by GitBox <gi...@apache.org>.
ahgittin commented on issue #162: Relative path configurable
URL: https://github.com/apache/brooklyn-ui/pull/162#issuecomment-576267332
Seems maven doesn't actually respect a variable in relative path. I must have been taking some cached or downloaded item when i tested, as when we change the version it breaks.
Also irritating, seems maven won't look in the local reactor model so we need either relative path to work or the upstream item to have been built.
Revert this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [brooklyn-ui] asfgit merged pull request #162: Relative path
configurable
Posted by GitBox <gi...@apache.org>.
asfgit merged pull request #162: Relative path configurable
URL: https://github.com/apache/brooklyn-ui/pull/162
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [brooklyn-ui] ahgittin commented on a change in pull request #162:
Relative path configurable
Posted by GitBox <gi...@apache.org>.
ahgittin commented on a change in pull request #162: Relative path configurable
URL: https://github.com/apache/brooklyn-ui/pull/162#discussion_r360441133
##########
File path: pom.xml
##########
@@ -85,6 +84,8 @@
<brooklyn.version>1.0.0-SNAPSHOT</brooklyn.version><!-- BROOKLYN_VERSION -->
<build.version>${revision}</build.version>
<build.name>Apache Brooklyn</build.name>
+ <brooklyn.ui.relativePath.to.brooklyn.server.parent>../brooklyn-server/parent/</brooklyn.ui.relativePath.to.brooklyn.server.parent>
Review comment:
assuming this is set higher up in a complex project hierarchy it needs to be namespaced appropriately. someone else might have a different `parent.relative.path`. agree it's a little bit silly long but at least it's totally unambiguous. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [brooklyn-ui] ahgittin commented on issue #162: Relative path
configurable
Posted by GitBox <gi...@apache.org>.
ahgittin commented on issue #162: Relative path configurable
URL: https://github.com/apache/brooklyn-ui/pull/162#issuecomment-567968684
thanks @tbouron for the suggestion in #160 , implemented here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services