[GitHub] [incubator-nuttx] GUIDINGLI commented on a change in pull request #5232: rpmsg_rtc: resolve deadlock when the receive SYNC cmd

[GitBox <gi...@apache.org>]

GUIDINGLI commented on a change in pull request #5232:
URL: https://github.com/apache/incubator-nuttx/pull/5232#discussion_r786409489



##########
File path: drivers/timers/rpmsg_rtc.c
##########
@@ -310,7 +297,16 @@ static int rpmsg_rtc_ept_cb(FAR struct rpmsg_endpoint *ept, FAR void *data,
       break;
 
     case RPMSG_RTC_SYNC:
-      rpmsg_rtc_sync_handler(priv);
+        {
+          struct rpmsg_rtc_set_s *msg = data;
+          struct timespec tp =
+          {
+            .tv_sec  = msg->sec,
+            .tv_nsec = msg->nsec,
+          };

Review comment:
       I have tried add -std=c89 when use `./tools/configure.sh sim:rpserver`, and found lots of the build error.
   
   And if here can't use like this, how about:
   
   drivers/serial/uart_16550.c
    178 static uart_dev_t g_uart0port =
    179 {
    180   .recv     =
    181   {
    182     .size   = CONFIG_16550_UART0_RXBUFSIZE,
    183     .buffer = g_uart0rxbuffer,
    184   },
   
   there are so many places use like this, all of them need change ?
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org