You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Greg Stein <gs...@lyra.org> on 2003/04/01 02:49:19 UTC
Re: adm_access confusion
On Mon, Mar 31, 2003 at 03:49:32PM -0600, Ben Collins-Sussman wrote:
>...
> * svn_client.h (svn_client_uuid_from_path, svn_client_uuid_from_url):
> declare. new utility functions for getting uuids from either
> entries files or via RA->get_uuid().
>
> (svn_client_add): take an optional_adm_access argument.
Bleck. I don't think we should be exposing that in the client interface.
Heck, even the comment for svn_client_copy() says the argument is temporary.
I'm not sure why we have it in svn_client_delete().
That kind of stuff should stay out of the API, I think. Each client API
should do its work and that's that. Note that the client API doesn't even
have a way to get these things. It implies that a user of the API is calling
right into the WC in some fashion, then passing those into the client APIs.
No... I believe the right answer is to refect svn_client_add() into one form
for users of the client API, and another for internal users where you want
to pass around an adm_access baton.
We should be doing that same refactor for svn_client_copy() and losing its
parameter, too, not to mention the refactor allows us to share RA sessions
like I've been rambling about.
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: adm_access confusion
Posted by Ben Collins-Sussman <su...@collab.net>.
Greg Stein <gs...@lyra.org> writes:
> > (svn_client_add): take an optional_adm_access argument.
>
> Bleck. I don't think we should be exposing that in the client interface.
>
> No... I believe the right answer is to refect svn_client_add() into one form
> for users of the client API, and another for internal users where you want
> to pass around an adm_access baton.
OK, will do, then. No prob.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: adm_access confusion
Posted by Philip Martin <ph...@codematters.co.uk>.
Greg Stein <gs...@lyra.org> writes:
> On Mon, Mar 31, 2003 at 03:49:32PM -0600, Ben Collins-Sussman wrote:
> >...
> > * svn_client.h (svn_client_uuid_from_path, svn_client_uuid_from_url):
> > declare. new utility functions for getting uuids from either
> > entries files or via RA->get_uuid().
> >
> > (svn_client_add): take an optional_adm_access argument.
>
> Bleck. I don't think we should be exposing that in the client interface.
> Heck, even the comment for svn_client_copy() says the argument is temporary.
Agreed.
> I'm not sure why we have it in svn_client_delete().
I took a shortcut while doing the access baton conversion, merge calls
svn_client_delete and it has already locked the working copy.
--
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org