[GitHub] [pinot] tibrewalpratik17 commented on a diff in pull request #11621: Remove table state update operation in GET call

["tibrewalpratik17 (via GitHub)" <gi...@apache.org>]

tibrewalpratik17 commented on code in PR #11621:
URL: https://github.com/apache/pinot/pull/11621#discussion_r1329800053


##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableRestletResource.java:
##########
@@ -379,87 +377,15 @@ private String listTableConfigs(String tableName, @Nullable String tableTypeStr)
   @ManualAuthorization
   @Path("/tables/{tableName}")
   @ApiOperation(value = "Lists the table configs")
-  public String alterTableStateOrListTableConfig(
+  public String listTableConfig(
       @ApiParam(value = "Name of the table", required = true) @PathParam("tableName") String tableName,
-      @ApiParam(value = "enable|disable|drop") @QueryParam("state") String stateStr,
       @ApiParam(value = "realtime|offline") @QueryParam("type") String tableTypeStr, @Context HttpHeaders httpHeaders,
       @Context Request request) {
-    try {
-      if (StringUtils.isBlank(stateStr)) {

Review Comment:
   We did something similar for instances in #10993 and removed the state parameter entirely. I think we can be a bit aggressive here since this shouldn't have been supported in GET in the first place.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org