You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "sadanand48 (via GitHub)" <gi...@apache.org> on 2023/02/07 15:54:01 UTC
[GitHub] [ozone] sadanand48 opened a new pull request, #4252: Distcp with snapshots Ozone change
sadanand48 opened a new pull request, #4252:
URL: https://github.com/apache/ozone/pull/4252
## What changes were proposed in this pull request?
Main changes
1. Make `org.apache.hadoop.ozone.snapshot.SnapshotDiffReport` extend `org.apache.hadoop.hdfs.protocol.SnapshotDiffReport`
2. Add Ozone's DistcpSync implementation that provides flexibility to use Ozone specific checks/ functions.
Changes to pom.xml
1. added `hadoop-distcp` dependency to `ozonefs-common`
2. added `hadoop-hdfs-client` to `ozone-common` (required to access `org.apache.hadoop.hdfs.protocol.SnapshotDiffReport`)
3. update `hadoop` version to` 3.4.0-Snapshot` that contains changes for distcp to work with ozone with snapshots.
4. Had to update `kerby.version` as it was throwing Dependency convergence error for org.apache.kerby:kerb-core:jar:1.0.1 since latest version of hadoop uses this version.
this change requires latest version of hadoop that contains [HDFS-16911.](https://issues.apache.org/jira/browse/HDFS-16911)
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-7916
## How was this patch tested?
Unit tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] prashantpogde closed pull request #4252: HDDS-7916. [Snapshot] Support for Distcp with Ozone Snapshots.
Posted by "prashantpogde (via GitHub)" <gi...@apache.org>.
prashantpogde closed pull request #4252: HDDS-7916. [Snapshot] Support for Distcp with Ozone Snapshots.
URL: https://github.com/apache/ozone/pull/4252
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smengcl commented on pull request #4252: HDDS-7916. [Snapshot] Support for Distcp with Ozone Snapshots.
Posted by "smengcl (via GitHub)" <gi...@apache.org>.
smengcl commented on PR #4252:
URL: https://github.com/apache/ozone/pull/4252#issuecomment-1473169672
Thanks @sadanand48 . Can we rebase this and mark this as ready for review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] prashantpogde commented on pull request #4252: HDDS-7916. [Snapshot] Support for Distcp with Ozone Snapshots.
Posted by "prashantpogde (via GitHub)" <gi...@apache.org>.
prashantpogde commented on PR #4252:
URL: https://github.com/apache/ozone/pull/4252#issuecomment-1447197326
@sadanand48 Can you please resolve the conflicts ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smengcl commented on pull request #4252: HDDS-7916. [Snapshot] Support for Distcp with Ozone Snapshots.
Posted by "smengcl (via GitHub)" <gi...@apache.org>.
smengcl commented on PR #4252:
URL: https://github.com/apache/ozone/pull/4252#issuecomment-1492421686
> Broke down this patch into a change which doesn't depend on hdfs version upgrade and created #4491
Thanks @sadanand48 . Shall we close this PR then?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] prashantpogde commented on a diff in pull request #4252: HDDS-7916. [Snapshot] Support for Distcp with Ozone Snapshots.
Posted by "prashantpogde (via GitHub)" <gi...@apache.org>.
prashantpogde commented on code in PR #4252:
URL: https://github.com/apache/ozone/pull/4252#discussion_r1119370645
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyValueContainer.java:
##########
@@ -671,6 +671,18 @@ public void writeLock() {
this.lock.writeLock().lock();
}
+ @Override
+ public void readUnlock(String opName) {
+ // not used anywhere, implemented as part of interface.
+ this.lock.writeLock().lock();
Review Comment:
writeLock ??
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] sadanand48 commented on pull request #4252: HDDS-7916. [Snapshot] Support for Distcp with Ozone Snapshots.
Posted by "sadanand48 (via GitHub)" <gi...@apache.org>.
sadanand48 commented on PR #4252:
URL: https://github.com/apache/ozone/pull/4252#issuecomment-1488716925
Broke down this patch into a change which doesn't depend on hdfs version upgrade and created https://github.com/apache/ozone/pull/4491
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org