You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/07/16 09:28:13 UTC

[GitHub] [dolphinscheduler] caishunfeng commented on a diff in pull request #11004: [Fix-11003]Task group queue is not updated to final state

caishunfeng commented on code in PR #11004:
URL: https://github.com/apache/dolphinscheduler/pull/11004#discussion_r922657469


##########
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessServiceImpl.java:
##########
@@ -2989,7 +2988,7 @@ public TaskInstance releaseTaskGroup(TaskInstance taskInstance) {
             return null;
         }
         try {
-            while (taskGroupMapper.releaseTaskGroupResource(taskGroup.getId(), taskGroup.getUseSize()
+            while (thisTaskGroupQueue.getForceStart() != 1 && taskGroupMapper.releaseTaskGroupResource(taskGroup.getId(), taskGroup.getUseSize()

Review Comment:
   ```suggestion
               while (thisTaskGroupQueue.getForceStart() == Flag.NO && taskGroupMapper.releaseTaskGroupResource(taskGroup.getId(), taskGroup.getUseSize()
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org