You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spark.apache.org by Hyukjin Kwon <gu...@gmail.com> on 2016/11/12 17:27:20 UTC
Component naming in the PR title
Hi all,
First of all, this might be minor but I just have been curious of different
PR titles in particular component part. So, I looked through Spark wiki
again and I found the description not quite the same with the PRs.
It seems, it is said,
Pull Request
...
1.
The PR title should be of the form [SPARK-xxxx] [COMPONENT] Title,
where SPARK-xxxx is the relevant JIRA number, COMPONENT is one of the PR
categories shown at https://spark-prs.appspot.com/ and Title may be
the JIRA's title or a more specific title describing the PR itself.
...
So, It seems the component should be one of
SQL, MLlib, Core, Python, Scheduler, Build, Docs, Streaming, Mesos, Web UI,
YARN, GraphX, R.
If the component refers the ones specified in the JIRA, then, it seems it
should be one of
Block Manager, Build, Deploy, Documentation, DStream, EC2, Examples,
GraphX, Input/Output, Java API, Mesos, ML, MLlib, Optimizer, Project Infra,
PySpark, Scheduler, Shuffle, Spark Core, Spark Shell, Spark Submit, SparkR,
SQL, Structured Streaming, Tests, Web UI, Windows, YARN
It seems they are a bit different with the PRs. I hope this is clarified in
more details (including whether it should be all upper-cased or just the
same with the component name maybe).
Thanks.
Re: Component naming in the PR title
Posted by Hyukjin Kwon <gu...@gmail.com>.
I see. I was just curious as I find myself hesitating when I open a PR time
to time.
Thank you both for echoing!
On 14 Nov 2016 5:02 a.m., "Sean Owen" <so...@cloudera.com> wrote:
> Yes they really correspond to, if anything, the categories at
> spark-prs.appspot.com . They aren't that consistently used however and
> there isn't really a definite list. It is really mostly of use for the fact
> that it tags emails in a way people can filter semi-effectively. So I think
> we have left it at an informal mechanism rather than make yet another list
> of categories to maintain.
>
> On Sat, Nov 12, 2016, 18:27 Hyukjin Kwon <gu...@gmail.com> wrote:
>
>> Hi all,
>>
>>
>> First of all, this might be minor but I just have been curious of
>> different PR titles in particular component part. So, I looked through
>> Spark wiki again and I found the description not quite the same with the
>> PRs.
>>
>> It seems, it is said,
>> Pull Request
>>
>> ...
>>
>> 1.
>>
>> The PR title should be of the form [SPARK-xxxx] [COMPONENT] Title,
>> where SPARK-xxxx is the relevant JIRA number, COMPONENT is one of the PR
>> categories shown at https://spark-prs.appspot.com/ and Title may
>> be the JIRA's title or a more specific title describing the PR itself.
>>
>>
>> ...
>>
>> So, It seems the component should be one of
>>
>> SQL, MLlib, Core, Python, Scheduler, Build, Docs, Streaming, Mesos, Web
>> UI, YARN, GraphX, R.
>>
>> If the component refers the ones specified in the JIRA, then, it seems it
>> should be one of
>>
>> Block Manager, Build, Deploy, Documentation, DStream, EC2, Examples,
>> GraphX, Input/Output, Java API, Mesos, ML, MLlib, Optimizer, Project Infra,
>> PySpark, Scheduler, Shuffle, Spark Core, Spark Shell, Spark Submit, SparkR,
>> SQL, Structured Streaming, Tests, Web UI, Windows, YARN
>>
>> It seems they are a bit different with the PRs. I hope this is clarified
>> in more details (including whether it should be all upper-cased or just the
>> same with the component name maybe).
>>
>>
>> Thanks.
>>
>
Re: Component naming in the PR title
Posted by Sean Owen <so...@cloudera.com>.
Yes they really correspond to, if anything, the categories at
spark-prs.appspot.com . They aren't that consistently used however and
there isn't really a definite list. It is really mostly of use for the fact
that it tags emails in a way people can filter semi-effectively. So I think
we have left it at an informal mechanism rather than make yet another list
of categories to maintain.
On Sat, Nov 12, 2016, 18:27 Hyukjin Kwon <gu...@gmail.com> wrote:
> Hi all,
>
>
> First of all, this might be minor but I just have been curious of
> different PR titles in particular component part. So, I looked through
> Spark wiki again and I found the description not quite the same with the
> PRs.
>
> It seems, it is said,
> Pull Request
>
> ...
>
> 1.
>
> The PR title should be of the form [SPARK-xxxx] [COMPONENT] Title,
> where SPARK-xxxx is the relevant JIRA number, COMPONENT is one of the PR
> categories shown at https://spark-prs.appspot.com/ and Title may be
> the JIRA's title or a more specific title describing the PR itself.
>
>
> ...
>
> So, It seems the component should be one of
>
> SQL, MLlib, Core, Python, Scheduler, Build, Docs, Streaming, Mesos, Web
> UI, YARN, GraphX, R.
>
> If the component refers the ones specified in the JIRA, then, it seems it
> should be one of
>
> Block Manager, Build, Deploy, Documentation, DStream, EC2, Examples,
> GraphX, Input/Output, Java API, Mesos, ML, MLlib, Optimizer, Project Infra,
> PySpark, Scheduler, Shuffle, Spark Core, Spark Shell, Spark Submit, SparkR,
> SQL, Structured Streaming, Tests, Web UI, Windows, YARN
>
> It seems they are a bit different with the PRs. I hope this is clarified
> in more details (including whether it should be all upper-cased or just the
> same with the component name maybe).
>
>
> Thanks.
>
Re: Component naming in the PR title
Posted by Jacek Laskowski <ja...@japila.pl>.
Hi Hyukjin,
What's worked for me so the Spark committers have accepted was to use
the first group
SQL, MLlib, Core, Python, Scheduler, Build, Docs, Streaming, Mesos,
Web UI, YARN, GraphX, R
with all the letters uppercase.
It's less to remember so I'd vote for keeping it in use (or be acceptable).
Pozdrawiam,
Jacek Laskowski
----
https://medium.com/@jaceklaskowski/
Mastering Apache Spark 2.0 https://bit.ly/mastering-apache-spark
Follow me at https://twitter.com/jaceklaskowski
On Sat, Nov 12, 2016 at 6:27 PM, Hyukjin Kwon <gu...@gmail.com> wrote:
> Hi all,
>
>
> First of all, this might be minor but I just have been curious of different
> PR titles in particular component part. So, I looked through Spark wiki
> again and I found the description not quite the same with the PRs.
>
> It seems, it is said,
>
> Pull Request
>
>
> ...
>
> The PR title should be of the form [SPARK-xxxx] [COMPONENT] Title, where
> SPARK-xxxx is the relevant JIRA number, COMPONENT is one of the PR
> categories shown at https://spark-prs.appspot.com/ and Title may be the
> JIRA's title or a more specific title describing the PR itself.
>
>
> ...
>
> So, It seems the component should be one of
>
> SQL, MLlib, Core, Python, Scheduler, Build, Docs, Streaming, Mesos, Web UI,
> YARN, GraphX, R.
>
> If the component refers the ones specified in the JIRA, then, it seems it
> should be one of
>
> Block Manager, Build, Deploy, Documentation, DStream, EC2, Examples, GraphX,
> Input/Output, Java API, Mesos, ML, MLlib, Optimizer, Project Infra, PySpark,
> Scheduler, Shuffle, Spark Core, Spark Shell, Spark Submit, SparkR, SQL,
> Structured Streaming, Tests, Web UI, Windows, YARN
>
> It seems they are a bit different with the PRs. I hope this is clarified in
> more details (including whether it should be all upper-cased or just the
> same with the component name maybe).
>
>
> Thanks.
---------------------------------------------------------------------
To unsubscribe e-mail: dev-unsubscribe@spark.apache.org