[GitHub] [beam] robertwb commented on a diff in pull request #26451: Add flexible windowing syntax to yaml.

["robertwb (via GitHub)" <gi...@apache.org>]

robertwb commented on code in PR #26451:
URL: https://github.com/apache/beam/pull/26451#discussion_r1179468781


##########
sdks/python/apache_beam/yaml/readme_test.py:
##########
@@ -85,13 +86,46 @@ def guess_name_and_type(expr):
     output_schema = [
         guess_name_and_type(expr) for expr in m.group(1).split(',')
     ]
-    return next(iter(inputs.values())).pipeline | beam.Create(
-        [beam.Row(**{name: typ()
-                     for name, typ in output_schema})])
+    output_element = beam.Row(**{name: typ() for name, typ in output_schema})
+    return next(iter(inputs.values())) | beam.Map(

Review Comment:
   Note: previously the output didn't derive from the input so no windowing was inherited. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org