You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by "Dave Thompson (Jira)" <ji...@apache.org> on 2021/08/20 13:43:00 UTC
[jira] [Closed] (DAFFODIL-2510) Thread Safety: Improve
Logger/Logging
[ https://issues.apache.org/jira/browse/DAFFODIL-2510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dave Thompson closed DAFFODIL-2510.
-----------------------------------
Verified the specified commit (commit 51b814e5b82f6d103e9d52ff22a0661e0d7c8884) is included in the latest pull from the daffodil repository.
Verified changes identified in commit comment were implemented.
Verified failure no longer occurs when logLevel set to DEBUG.
Verified the all daffodil subproject sbt test suites execute successfully.
Verified the nightly test schemas compile and save as expected.
Verified the nightly test suite executes as expected.
> Thread Safety: Improve Logger/Logging
> --------------------------------------
>
> Key: DAFFODIL-2510
> URL: https://issues.apache.org/jira/browse/DAFFODIL-2510
> Project: Daffodil
> Issue Type: Bug
> Components: Back End, CLI, Front End, Libraries, Middle "End", TDML Runner
> Affects Versions: 3.0.0
> Reporter: Mike Beckerle
> Assignee: Steve Lawrence
> Priority: Major
> Fix For: 3.2.0
>
>
> Every object that mixes in the Logging trait gets its own mutable vars for logWriter and logLevel, and if not set, shares a single global state in the LoggingDefaults object.
> This is not thread safe. At minimum LoggingDefaults should be a ThreadLocal.
> Furthermore, those objects don't need independent ability to specify a unique logger or logging level. They should be sharing a logger supplied by the application.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)