You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@brpc.apache.org by GitBox <gi...@apache.org> on 2020/01/21 02:23:41 UTC

[GitHub] [incubator-brpc] TousakaRin commented on a change in pull request #1005: ignore ELIMIT for circuit breaker

TousakaRin commented on a change in pull request #1005: ignore ELIMIT for circuit breaker
URL: https://github.com/apache/incubator-brpc/pull/1005#discussion_r368785730
 
 

 ##########
 File path: src/brpc/circuit_breaker.cpp
 ##########
 @@ -171,6 +206,10 @@ CircuitBreaker::CircuitBreaker()
 }
 
 bool CircuitBreaker::OnCallEnd(int error_code, int64_t latency) {
+    const std::set<int>* ignored_error_codes = GetOrNewIgnoredErrorCodes();
 
 Review comment:
   已经改成写死在代码里并且添加了注释

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org