[GitHub] [spark] vanzin commented on a change in pull request #25551: [SPARK-28839][CORE] Avoids NPE in context cleaner when shuffle service is on

[GitBox <gi...@apache.org>]

vanzin commented on a change in pull request #25551: [SPARK-28839][CORE] Avoids NPE in context cleaner when shuffle service is on
URL: https://github.com/apache/spark/pull/25551#discussion_r316801882
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/scheduler/dynalloc/ExecutorMonitor.scala
 ##########
 @@ -476,7 +476,7 @@ private[spark] class ExecutorMonitor(
     }
 
     def removeShuffle(id: Int): Unit = {
-      if (shuffleIds.remove(id) && shuffleIds.isEmpty) {
+      if (shuffleIds != null && shuffleIds.remove(id) && shuffleIds.isEmpty) {
 
 Review comment:
   I think it would be better to modify `shuffleCleaned` to not post anything if the tracking feature is disabled.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org