You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tomee.apache.org by "Gurkan Erdogdu (JIRA)" <ji...@apache.org> on 2010/09/19 18:23:34 UTC

[jira] Created: (OPENEJB-1361) Managed Bean Injection via @Resource

Managed Bean Injection via @Resource
------------------------------------

                 Key: OPENEJB-1361
                 URL: https://issues.apache.org/jira/browse/OPENEJB-1361
             Project: OpenEJB
          Issue Type: New Feature
            Reporter: Gurkan Erdogdu




-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (OPENEJB-1361) Managed Bean Injection via @Resource

Posted by "Jarek Gawor (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OPENEJB-1361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12915596#action_12915596 ] 

Jarek Gawor commented on OPENEJB-1361:
--------------------------------------

#2 and the last part of #7 were committed in revision 1001996.

#4 was handled in OPENEJB-1356 and committed in revision 1001937.


> Managed Bean Injection via @Resource
> ------------------------------------
>
>                 Key: OPENEJB-1361
>                 URL: https://issues.apache.org/jira/browse/OPENEJB-1361
>             Project: OpenEJB
>          Issue Type: New Feature
>            Reporter: Gurkan Erdogdu
>            Assignee: Jarek Gawor
>         Attachments: ManagedBeanTest.java.patch, patch.txt
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (OPENEJB-1361) Managed Bean Injection via @Resource

Posted by "Gurkan Erdogdu (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OPENEJB-1361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12913949#action_12913949 ] 

Gurkan Erdogdu commented on OPENEJB-1361:
-----------------------------------------

Patch contains
1* JndiUrlReference.java
Checking java: prefix to find out correct IvmContext. module, global and app contexts are bind to component. But when InitialContext() is called without "java:" prefix, IvmContext does not find correct context instance.

2* EjbHomeProxyHandler.java
Adding ManagedBean support. Same as LocalBean

3* BaseEjbProxyHandler.java
Checking invoked method for managed beans. Managed beans are also injected with interface type. Therefore we need to check those interface methods.

4*ReflectionInvocationContext.java 
Patch for https://issues.apache.org/jira/browse/OPENEJB-1356

5* JndiEncBuilder.java
Injection of ManagedBeans via @Resource.

6* JndiBuilder.java
Binding managed beans with correct bean name. If @ManagedBean annotation defines name use it, otherwise use simple class name.

7* AnnotationDeployer.java
Patch for https://issues.apache.org/jira/browse/OPENEJB-1360.
Patch for https://issues.apache.org/jira/browse/OPENEJB-1363
Patch for ManagedBeans as LocalBean

8* AutoConfig.java
Supress errors from @Resource injection of ManagedBeans.


> Managed Bean Injection via @Resource
> ------------------------------------
>
>                 Key: OPENEJB-1361
>                 URL: https://issues.apache.org/jira/browse/OPENEJB-1361
>             Project: OpenEJB
>          Issue Type: New Feature
>            Reporter: Gurkan Erdogdu
>         Attachments: ManagedBeanTest.java.patch, patch.txt
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (OPENEJB-1361) Managed Bean Injection via @Resource

Posted by "Gurkan Erdogdu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OPENEJB-1361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gurkan Erdogdu updated OPENEJB-1361:
------------------------------------

    Attachment: ManagedBeanTest.java.patch

Shows that java:module/BeanName lookup does not return different instances.

> Managed Bean Injection via @Resource
> ------------------------------------
>
>                 Key: OPENEJB-1361
>                 URL: https://issues.apache.org/jira/browse/OPENEJB-1361
>             Project: OpenEJB
>          Issue Type: New Feature
>            Reporter: Gurkan Erdogdu
>         Attachments: ManagedBeanTest.java.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (OPENEJB-1361) Managed Bean Injection via @Resource

Posted by "Gurkan Erdogdu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OPENEJB-1361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gurkan Erdogdu updated OPENEJB-1361:
------------------------------------

    Attachment: patch.txt

Mulitple patch. See below comments what patch contains.

> Managed Bean Injection via @Resource
> ------------------------------------
>
>                 Key: OPENEJB-1361
>                 URL: https://issues.apache.org/jira/browse/OPENEJB-1361
>             Project: OpenEJB
>          Issue Type: New Feature
>            Reporter: Gurkan Erdogdu
>         Attachments: ManagedBeanTest.java.patch, patch.txt
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (OPENEJB-1361) Managed Bean Injection via @Resource

Posted by "Jarek Gawor (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OPENEJB-1361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jarek Gawor updated OPENEJB-1361:
---------------------------------

    Fix Version/s: 3.2
      Component/s: deployment

> Managed Bean Injection via @Resource
> ------------------------------------
>
>                 Key: OPENEJB-1361
>                 URL: https://issues.apache.org/jira/browse/OPENEJB-1361
>             Project: OpenEJB
>          Issue Type: New Feature
>          Components: deployment
>            Reporter: Gurkan Erdogdu
>            Assignee: Jarek Gawor
>             Fix For: 3.2
>
>         Attachments: ManagedBeanTest.java.patch, patch.txt
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (OPENEJB-1361) Managed Bean Injection via @Resource

Posted by "Jarek Gawor (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OPENEJB-1361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jarek Gawor resolved OPENEJB-1361.
----------------------------------

    Resolution: Fixed

Forgot to resolve. Please reopen if I missed something related to @Resource injection of managed beans.


> Managed Bean Injection via @Resource
> ------------------------------------
>
>                 Key: OPENEJB-1361
>                 URL: https://issues.apache.org/jira/browse/OPENEJB-1361
>             Project: OpenEJB
>          Issue Type: New Feature
>          Components: deployment
>            Reporter: Gurkan Erdogdu
>            Assignee: Jarek Gawor
>             Fix For: 3.2
>
>         Attachments: ManagedBeanTest.java.patch, patch.txt
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (OPENEJB-1361) Managed Bean Injection via @Resource

Posted by "Jarek Gawor (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OPENEJB-1361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12915900#action_12915900 ] 

Jarek Gawor commented on OPENEJB-1361:
--------------------------------------

Committed changes that addressed #5 and #8 in revision 1002340.

#1 and #6 are unnecessary.

The changes for OPENEJB-1360 and OPENEJB-1363  in #7 should be handled in those separate JIRAs. Please attach a separate patch to OPENEJB-1363 for javax.servlet.annotation.WebListener scanning.

Unless I missed something I committed all necessary changes to support managed bean injection via @Resource.

Thanks Gurkan for the patch!


> Managed Bean Injection via @Resource
> ------------------------------------
>
>                 Key: OPENEJB-1361
>                 URL: https://issues.apache.org/jira/browse/OPENEJB-1361
>             Project: OpenEJB
>          Issue Type: New Feature
>          Components: deployment
>            Reporter: Gurkan Erdogdu
>            Assignee: Jarek Gawor
>             Fix For: 3.2
>
>         Attachments: ManagedBeanTest.java.patch, patch.txt
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (OPENEJB-1361) Managed Bean Injection via @Resource

Posted by "Jarek Gawor (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OPENEJB-1361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jarek Gawor reassigned OPENEJB-1361:
------------------------------------

    Assignee: Jarek Gawor

> Managed Bean Injection via @Resource
> ------------------------------------
>
>                 Key: OPENEJB-1361
>                 URL: https://issues.apache.org/jira/browse/OPENEJB-1361
>             Project: OpenEJB
>          Issue Type: New Feature
>            Reporter: Gurkan Erdogdu
>            Assignee: Jarek Gawor
>         Attachments: ManagedBeanTest.java.patch, patch.txt
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.