[GitHub] [hive] pvary commented on a diff in pull request #3430: HIVE-26385: Iceberg integration: Implement merge into iceberg table

[GitBox <gi...@apache.org>]

pvary commented on code in PR #3430:
URL: https://github.com/apache/hive/pull/3430#discussion_r923583853


##########
ql/src/java/org/apache/hadoop/hive/ql/parse/MergeSemanticAnalyzer.java:
##########
@@ -297,15 +309,16 @@ private boolean handleCardinalityViolation(StringBuilder rewrittenQueryStr, ASTN
     //this is a tmp table and thus Session scoped and acid requires SQL statement to be serial in a
     // given session, i.e. the name can be fixed across all invocations
     String tableName = "merge_tmp_table";
+    List<String> sortKeys = columnAppender.getSortKeys();

Review Comment:
   Please talk with @lcspinter about the sorted Iceberg tables. How the 2 PR will work together.
   
   Thanks,
   Peter



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org