You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "Rich-T-kid (via GitHub)" <gi...@apache.org> on 2026/09/01 18:21:16 UTC
[PR] Rich t kid/thread unsafe checks against const generic [arrow-rs]
Rich-T-kid opened a new pull request, #10944:
URL: https://github.com/apache/arrow-rs/pull/10944
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax.
-->
- Closes #NNN.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
If this PR claims a performance improvement, please include evidence such as benchmark results.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
If there are any breaking changes to public APIs, please call them out.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] perf(arrow-select) : rename generic bound & avoid bounds check in take_primitive [arrow-rs]
Posted by "Rich-T-kid (via GitHub)" <gi...@apache.org>.
Rich-T-kid closed pull request #10944: perf(arrow-select) : rename generic bound & avoid bounds check in take_primitive
URL: https://github.com/apache/arrow-rs/pull/10944
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] perf(arrow-select) : rename generic bound & avoid bounds check in take_primitive [arrow-rs]
Posted by "adriangbot (via GitHub)" <gi...@apache.org>.
adriangbot commented on PR #10944:
URL: https://github.com/apache/arrow-rs/pull/10944#issuecomment-5514509107
🤖 Arrow criterion benchmark completed (GKE) | [trigger](https://github.com/apache/arrow-rs/pull/10944#issuecomment-5514224203)
**Instance:** `c4a-highmem-16` (12 vCPU / 65 GiB)
Comparing rich-T-kid/thread-unsafe-checks-against-const-generic (2a59992edf4adf0c84dca0d5104f05e1137249c1) to f12c504 (merge-base) [diff](https://github.com/apache/arrow-rs/compare/f12c5045e8c331bc3fc945eadea02b4bb1ca0d8c..2a59992edf4adf0c84dca0d5104f05e1137249c1)
<details><summary>Run configuration</summary>
```yaml
run benchmark take_kernels
```
</details>
<details><summary>CPU Details (lscpu)</summary>
```
Architecture: aarch64
CPU op-mode(s): 64-bit
Byte Order: Little Endian
CPU(s): 16
On-line CPU(s) list: 0-15
Vendor ID: ARM
Model name: Neoverse-V2
Model: 1
Thread(s) per core: 1
Core(s) per cluster: 16
Socket(s): -
Cluster(s): 1
Stepping: r0p1
BogoMIPS: 2000.00
Flags: fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm sb paca pacg dcpodp sve2 sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm bf16 dgh rng bti
L1d cache: 1 MiB (16 instances)
L1i cache: 1 MiB (16 instances)
L2 cache: 32 MiB (16 instances)
L3 cache: 80 MiB (1 instance)
NUMA node(s): 1
NUMA node0 CPU(s): 0-15
Vulnerability Gather data sampling: Not affected
Vulnerability Indirect target selection: Not affected
Vulnerability Itlb multihit: Not affected
Vulnerability L1tf: Not affected
Vulnerability Mds: Not affected
Vulnerability Meltdown: Not affected
Vulnerability Mmio stale data: Not affected
Vulnerability Reg file data sampling: Not affected
Vulnerability Retbleed: Not affected
Vulnerability Spec rstack overflow: Not affected
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1: Mitigation; __user pointer sanitization
Vulnerability Spectre v2: Mitigation; CSV2, BHB
Vulnerability Srbds: Not affected
Vulnerability Tsa: Not affected
Vulnerability Tsx async abort: Not affected
Vulnerability Vmscape: Not affected
```
</details>
<details><summary>Details</summary>
<p>
```
group main rich-T-kid_thread-unsafe-checks-against-const-generic
----- ---- -----------------------------------------------------
take bool 1024 1.00 607.5±1.27ns ? ?/sec 1.00 606.9±3.00ns ? ?/sec
take bool 512 1.00 353.3±0.89ns ? ?/sec 1.00 352.1±0.43ns ? ?/sec
take bool null indices 1024 1.00 721.9±4.42ns ? ?/sec 1.00 719.2±1.35ns ? ?/sec
take bool null values 1024 1.00 1079.3±1.86ns ? ?/sec 1.01 1092.3±1.40ns ? ?/sec
take bool null values null indices 1024 1.01 1119.3±1.50ns ? ?/sec 1.00 1112.0±9.71ns ? ?/sec
take check bounds i32 1024 1.02 663.8±4.57ns ? ?/sec 1.00 651.9±1.63ns ? ?/sec
take check bounds i32 512 1.21 460.3±4.47ns ? ?/sec 1.00 381.4±1.15ns ? ?/sec
take dense union 1024 1.00 7.4±0.01µs ? ?/sec 1.01 7.5±0.01µs ? ?/sec
take dense union 512 1.00 5.0±0.02µs ? ?/sec 1.03 5.1±0.02µs ? ?/sec
take fixed_size_list<i32>[22] 1024 1.00 3.5±0.01µs ? ?/sec 1.00 3.5±0.01µs ? ?/sec
take fixed_size_list<i32>[22] null indices 1024 1.01 20.9±0.03µs ? ?/sec 1.00 20.8±0.03µs ? ?/sec
take fixed_size_list<i32>[22] null values 1024 1.00 21.7±0.02µs ? ?/sec 1.00 21.7±0.10µs ? ?/sec
take fixed_size_list<i32>[8] 1024 1.00 2.8±0.00µs ? ?/sec 1.00 2.8±0.00µs ? ?/sec
take fixed_size_list<i32>[8] null indices 1024 1.00 9.5±0.01µs ? ?/sec 1.01 9.5±0.02µs ? ?/sec
take fixed_size_list<i32>[8] null values 1024 1.00 10.4±0.01µs ? ?/sec 1.01 10.5±0.04µs ? ?/sec
take fsb value len: 12, indices: 1024 1.00 1710.9±1.58ns ? ?/sec 1.00 1708.8±0.85ns ? ?/sec
take fsb value len: 12, null values, indices: 1024 1.00 2.3±0.00µs ? ?/sec 1.00 2.3±0.00µs ? ?/sec
take fsb value optimized len: 16, indices: 1024 1.01 593.2±2.54ns ? ?/sec 1.00 589.1±0.53ns ? ?/sec
take fsb value optimized len: 16, null values, indices: 1024 1.00 1194.7±1.13ns ? ?/sec 1.00 1194.7±1.64ns ? ?/sec
take i32 1024 1.02 526.8±4.99ns ? ?/sec 1.00 515.5±1.67ns ? ?/sec
take i32 512 1.01 353.2±4.70ns ? ?/sec 1.00 350.4±1.51ns ? ?/sec
take i32 null indices 1024 1.00 856.4±1.61ns ? ?/sec 1.00 853.5±1.42ns ? ?/sec
take i32 null values 1024 1.01 1120.8±30.38ns ? ?/sec 1.00 1104.9±2.30ns ? ?/sec
take i32 null values null indices 1024 1.01 1541.8±2.63ns ? ?/sec 1.00 1533.1±2.31ns ? ?/sec
take list i32 1024 1.01 5.2±0.06µs ? ?/sec 1.00 5.2±0.06µs ? ?/sec
take list i32 512 1.00 2.8±0.02µs ? ?/sec 1.00 2.8±0.02µs ? ?/sec
take list i32 null indices 1024 1.00 8.5±0.04µs ? ?/sec 1.00 8.5±0.05µs ? ?/sec
take list i32 null values 1024 1.01 4.0±0.03µs ? ?/sec 1.00 4.0±0.03µs ? ?/sec
take list i32 null values null indices 1024 1.01 7.1±0.04µs ? ?/sec 1.00 7.0±0.03µs ? ?/sec
take listview i32 1024 1.00 958.9±1.22ns ? ?/sec 1.08 1031.5±2.36ns ? ?/sec
take listview i32 512 1.02 610.8±1.32ns ? ?/sec 1.00 601.1±1.02ns ? ?/sec
take listview i32 null indices 1024 1.00 1678.2±2.92ns ? ?/sec 1.00 1674.7±1.28ns ? ?/sec
take listview i32 null values 1024 1.00 1535.1±3.22ns ? ?/sec 1.00 1531.8±1.46ns ? ?/sec
take listview i32 null values null indices 1024 1.00 2.4±0.00µs ? ?/sec 1.00 2.4±0.00µs ? ?/sec
take map<str, i32> 1024 1.00 34.7±0.05µs ? ?/sec 1.00 34.6±0.06µs ? ?/sec
take map<str, i32> 512 1.00 19.7±0.04µs ? ?/sec 1.01 19.9±0.03µs ? ?/sec
take map<str, i32> null indices 1024 1.01 20.7±0.04µs ? ?/sec 1.00 20.5±0.03µs ? ?/sec
take map<str, i32> null values 1024 1.00 20.8±0.05µs ? ?/sec 1.00 20.8±0.03µs ? ?/sec
take primitive run logical len: 1024, physical len: 512, indices: 1024 1.00 18.6±0.02µs ? ?/sec 1.00 18.7±0.05µs ? ?/sec
take sparse union 1024 1.00 7.6±0.01µs ? ?/sec 1.00 7.6±0.02µs ? ?/sec
take sparse union 512 1.00 4.7±0.01µs ? ?/sec 1.00 4.7±0.01µs ? ?/sec
take str 1024 1.00 8.1±0.02µs ? ?/sec 1.00 8.1±0.01µs ? ?/sec
take str 512 1.03 3.8±0.01µs ? ?/sec 1.00 3.7±0.00µs ? ?/sec
take str null indices 1024 1.03 4.5±0.08µs ? ?/sec 1.00 4.3±0.06µs ? ?/sec
take str null indices 512 1.00 2.1±0.04µs ? ?/sec 1.01 2.1±0.03µs ? ?/sec
take str null values 1024 1.01 4.5±0.07µs ? ?/sec 1.00 4.5±0.05µs ? ?/sec
take str null values null indices 1024 1.01 3.1±0.03µs ? ?/sec 1.00 3.0±0.02µs ? ?/sec
take string run logical len: 1024, physical len: 128, indices: 1024 1.01 24.0±0.13µs ? ?/sec 1.00 23.8±0.12µs ? ?/sec
take string run logical len: 1024, physical len: 512, indices: 1024 1.00 24.5±0.11µs ? ?/sec 1.00 24.3±0.13µs ? ?/sec
take string run logical len: 1024, physical len: 512, null indices: 1024 1.00 16.9±0.06µs ? ?/sec 1.01 17.0±0.06µs ? ?/sec
take stringview 1024 1.04 683.8±2.14ns ? ?/sec 1.00 659.6±2.31ns ? ?/sec
take stringview 512 1.16 472.5±2.26ns ? ?/sec 1.00 405.9±3.66ns ? ?/sec
take stringview null indices 1024 1.00 844.0±2.03ns ? ?/sec 1.00 846.2±3.83ns ? ?/sec
take stringview null indices 512 1.01 504.6±1.80ns ? ?/sec 1.00 499.2±0.58ns ? ?/sec
take stringview null values 1024 1.00 1232.0±2.80ns ? ?/sec 1.05 1296.2±0.96ns ? ?/sec
take stringview null values null indices 1024 1.00 1493.8±3.16ns ? ?/sec 1.05 1575.1±1.35ns ? ?/sec
take_record_batch 5 primitive cols no nulls 1024 1.01 3.0±0.01µs ? ?/sec 1.00 3.0±0.00µs ? ?/sec
take_record_batch 6 string/binary cols no nulls 1024 1.01 27.8±0.05µs ? ?/sec 1.00 27.5±0.02µs ? ?/sec
take_record_batch 7 mixed cols null values 1024 1.00 14.0±0.08µs ? ?/sec 1.00 14.0±0.08µs ? ?/sec
take_record_batch 7 mixed cols null values null indices 1024 1.00 13.4±0.04µs ? ?/sec 1.00 13.4±0.03µs ? ?/sec
```
</p>
</details>
<details><summary>Resource Usage</summary>
**base (merge-base)**
| Metric | Value |
|--------|-------|
| Wall time | 585.1s |
| Peak memory | 18.1 MiB |
| Avg memory | 14.4 MiB |
| CPU user | 582.4s |
| CPU sys | 0.0s |
| Peak spill | 0 B |
**branch**
| Metric | Value |
|--------|-------|
| Wall time | 585.1s |
| Peak memory | 17.4 MiB |
| Avg memory | 14.4 MiB |
| CPU user | 580.7s |
| CPU sys | 0.0s |
| Peak spill | 0 B |
</details>
---
[File an issue](https://github.com/adriangb/datafusion-benchmarking/issues) against this benchmark runner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Rich t kid/thread unsafe checks against const generic [arrow-rs]
Posted by "Rich-T-kid (via GitHub)" <gi...@apache.org>.
Rich-T-kid commented on PR #10944:
URL: https://github.com/apache/arrow-rs/pull/10944#issuecomment-5498435298
run benchmark take_kernel
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] perf(arrow-select) : rename generic bound & avoid bounds check in take_primitive [arrow-rs]
Posted by "adriangbot (via GitHub)" <gi...@apache.org>.
adriangbot commented on PR #10944:
URL: https://github.com/apache/arrow-rs/pull/10944#issuecomment-5512055585
Benchmark for [this request](https://github.com/apache/arrow-rs/pull/10944#issuecomment-5512003041) failed before finishing (Kubernetes reason: `BackoffLimitExceeded`).
Benchmarks requested: `take_kernel`
<details><summary>Kubernetes message</summary>
```
Job has reached the specified backoff limit
```
</details>
---
[File an issue](https://github.com/adriangb/datafusion-benchmarking/issues) against this benchmark runner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] perf(arrow-select) : rename generic bound & avoid bounds check in take_primitive [arrow-rs]
Posted by "adriangbot (via GitHub)" <gi...@apache.org>.
adriangbot commented on PR #10944:
URL: https://github.com/apache/arrow-rs/pull/10944#issuecomment-5499335306
Benchmark for [this request](https://github.com/apache/arrow-rs/pull/10944#issuecomment-5499303497) failed before finishing (Kubernetes reason: `BackoffLimitExceeded`).
Benchmarks requested: `take_kernel`
<details><summary>Kubernetes message</summary>
```
Job has reached the specified backoff limit
```
</details>
---
[File an issue](https://github.com/adriangb/datafusion-benchmarking/issues) against this benchmark runner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] perf(arrow-select) : rename generic bound & avoid bounds check in take_primitive [arrow-rs]
Posted by "adriangbot (via GitHub)" <gi...@apache.org>.
adriangbot commented on PR #10944:
URL: https://github.com/apache/arrow-rs/pull/10944#issuecomment-5512053857
🤖 Arrow criterion benchmark running (GKE) | [trigger](https://github.com/apache/arrow-rs/pull/10944#issuecomment-5512003041)
**Instance:** `c4a-highmem-16` (12 vCPU / 65 GiB) | `Linux bench-c5512003041-2082-2cvg2 6.12.94+ #1 SMP Fri Jul 17 09:42:57 UTC 2026 aarch64 GNU/Linux`
<details><summary>CPU Details (lscpu)</summary>
```
Architecture: aarch64
CPU op-mode(s): 64-bit
Byte Order: Little Endian
CPU(s): 16
On-line CPU(s) list: 0-15
Vendor ID: ARM
Model name: Neoverse-V2
Model: 1
Thread(s) per core: 1
Core(s) per cluster: 16
Socket(s): -
Cluster(s): 1
Stepping: r0p1
BogoMIPS: 2000.00
Flags: fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm sb paca pacg dcpodp sve2 sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm bf16 dgh rng bti
L1d cache: 1 MiB (16 instances)
L1i cache: 1 MiB (16 instances)
L2 cache: 32 MiB (16 instances)
L3 cache: 80 MiB (1 instance)
NUMA node(s): 1
NUMA node0 CPU(s): 0-15
Vulnerability Gather data sampling: Not affected
Vulnerability Indirect target selection: Not affected
Vulnerability Itlb multihit: Not affected
Vulnerability L1tf: Not affected
Vulnerability Mds: Not affected
Vulnerability Meltdown: Not affected
Vulnerability Mmio stale data: Not affected
Vulnerability Reg file data sampling: Not affected
Vulnerability Retbleed: Not affected
Vulnerability Spec rstack overflow: Not affected
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1: Mitigation; __user pointer sanitization
Vulnerability Spectre v2: Mitigation; CSV2, BHB
Vulnerability Srbds: Not affected
Vulnerability Tsa: Not affected
Vulnerability Tsx async abort: Not affected
Vulnerability Vmscape: Not affected
```
</details>
Comparing rich-T-kid/thread-unsafe-checks-against-const-generic (c50e65cf15578d579c5fb2d8453e3b2906146d10) to 8c49c71 (merge-base) [diff](https://github.com/apache/arrow-rs/compare/8c49c7132f8a55bb609d00685887987b2b1c9c56..c50e65cf15578d579c5fb2d8453e3b2906146d10)
<details><summary>Run configuration</summary>
```yaml
run benchmark take_kernel
env:
BENCH_FILTER: "primitive"
```
</details>
BENCH_COMMAND=cargo bench --features=arrow,async,test_common,experimental,object_store --bench take_kernel
Results will be posted here when complete
---
[File an issue](https://github.com/adriangb/datafusion-benchmarking/issues) against this benchmark runner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] perf(arrow-select) : rename generic bound & avoid bounds check in take_primitive [arrow-rs]
Posted by "Rich-T-kid (via GitHub)" <gi...@apache.org>.
Rich-T-kid commented on PR #10944:
URL: https://github.com/apache/arrow-rs/pull/10944#issuecomment-5514782920
```
take i32 1024 1.02 526.8±4.99ns ? ?/sec 1.00 515.5±1.67ns ? ?/sec
take i32 512 1.01 353.2±4.70ns ? ?/sec 1.00 350.4±1.51ns ? ?/sec
take i32 null indices 1024 1.00 856.4±1.61ns ? ?/sec 1.00 853.5±1.42ns ? ?/sec
take i32 null values 1024 1.01 1120.8±30.38ns ? ?/sec 1.00 1104.9±2.30ns ? ?/sec
take i32 null values null indices 1024 1.01 1541.8±2.63ns ? ?/sec 1.00 1533.1±2.31ns ? ?/sec
```
within noise
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] perf(arrow-select) : rename generic bound & avoid bounds check in take_primitive [arrow-rs]
Posted by "adriangbot (via GitHub)" <gi...@apache.org>.
adriangbot commented on PR #10944:
URL: https://github.com/apache/arrow-rs/pull/10944#issuecomment-5499333723
🤖 Arrow criterion benchmark running (GKE) | [trigger](https://github.com/apache/arrow-rs/pull/10944#issuecomment-5499303497)
**Instance:** `c4a-highmem-16` (12 vCPU / 65 GiB) | `Linux bench-c5499303497-2067-7nn2t 6.12.94+ #1 SMP Fri Jul 17 09:42:57 UTC 2026 aarch64 GNU/Linux`
<details><summary>CPU Details (lscpu)</summary>
```
Architecture: aarch64
CPU op-mode(s): 64-bit
Byte Order: Little Endian
CPU(s): 16
On-line CPU(s) list: 0-15
Vendor ID: ARM
Model name: Neoverse-V2
Model: 1
Thread(s) per core: 1
Core(s) per cluster: 16
Socket(s): -
Cluster(s): 1
Stepping: r0p1
BogoMIPS: 2000.00
Flags: fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm sb paca pacg dcpodp sve2 sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm bf16 dgh rng bti
L1d cache: 1 MiB (16 instances)
L1i cache: 1 MiB (16 instances)
L2 cache: 32 MiB (16 instances)
L3 cache: 80 MiB (1 instance)
NUMA node(s): 1
NUMA node0 CPU(s): 0-15
Vulnerability Gather data sampling: Not affected
Vulnerability Indirect target selection: Not affected
Vulnerability Itlb multihit: Not affected
Vulnerability L1tf: Not affected
Vulnerability Mds: Not affected
Vulnerability Meltdown: Not affected
Vulnerability Mmio stale data: Not affected
Vulnerability Reg file data sampling: Not affected
Vulnerability Retbleed: Not affected
Vulnerability Spec rstack overflow: Not affected
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1: Mitigation; __user pointer sanitization
Vulnerability Spectre v2: Mitigation; CSV2, BHB
Vulnerability Srbds: Not affected
Vulnerability Tsa: Not affected
Vulnerability Tsx async abort: Not affected
Vulnerability Vmscape: Not affected
```
</details>
Comparing rich-T-kid/thread-unsafe-checks-against-const-generic (f2d6a4cd93b16907eb41282ae67ceb88c7141006) to 27a6a40 (merge-base) [diff](https://github.com/apache/arrow-rs/compare/27a6a408796a4d855a0d997a86682401f383d352..f2d6a4cd93b16907eb41282ae67ceb88c7141006)
<details><summary>Run configuration</summary>
```yaml
run benchmark take_kernel
```
</details>
BENCH_COMMAND=cargo bench --features=arrow,async,test_common,experimental,object_store --bench take_kernel
Results will be posted here when complete
---
[File an issue](https://github.com/adriangb/datafusion-benchmarking/issues) against this benchmark runner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] perf(arrow-select) : rename generic bound & avoid bounds check in take_primitive [arrow-rs]
Posted by "Rich-T-kid (via GitHub)" <gi...@apache.org>.
Rich-T-kid commented on PR #10944:
URL: https://github.com/apache/arrow-rs/pull/10944#issuecomment-5499303497
run benchmark take_kernel
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] perf(arrow-select) : rename generic bound & avoid bounds check in take_primitive [arrow-rs]
Posted by "adriangbot (via GitHub)" <gi...@apache.org>.
adriangbot commented on PR #10944:
URL: https://github.com/apache/arrow-rs/pull/10944#issuecomment-5514262203
🤖 Arrow criterion benchmark running (GKE) | [trigger](https://github.com/apache/arrow-rs/pull/10944#issuecomment-5514224203)
**Instance:** `c4a-highmem-16` (12 vCPU / 65 GiB) | `Linux bench-c5514224203-2101-kb68f 6.12.94+ #1 SMP Fri Jul 17 09:42:57 UTC 2026 aarch64 GNU/Linux`
<details><summary>CPU Details (lscpu)</summary>
```
Architecture: aarch64
CPU op-mode(s): 64-bit
Byte Order: Little Endian
CPU(s): 16
On-line CPU(s) list: 0-15
Vendor ID: ARM
Model name: Neoverse-V2
Model: 1
Thread(s) per core: 1
Core(s) per cluster: 16
Socket(s): -
Cluster(s): 1
Stepping: r0p1
BogoMIPS: 2000.00
Flags: fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm sb paca pacg dcpodp sve2 sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm bf16 dgh rng bti
L1d cache: 1 MiB (16 instances)
L1i cache: 1 MiB (16 instances)
L2 cache: 32 MiB (16 instances)
L3 cache: 80 MiB (1 instance)
NUMA node(s): 1
NUMA node0 CPU(s): 0-15
Vulnerability Gather data sampling: Not affected
Vulnerability Indirect target selection: Not affected
Vulnerability Itlb multihit: Not affected
Vulnerability L1tf: Not affected
Vulnerability Mds: Not affected
Vulnerability Meltdown: Not affected
Vulnerability Mmio stale data: Not affected
Vulnerability Reg file data sampling: Not affected
Vulnerability Retbleed: Not affected
Vulnerability Spec rstack overflow: Not affected
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1: Mitigation; __user pointer sanitization
Vulnerability Spectre v2: Mitigation; CSV2, BHB
Vulnerability Srbds: Not affected
Vulnerability Tsa: Not affected
Vulnerability Tsx async abort: Not affected
Vulnerability Vmscape: Not affected
```
</details>
Comparing rich-T-kid/thread-unsafe-checks-against-const-generic (2a59992edf4adf0c84dca0d5104f05e1137249c1) to f12c504 (merge-base) [diff](https://github.com/apache/arrow-rs/compare/f12c5045e8c331bc3fc945eadea02b4bb1ca0d8c..2a59992edf4adf0c84dca0d5104f05e1137249c1)
<details><summary>Run configuration</summary>
```yaml
run benchmark take_kernels
```
</details>
BENCH_COMMAND=cargo bench --features=arrow,async,test_common,experimental,object_store --bench take_kernels
Results will be posted here when complete
---
[File an issue](https://github.com/adriangb/datafusion-benchmarking/issues) against this benchmark runner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] perf(arrow-select) : rename generic bound & avoid bounds check in take_primitive [arrow-rs]
Posted by "Rich-T-kid (via GitHub)" <gi...@apache.org>.
Rich-T-kid commented on PR #10944:
URL: https://github.com/apache/arrow-rs/pull/10944#issuecomment-5514224203
run benchmark take_kernels
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] perf(arrow-select) : rename generic bound & avoid bounds check in take_primitive [arrow-rs]
Posted by "adriangbot (via GitHub)" <gi...@apache.org>.
adriangbot commented on PR #10944:
URL: https://github.com/apache/arrow-rs/pull/10944#issuecomment-5514121244
🤖 Arrow criterion benchmark completed (GKE) | [trigger](https://github.com/apache/arrow-rs/pull/10944#issuecomment-5513888292)
**Instance:** `c4a-highmem-16` (12 vCPU / 65 GiB)
Comparing rich-T-kid/thread-unsafe-checks-against-const-generic (2a59992edf4adf0c84dca0d5104f05e1137249c1) to f12c504 (merge-base) [diff](https://github.com/apache/arrow-rs/compare/f12c5045e8c331bc3fc945eadea02b4bb1ca0d8c..2a59992edf4adf0c84dca0d5104f05e1137249c1)
<details><summary>Run configuration</summary>
```yaml
run benchmark take_kernels
env:
BENCH_FILTER: "primitive"
```
</details>
<details><summary>CPU Details (lscpu)</summary>
```
Architecture: aarch64
CPU op-mode(s): 64-bit
Byte Order: Little Endian
CPU(s): 16
On-line CPU(s) list: 0-15
Vendor ID: ARM
Model name: Neoverse-V2
Model: 1
Thread(s) per core: 1
Core(s) per cluster: 16
Socket(s): -
Cluster(s): 1
Stepping: r0p1
BogoMIPS: 2000.00
Flags: fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm sb paca pacg dcpodp sve2 sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm bf16 dgh rng bti
L1d cache: 1 MiB (16 instances)
L1i cache: 1 MiB (16 instances)
L2 cache: 32 MiB (16 instances)
L3 cache: 80 MiB (1 instance)
NUMA node(s): 1
NUMA node0 CPU(s): 0-15
Vulnerability Gather data sampling: Not affected
Vulnerability Indirect target selection: Not affected
Vulnerability Itlb multihit: Not affected
Vulnerability L1tf: Not affected
Vulnerability Mds: Not affected
Vulnerability Meltdown: Not affected
Vulnerability Mmio stale data: Not affected
Vulnerability Reg file data sampling: Not affected
Vulnerability Retbleed: Not affected
Vulnerability Spec rstack overflow: Not affected
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1: Mitigation; __user pointer sanitization
Vulnerability Spectre v2: Mitigation; CSV2, BHB
Vulnerability Srbds: Not affected
Vulnerability Tsa: Not affected
Vulnerability Tsx async abort: Not affected
Vulnerability Vmscape: Not affected
```
</details>
<details><summary>Details</summary>
<p>
```
group main rich-T-kid_thread-unsafe-checks-against-const-generic
----- ---- -----------------------------------------------------
take primitive run logical len: 1024, physical len: 512, indices: 1024 1.00 18.7±0.04µs ? ?/sec 1.00 18.6±0.02µs ? ?/sec
take_record_batch 5 primitive cols no nulls 1024 1.02 3.0±0.01µs ? ?/sec 1.00 2.9±0.01µs ? ?/sec
```
</p>
</details>
<details><summary>Resource Usage</summary>
**base (merge-base)**
| Metric | Value |
|--------|-------|
| Wall time | 20.0s |
| Peak memory | 14.0 MiB |
| Avg memory | 9.6 MiB |
| CPU user | 17.8s |
| CPU sys | 0.0s |
| Peak spill | 0 B |
**branch**
| Metric | Value |
|--------|-------|
| Wall time | 20.0s |
| Peak memory | 14.1 MiB |
| Avg memory | 9.5 MiB |
| CPU user | 17.0s |
| CPU sys | 0.0s |
| Peak spill | 0 B |
</details>
---
[File an issue](https://github.com/adriangb/datafusion-benchmarking/issues) against this benchmark runner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Rich t kid/thread unsafe checks against const generic [arrow-rs]
Posted by "Rich-T-kid (via GitHub)" <gi...@apache.org>.
Rich-T-kid commented on PR #10944:
URL: https://github.com/apache/arrow-rs/pull/10944#issuecomment-5498482976
benchmarks shows a minor 3-4% improvement when I ran this locally with array sizes `8192`,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] perf(arrow-select) : rename generic bound & avoid bounds check in take_primitive [arrow-rs]
Posted by "Jefffrey (via GitHub)" <gi...@apache.org>.
Jefffrey commented on PR #10944:
URL: https://github.com/apache/arrow-rs/pull/10944#issuecomment-5503075496
> benchmarks shows a minor 3-4% improvement when I ran this locally with array sizes `8192`. this PR serves as the final step for #10945
are we sure this isnt noise? from what i see in this PR, the generic isnt actually being threaded in to be `false` anywhere
also side note, i do wonder the impact of this on codegen. i know we introduced it in previous PRs, but @alamb did raise a recent epic (in datafusion) about binary size, and this is likely to contribute to a larger binary now if we thread in `false` for the generic (though to what degree im not sure)
- https://github.com/apache/datafusion/issues/24727
just something to think about 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] perf(arrow-select) : rename generic bound & avoid bounds check in take_primitive [arrow-rs]
Posted by "Rich-T-kid (via GitHub)" <gi...@apache.org>.
Rich-T-kid commented on PR #10944:
URL: https://github.com/apache/arrow-rs/pull/10944#issuecomment-5518471025
run benchmark take_kernels
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] perf(arrow-select) : rename generic bound & avoid bounds check in take_primitive [arrow-rs]
Posted by "adriangbot (via GitHub)" <gi...@apache.org>.
adriangbot commented on PR #10944:
URL: https://github.com/apache/arrow-rs/pull/10944#issuecomment-5518657677
🤖 Arrow criterion benchmark completed (GKE) | [trigger](https://github.com/apache/arrow-rs/pull/10944#issuecomment-5518471025)
**Instance:** `c4a-highmem-16` (12 vCPU / 65 GiB)
Comparing rich-T-kid/thread-unsafe-checks-against-const-generic (2a59992edf4adf0c84dca0d5104f05e1137249c1) to f12c504 (merge-base) [diff](https://github.com/apache/arrow-rs/compare/f12c5045e8c331bc3fc945eadea02b4bb1ca0d8c..2a59992edf4adf0c84dca0d5104f05e1137249c1)
<details><summary>Run configuration</summary>
```yaml
run benchmark take_kernels
```
</details>
<details><summary>CPU Details (lscpu)</summary>
```
Architecture: aarch64
CPU op-mode(s): 64-bit
Byte Order: Little Endian
CPU(s): 16
On-line CPU(s) list: 0-15
Vendor ID: ARM
Model name: Neoverse-V2
Model: 1
Thread(s) per core: 1
Core(s) per cluster: 16
Socket(s): -
Cluster(s): 1
Stepping: r0p1
BogoMIPS: 2000.00
Flags: fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm sb paca pacg dcpodp sve2 sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm bf16 dgh rng bti
L1d cache: 1 MiB (16 instances)
L1i cache: 1 MiB (16 instances)
L2 cache: 32 MiB (16 instances)
L3 cache: 80 MiB (1 instance)
NUMA node(s): 1
NUMA node0 CPU(s): 0-15
Vulnerability Gather data sampling: Not affected
Vulnerability Indirect target selection: Not affected
Vulnerability Itlb multihit: Not affected
Vulnerability L1tf: Not affected
Vulnerability Mds: Not affected
Vulnerability Meltdown: Not affected
Vulnerability Mmio stale data: Not affected
Vulnerability Reg file data sampling: Not affected
Vulnerability Retbleed: Not affected
Vulnerability Spec rstack overflow: Not affected
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1: Mitigation; __user pointer sanitization
Vulnerability Spectre v2: Mitigation; CSV2, BHB
Vulnerability Srbds: Not affected
Vulnerability Tsa: Not affected
Vulnerability Tsx async abort: Not affected
Vulnerability Vmscape: Not affected
```
</details>
<details><summary>Details</summary>
<p>
```
group main rich-T-kid_thread-unsafe-checks-against-const-generic
----- ---- -----------------------------------------------------
take bool 1024 1.00 608.3±0.98ns ? ?/sec 1.00 607.2±1.73ns ? ?/sec
take bool 512 1.01 356.6±2.36ns ? ?/sec 1.00 353.6±1.14ns ? ?/sec
take bool null indices 1024 1.00 731.6±13.06ns ? ?/sec 1.01 742.1±9.81ns ? ?/sec
take bool null values 1024 1.03 1122.2±1.25ns ? ?/sec 1.00 1094.5±2.50ns ? ?/sec
take bool null values null indices 1024 1.01 1122.8±5.03ns ? ?/sec 1.00 1109.0±2.69ns ? ?/sec
take check bounds i32 1024 1.01 662.6±1.53ns ? ?/sec 1.00 653.1±1.00ns ? ?/sec
take check bounds i32 512 1.21 461.2±1.98ns ? ?/sec 1.00 381.4±0.91ns ? ?/sec
take dense union 1024 1.00 7.5±0.01µs ? ?/sec 1.00 7.5±0.02µs ? ?/sec
take dense union 512 1.02 5.1±0.01µs ? ?/sec 1.00 5.0±0.02µs ? ?/sec
take fixed_size_list<i32>[22] 1024 1.00 3.5±0.01µs ? ?/sec 1.00 3.5±0.01µs ? ?/sec
take fixed_size_list<i32>[22] null indices 1024 1.00 20.8±0.02µs ? ?/sec 1.01 21.0±0.02µs ? ?/sec
take fixed_size_list<i32>[22] null values 1024 1.00 21.6±0.03µs ? ?/sec 1.00 21.7±0.03µs ? ?/sec
take fixed_size_list<i32>[8] 1024 1.00 2.8±0.00µs ? ?/sec 1.01 2.8±0.00µs ? ?/sec
take fixed_size_list<i32>[8] null indices 1024 1.00 9.5±0.01µs ? ?/sec 1.00 9.4±0.02µs ? ?/sec
take fixed_size_list<i32>[8] null values 1024 1.00 10.4±0.01µs ? ?/sec 1.00 10.4±0.01µs ? ?/sec
take fsb value len: 12, indices: 1024 1.02 1737.5±9.57ns ? ?/sec 1.00 1709.7±1.21ns ? ?/sec
take fsb value len: 12, null values, indices: 1024 1.01 2.3±0.00µs ? ?/sec 1.00 2.3±0.00µs ? ?/sec
take fsb value optimized len: 16, indices: 1024 1.01 597.1±0.94ns ? ?/sec 1.00 590.3±0.61ns ? ?/sec
take fsb value optimized len: 16, null values, indices: 1024 1.01 1204.1±2.45ns ? ?/sec 1.00 1192.2±1.61ns ? ?/sec
take i32 1024 1.02 524.5±1.81ns ? ?/sec 1.00 512.2±0.96ns ? ?/sec
take i32 512 1.00 350.7±1.44ns ? ?/sec 1.00 349.5±1.33ns ? ?/sec
take i32 null indices 1024 1.01 860.1±2.57ns ? ?/sec 1.00 853.4±1.56ns ? ?/sec
take i32 null values 1024 1.01 1120.2±1.51ns ? ?/sec 1.00 1106.1±3.11ns ? ?/sec
take i32 null values null indices 1024 1.00 1543.3±1.68ns ? ?/sec 1.00 1536.2±2.84ns ? ?/sec
take list i32 1024 1.00 5.2±0.06µs ? ?/sec 1.00 5.2±0.05µs ? ?/sec
take list i32 512 1.02 2.9±0.03µs ? ?/sec 1.00 2.8±0.02µs ? ?/sec
take list i32 null indices 1024 1.04 8.8±0.05µs ? ?/sec 1.00 8.4±0.04µs ? ?/sec
take list i32 null values 1024 1.01 4.0±0.03µs ? ?/sec 1.00 4.0±0.03µs ? ?/sec
take list i32 null values null indices 1024 1.00 7.0±0.03µs ? ?/sec 1.00 7.0±0.03µs ? ?/sec
take listview i32 1024 1.01 1045.1±1.37ns ? ?/sec 1.00 1030.1±1.40ns ? ?/sec
take listview i32 512 1.02 615.9±2.42ns ? ?/sec 1.00 602.4±1.18ns ? ?/sec
take listview i32 null indices 1024 1.00 1611.6±2.09ns ? ?/sec 1.04 1672.8±1.58ns ? ?/sec
take listview i32 null values 1024 1.01 1544.0±2.26ns ? ?/sec 1.00 1533.3±1.57ns ? ?/sec
take listview i32 null values null indices 1024 1.00 2.3±0.00µs ? ?/sec 1.03 2.4±0.00µs ? ?/sec
take map<str, i32> 1024 1.00 34.6±0.07µs ? ?/sec 1.00 34.7±0.04µs ? ?/sec
take map<str, i32> 512 1.00 19.9±0.05µs ? ?/sec 1.00 19.8±0.03µs ? ?/sec
take map<str, i32> null indices 1024 1.01 20.7±0.07µs ? ?/sec 1.00 20.5±0.04µs ? ?/sec
take map<str, i32> null values 1024 1.00 20.9±0.06µs ? ?/sec 1.00 21.0±0.03µs ? ?/sec
take primitive run logical len: 1024, physical len: 512, indices: 1024 1.01 18.7±0.02µs ? ?/sec 1.00 18.6±0.02µs ? ?/sec
take sparse union 1024 1.02 7.8±0.01µs ? ?/sec 1.00 7.6±0.01µs ? ?/sec
take sparse union 512 1.00 4.7±0.02µs ? ?/sec 1.00 4.7±0.01µs ? ?/sec
take str 1024 1.00 8.0±0.01µs ? ?/sec 1.04 8.4±0.00µs ? ?/sec
take str 512 1.00 3.7±0.00µs ? ?/sec 1.00 3.7±0.01µs ? ?/sec
take str null indices 1024 1.03 4.5±0.06µs ? ?/sec 1.00 4.4±0.07µs ? ?/sec
take str null indices 512 1.01 2.2±0.03µs ? ?/sec 1.00 2.1±0.04µs ? ?/sec
take str null values 1024 1.00 4.5±0.05µs ? ?/sec 1.00 4.5±0.06µs ? ?/sec
take str null values null indices 1024 1.00 3.0±0.02µs ? ?/sec 1.03 3.1±0.02µs ? ?/sec
take string run logical len: 1024, physical len: 128, indices: 1024 1.01 24.0±0.11µs ? ?/sec 1.00 23.8±0.10µs ? ?/sec
take string run logical len: 1024, physical len: 512, indices: 1024 1.01 24.7±0.14µs ? ?/sec 1.00 24.3±0.10µs ? ?/sec
take string run logical len: 1024, physical len: 512, null indices: 1024 1.00 16.8±0.06µs ? ?/sec 1.01 17.0±0.06µs ? ?/sec
take stringview 1024 1.02 674.1±1.60ns ? ?/sec 1.00 659.6±1.63ns ? ?/sec
take stringview 512 1.02 410.1±1.55ns ? ?/sec 1.00 403.9±1.37ns ? ?/sec
take stringview null indices 1024 1.01 851.1±2.33ns ? ?/sec 1.00 844.0±0.54ns ? ?/sec
take stringview null indices 512 1.01 501.9±0.94ns ? ?/sec 1.00 499.2±0.43ns ? ?/sec
take stringview null values 1024 1.00 1244.5±3.15ns ? ?/sec 1.04 1296.5±0.61ns ? ?/sec
take stringview null values null indices 1024 1.01 1588.6±2.64ns ? ?/sec 1.00 1577.6±1.73ns ? ?/sec
take_record_batch 5 primitive cols no nulls 1024 1.00 2.9±0.01µs ? ?/sec 1.00 2.9±0.01µs ? ?/sec
take_record_batch 6 string/binary cols no nulls 1024 1.00 27.1±0.07µs ? ?/sec 1.01 27.5±0.05µs ? ?/sec
take_record_batch 7 mixed cols null values 1024 1.00 14.0±0.09µs ? ?/sec 1.01 14.2±0.41µs ? ?/sec
take_record_batch 7 mixed cols null values null indices 1024 1.00 13.4±0.04µs ? ?/sec 1.01 13.4±0.14µs ? ?/sec
```
</p>
</details>
<details><summary>Resource Usage</summary>
**base (merge-base)**
| Metric | Value |
|--------|-------|
| Wall time | 585.1s |
| Peak memory | 18.3 MiB |
| Avg memory | 14.3 MiB |
| CPU user | 582.4s |
| CPU sys | 0.0s |
| Peak spill | 0 B |
**branch**
| Metric | Value |
|--------|-------|
| Wall time | 585.1s |
| Peak memory | 17.4 MiB |
| Avg memory | 14.4 MiB |
| CPU user | 580.7s |
| CPU sys | 0.0s |
| Peak spill | 0 B |
</details>
---
[File an issue](https://github.com/adriangb/datafusion-benchmarking/issues) against this benchmark runner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Rich t kid/thread unsafe checks against const generic [arrow-rs]
Posted by "adriangbot (via GitHub)" <gi...@apache.org>.
adriangbot commented on PR #10944:
URL: https://github.com/apache/arrow-rs/pull/10944#issuecomment-5498472509
🤖 Arrow criterion benchmark running (GKE) | [trigger](https://github.com/apache/arrow-rs/pull/10944#issuecomment-5498435298)
**Instance:** `c4a-highmem-16` (12 vCPU / 65 GiB) | `Linux bench-c5498435298-2064-9kcl4 6.12.94+ #1 SMP Fri Jul 17 09:42:57 UTC 2026 aarch64 GNU/Linux`
<details><summary>CPU Details (lscpu)</summary>
```
Architecture: aarch64
CPU op-mode(s): 64-bit
Byte Order: Little Endian
CPU(s): 16
On-line CPU(s) list: 0-15
Vendor ID: ARM
Model name: Neoverse-V2
Model: 1
Thread(s) per core: 1
Core(s) per cluster: 16
Socket(s): -
Cluster(s): 1
Stepping: r0p1
BogoMIPS: 2000.00
Flags: fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm sb paca pacg dcpodp sve2 sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm bf16 dgh rng bti
L1d cache: 1 MiB (16 instances)
L1i cache: 1 MiB (16 instances)
L2 cache: 32 MiB (16 instances)
L3 cache: 80 MiB (1 instance)
NUMA node(s): 1
NUMA node0 CPU(s): 0-15
Vulnerability Gather data sampling: Not affected
Vulnerability Indirect target selection: Not affected
Vulnerability Itlb multihit: Not affected
Vulnerability L1tf: Not affected
Vulnerability Mds: Not affected
Vulnerability Meltdown: Not affected
Vulnerability Mmio stale data: Not affected
Vulnerability Reg file data sampling: Not affected
Vulnerability Retbleed: Not affected
Vulnerability Spec rstack overflow: Not affected
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1: Mitigation; __user pointer sanitization
Vulnerability Spectre v2: Mitigation; CSV2, BHB
Vulnerability Srbds: Not affected
Vulnerability Tsa: Not affected
Vulnerability Tsx async abort: Not affected
Vulnerability Vmscape: Not affected
```
</details>
Comparing rich-T-kid/thread-unsafe-checks-against-const-generic (f2d6a4cd93b16907eb41282ae67ceb88c7141006) to 27a6a40 (merge-base) [diff](https://github.com/apache/arrow-rs/compare/27a6a408796a4d855a0d997a86682401f383d352..f2d6a4cd93b16907eb41282ae67ceb88c7141006)
<details><summary>Run configuration</summary>
```yaml
run benchmark take_kernel
```
</details>
BENCH_COMMAND=cargo bench --features=arrow,async,test_common,experimental,object_store --bench take_kernel
Results will be posted here when complete
---
[File an issue](https://github.com/adriangb/datafusion-benchmarking/issues) against this benchmark runner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] perf(arrow-select) : rename generic bound & avoid bounds check in take_primitive [arrow-rs]
Posted by "Rich-T-kid (via GitHub)" <gi...@apache.org>.
Rich-T-kid commented on PR #10944:
URL: https://github.com/apache/arrow-rs/pull/10944#issuecomment-5512003041
run benchmark take_kernel
env:
BENCH_FILTER: "primitive"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] perf(arrow-select) : rename generic bound & avoid bounds check in take_primitive [arrow-rs]
Posted by "adriangbot (via GitHub)" <gi...@apache.org>.
adriangbot commented on PR #10944:
URL: https://github.com/apache/arrow-rs/pull/10944#issuecomment-5514099401
🤖 Arrow criterion benchmark running (GKE) | [trigger](https://github.com/apache/arrow-rs/pull/10944#issuecomment-5513888292)
**Instance:** `c4a-highmem-16` (12 vCPU / 65 GiB) | `Linux bench-c5513888292-2099-r96xs 6.12.94+ #1 SMP Fri Jul 17 09:42:57 UTC 2026 aarch64 GNU/Linux`
<details><summary>CPU Details (lscpu)</summary>
```
Architecture: aarch64
CPU op-mode(s): 64-bit
Byte Order: Little Endian
CPU(s): 16
On-line CPU(s) list: 0-15
Vendor ID: ARM
Model name: Neoverse-V2
Model: 1
Thread(s) per core: 1
Core(s) per cluster: 16
Socket(s): -
Cluster(s): 1
Stepping: r0p1
BogoMIPS: 2000.00
Flags: fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm sb paca pacg dcpodp sve2 sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm bf16 dgh rng bti
L1d cache: 1 MiB (16 instances)
L1i cache: 1 MiB (16 instances)
L2 cache: 32 MiB (16 instances)
L3 cache: 80 MiB (1 instance)
NUMA node(s): 1
NUMA node0 CPU(s): 0-15
Vulnerability Gather data sampling: Not affected
Vulnerability Indirect target selection: Not affected
Vulnerability Itlb multihit: Not affected
Vulnerability L1tf: Not affected
Vulnerability Mds: Not affected
Vulnerability Meltdown: Not affected
Vulnerability Mmio stale data: Not affected
Vulnerability Reg file data sampling: Not affected
Vulnerability Retbleed: Not affected
Vulnerability Spec rstack overflow: Not affected
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1: Mitigation; __user pointer sanitization
Vulnerability Spectre v2: Mitigation; CSV2, BHB
Vulnerability Srbds: Not affected
Vulnerability Tsa: Not affected
Vulnerability Tsx async abort: Not affected
Vulnerability Vmscape: Not affected
```
</details>
Comparing rich-T-kid/thread-unsafe-checks-against-const-generic (2a59992edf4adf0c84dca0d5104f05e1137249c1) to f12c504 (merge-base) [diff](https://github.com/apache/arrow-rs/compare/f12c5045e8c331bc3fc945eadea02b4bb1ca0d8c..2a59992edf4adf0c84dca0d5104f05e1137249c1)
<details><summary>Run configuration</summary>
```yaml
run benchmark take_kernels
env:
BENCH_FILTER: "primitive"
```
</details>
BENCH_COMMAND=cargo bench --features=arrow,async,test_common,experimental,object_store --bench take_kernels
Results will be posted here when complete
---
[File an issue](https://github.com/adriangb/datafusion-benchmarking/issues) against this benchmark runner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] perf(arrow-select) : rename generic bound & avoid bounds check in take_primitive [arrow-rs]
Posted by "adriangbot (via GitHub)" <gi...@apache.org>.
adriangbot commented on PR #10944:
URL: https://github.com/apache/arrow-rs/pull/10944#issuecomment-5518500210
🤖 Arrow criterion benchmark running (GKE) | [trigger](https://github.com/apache/arrow-rs/pull/10944#issuecomment-5518471025)
**Instance:** `c4a-highmem-16` (12 vCPU / 65 GiB) | `Linux bench-c5518471025-2111-dnv24 6.12.94+ #1 SMP Fri Jul 17 09:42:57 UTC 2026 aarch64 GNU/Linux`
<details><summary>CPU Details (lscpu)</summary>
```
Architecture: aarch64
CPU op-mode(s): 64-bit
Byte Order: Little Endian
CPU(s): 16
On-line CPU(s) list: 0-15
Vendor ID: ARM
Model name: Neoverse-V2
Model: 1
Thread(s) per core: 1
Core(s) per cluster: 16
Socket(s): -
Cluster(s): 1
Stepping: r0p1
BogoMIPS: 2000.00
Flags: fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm sb paca pacg dcpodp sve2 sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm bf16 dgh rng bti
L1d cache: 1 MiB (16 instances)
L1i cache: 1 MiB (16 instances)
L2 cache: 32 MiB (16 instances)
L3 cache: 80 MiB (1 instance)
NUMA node(s): 1
NUMA node0 CPU(s): 0-15
Vulnerability Gather data sampling: Not affected
Vulnerability Indirect target selection: Not affected
Vulnerability Itlb multihit: Not affected
Vulnerability L1tf: Not affected
Vulnerability Mds: Not affected
Vulnerability Meltdown: Not affected
Vulnerability Mmio stale data: Not affected
Vulnerability Reg file data sampling: Not affected
Vulnerability Retbleed: Not affected
Vulnerability Spec rstack overflow: Not affected
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1: Mitigation; __user pointer sanitization
Vulnerability Spectre v2: Mitigation; CSV2, BHB
Vulnerability Srbds: Not affected
Vulnerability Tsa: Not affected
Vulnerability Tsx async abort: Not affected
Vulnerability Vmscape: Not affected
```
</details>
Comparing rich-T-kid/thread-unsafe-checks-against-const-generic (2a59992edf4adf0c84dca0d5104f05e1137249c1) to f12c504 (merge-base) [diff](https://github.com/apache/arrow-rs/compare/f12c5045e8c331bc3fc945eadea02b4bb1ca0d8c..2a59992edf4adf0c84dca0d5104f05e1137249c1)
<details><summary>Run configuration</summary>
```yaml
run benchmark take_kernels
```
</details>
BENCH_COMMAND=cargo bench --features=arrow,async,test_common,experimental,object_store --bench take_kernels
Results will be posted here when complete
---
[File an issue](https://github.com/adriangb/datafusion-benchmarking/issues) against this benchmark runner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] perf(arrow-select) : rename generic bound & avoid bounds check in take_primitive [arrow-rs]
Posted by "Rich-T-kid (via GitHub)" <gi...@apache.org>.
Rich-T-kid commented on PR #10944:
URL: https://github.com/apache/arrow-rs/pull/10944#issuecomment-5513888292
run benchmark take_kernels
env:
BENCH_FILTER: primitive
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Rich t kid/thread unsafe checks against const generic [arrow-rs]
Posted by "adriangbot (via GitHub)" <gi...@apache.org>.
adriangbot commented on PR #10944:
URL: https://github.com/apache/arrow-rs/pull/10944#issuecomment-5498474091
Benchmark for [this request](https://github.com/apache/arrow-rs/pull/10944#issuecomment-5498435298) failed before finishing (Kubernetes reason: `BackoffLimitExceeded`).
Benchmarks requested: `take_kernel`
<details><summary>Kubernetes message</summary>
```
Job has reached the specified backoff limit
```
</details>
---
[File an issue](https://github.com/adriangb/datafusion-benchmarking/issues) against this benchmark runner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] perf(arrow-select) : rename generic bound & avoid bounds check in take_primitive [arrow-rs]
Posted by "Rich-T-kid (via GitHub)" <gi...@apache.org>.
Rich-T-kid commented on PR #10944:
URL: https://github.com/apache/arrow-rs/pull/10944#issuecomment-5503826313
> are we sure this isnt noise? from what i see in this PR, the generic isn't actually being threaded in to be false anywhere
this is true, it could be noise. when I ran the benchmarks locally I did switch out the true for false before/after running the benchmarks to compare
> just something to think about 🤔
I will keep this in mind. I think seeing the performance difference between the two variants will give us the best guide on weather or not its worth introducing the extra code. #10945 should have this once I can get the benchmarks bot working
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org