You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Dineshkumar Yadav <di...@outlook.com> on 2021/11/12 14:37:55 UTC

Re: Review Request 73707: RANGER-3511:Create Java patch to update policy resource-signature to unique value.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73707/
-----------------------------------------------------------

(Updated Nov. 12, 2021, 2:37 p.m.)


Review request for ranger, Jayendra Parab, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Vishal Suvagia, and Velmurugan Periasamy.


Bugs: RANGER-3511
    https://issues.apache.org/jira/browse/RANGER-3511


Repository: ranger


Description
-------

This patch will re-calculate and update policy resource_signature for all disabled Ranger Policies.


Diffs
-----

  security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql 9e2892a1c 
  security-admin/db/oracle/optimized/current/ranger_core_db_oracle.sql 65f9ad2f6 
  security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql a5bcf488b 
  security-admin/db/sqlanywhere/optimized/current/ranger_core_db_sqlanywhere.sql a48f2348c 
  security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql 5cbe6d5a7 
  security-admin/src/main/java/org/apache/ranger/db/XXPolicyDao.java 41ca8b2a6 
  security-admin/src/main/java/org/apache/ranger/patch/PatchPreSql_058_ForUpdateToUniqueResoureceSignature_J10053.java PRE-CREATION 
  security-admin/src/main/resources/META-INF/jpa_named_queries.xml 85cadbbd5 


Diff: https://reviews.apache.org/r/73707/diff/4/


Testing
-------

Tested for all the disabled ranger policies.


Thanks,

Dineshkumar Yadav


Re: Review Request 73707: RANGER-3511:Create Java patch to update policy resource-signature to unique value.

Posted by bhavik patel <bh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73707/#review223740
-----------------------------------------------------------




security-admin/src/main/java/org/apache/ranger/patch/PatchPreSql_058_ForUpdateToUniqueResoureceSignature_J10053.java
Lines 104 (patched)
<https://reviews.apache.org/r/73707/#comment312839>

    Print Policy Id or policy Name.



security-admin/src/main/java/org/apache/ranger/patch/PatchPreSql_058_ForUpdateToUniqueResoureceSignature_J10053.java
Lines 112 (patched)
<https://reviews.apache.org/r/73707/#comment312840>

    Please update the message to "Disabled policy not found" (remove 'XX')


- bhavik patel


On Nov. 12, 2021, 2:37 p.m., Dineshkumar Yadav wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73707/
> -----------------------------------------------------------
> 
> (Updated Nov. 12, 2021, 2:37 p.m.)
> 
> 
> Review request for ranger, Jayendra Parab, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Vishal Suvagia, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3511
>     https://issues.apache.org/jira/browse/RANGER-3511
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> This patch will re-calculate and update policy resource_signature for all disabled Ranger Policies.
> 
> 
> Diffs
> -----
> 
>   security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql 9e2892a1c 
>   security-admin/db/oracle/optimized/current/ranger_core_db_oracle.sql 65f9ad2f6 
>   security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql a5bcf488b 
>   security-admin/db/sqlanywhere/optimized/current/ranger_core_db_sqlanywhere.sql a48f2348c 
>   security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql 5cbe6d5a7 
>   security-admin/src/main/java/org/apache/ranger/db/XXPolicyDao.java 41ca8b2a6 
>   security-admin/src/main/java/org/apache/ranger/patch/PatchPreSql_058_ForUpdateToUniqueResoureceSignature_J10053.java PRE-CREATION 
>   security-admin/src/main/resources/META-INF/jpa_named_queries.xml 85cadbbd5 
> 
> 
> Diff: https://reviews.apache.org/r/73707/diff/4/
> 
> 
> Testing
> -------
> 
> Tested for all the disabled ranger policies.
> 
> 
> Thanks,
> 
> Dineshkumar Yadav
> 
>


Re: Review Request 73707: RANGER-3511:Create Java patch to update policy resource-signature to unique value.

Posted by Pradeep Agrawal <pr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73707/#review223745
-----------------------------------------------------------


Ship it!




Ship It!

- Pradeep Agrawal


On Nov. 16, 2021, 2:59 p.m., Dineshkumar Yadav wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73707/
> -----------------------------------------------------------
> 
> (Updated Nov. 16, 2021, 2:59 p.m.)
> 
> 
> Review request for ranger, Jayendra Parab, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Vishal Suvagia, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3511
>     https://issues.apache.org/jira/browse/RANGER-3511
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> This patch will re-calculate and update policy resource_signature for all disabled Ranger Policies.
> 
> 
> Diffs
> -----
> 
>   security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql 9e2892a1c 
>   security-admin/db/oracle/optimized/current/ranger_core_db_oracle.sql 65f9ad2f6 
>   security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql a5bcf488b 
>   security-admin/db/sqlanywhere/optimized/current/ranger_core_db_sqlanywhere.sql a48f2348c 
>   security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql 5cbe6d5a7 
>   security-admin/src/main/java/org/apache/ranger/db/XXPolicyDao.java 41ca8b2a6 
>   security-admin/src/main/java/org/apache/ranger/patch/PatchPreSql_058_ForUpdateToUniqueResoureceSignature_J10053.java PRE-CREATION 
>   security-admin/src/main/resources/META-INF/jpa_named_queries.xml 85cadbbd5 
> 
> 
> Diff: https://reviews.apache.org/r/73707/diff/5/
> 
> 
> Testing
> -------
> 
> Tested for all the disabled ranger policies.
> 
> 
> Thanks,
> 
> Dineshkumar Yadav
> 
>


Re: Review Request 73707: RANGER-3511:Create Java patch to update policy resource-signature to unique value.

Posted by Dineshkumar Yadav <di...@outlook.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73707/
-----------------------------------------------------------

(Updated Nov. 23, 2021, 9:35 a.m.)


Review request for ranger, Jayendra Parab, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Vishal Suvagia, and Velmurugan Periasamy.


Changes
-------

resolved merge conflicts.


Bugs: RANGER-3511
    https://issues.apache.org/jira/browse/RANGER-3511


Repository: ranger


Description
-------

This patch will re-calculate and update policy resource_signature for all disabled Ranger Policies.


Diffs (updated)
-----

  security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql 57af321a3 
  security-admin/db/oracle/optimized/current/ranger_core_db_oracle.sql 25ee44cc5 
  security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql 78cee1a93 
  security-admin/db/sqlanywhere/optimized/current/ranger_core_db_sqlanywhere.sql 632aefe1d 
  security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql fa29da008 
  security-admin/src/main/java/org/apache/ranger/db/XXPolicyDao.java 41ca8b2a6 
  security-admin/src/main/java/org/apache/ranger/patch/PatchPreSql_058_ForUpdateToUniqueResoureceSignature_J10053.java PRE-CREATION 
  security-admin/src/main/resources/META-INF/jpa_named_queries.xml 85cadbbd5 


Diff: https://reviews.apache.org/r/73707/diff/6/

Changes: https://reviews.apache.org/r/73707/diff/5-6/


Testing
-------

Tested for all the disabled ranger policies.


Thanks,

Dineshkumar Yadav


Re: Review Request 73707: RANGER-3511:Create Java patch to update policy resource-signature to unique value.

Posted by Dineshkumar Yadav <di...@outlook.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73707/
-----------------------------------------------------------

(Updated Nov. 16, 2021, 2:59 p.m.)


Review request for ranger, Jayendra Parab, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Vishal Suvagia, and Velmurugan Periasamy.


Changes
-------

updated comment


Bugs: RANGER-3511
    https://issues.apache.org/jira/browse/RANGER-3511


Repository: ranger


Description
-------

This patch will re-calculate and update policy resource_signature for all disabled Ranger Policies.


Diffs (updated)
-----

  security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql 9e2892a1c 
  security-admin/db/oracle/optimized/current/ranger_core_db_oracle.sql 65f9ad2f6 
  security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql a5bcf488b 
  security-admin/db/sqlanywhere/optimized/current/ranger_core_db_sqlanywhere.sql a48f2348c 
  security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql 5cbe6d5a7 
  security-admin/src/main/java/org/apache/ranger/db/XXPolicyDao.java 41ca8b2a6 
  security-admin/src/main/java/org/apache/ranger/patch/PatchPreSql_058_ForUpdateToUniqueResoureceSignature_J10053.java PRE-CREATION 
  security-admin/src/main/resources/META-INF/jpa_named_queries.xml 85cadbbd5 


Diff: https://reviews.apache.org/r/73707/diff/5/

Changes: https://reviews.apache.org/r/73707/diff/4-5/


Testing
-------

Tested for all the disabled ranger policies.


Thanks,

Dineshkumar Yadav