You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "dashanji (via GitHub)" <gi...@apache.org> on 2023/03/06 11:42:34 UTC
[GitHub] [airflow] dashanji opened a new pull request, #29936: Fix some typos on the kubernetes documentation
dashanji opened a new pull request, #29936:
URL: https://github.com/apache/airflow/pull/29936
As tilted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #29936: Fix some typos on the kubernetes documentation
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #29936:
URL: https://github.com/apache/airflow/pull/29936#issuecomment-1455979504
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (ruff, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #29936: Fix some typos on the kubernetes documentation
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #29936:
URL: https://github.com/apache/airflow/pull/29936
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #29936: Fix some typos on the kubernetes documentation
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #29936:
URL: https://github.com/apache/airflow/pull/29936#issuecomment-1468914620
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dashanji commented on a diff in pull request #29936: Fix some typos on the kubernetes documentation
Posted by "dashanji (via GitHub)" <gi...@apache.org>.
dashanji commented on code in PR #29936:
URL: https://github.com/apache/airflow/pull/29936#discussion_r1129050711
##########
docs/apache-airflow/administration-and-deployment/production-deployment.rst:
##########
@@ -38,7 +38,7 @@ You can change the backend using the following config
sql_alchemy_conn = my_conn_string
Once you have changed the backend, airflow needs to create all the tables required for operation.
-Create an empty DB and give airflow's user the permission to ``CREATE/ALTER`` it.
+Create an empty DB and give airflow's user permission to ``CREATE/ALTER`` it.
Review Comment:
Thanks for the catching.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a diff in pull request #29936: Fix some typos on the kubernetes documentation
Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr commented on code in PR #29936:
URL: https://github.com/apache/airflow/pull/29936#discussion_r1128985878
##########
docs/apache-airflow/administration-and-deployment/production-deployment.rst:
##########
@@ -38,7 +38,7 @@ You can change the backend using the following config
sql_alchemy_conn = my_conn_string
Once you have changed the backend, airflow needs to create all the tables required for operation.
-Create an empty DB and give airflow's user the permission to ``CREATE/ALTER`` it.
+Create an empty DB and give airflow's user permission to ``CREATE/ALTER`` it.
Review Comment:
```suggestion
Create an empty DB and give Airflow's user permission to ``CREATE/ALTER`` it.
```
while we are on this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org