You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2020/03/12 11:00:07 UTC
[GitHub] [mynewt-mcumgr] de-nordic opened a new pull request #71: ext: lib:
mgmt: Enabling Zephyr/mynewt-core version of tinycbor
de-nordic opened a new pull request #71: ext: lib: mgmt: Enabling Zephyr/mynewt-core version of tinycbor
URL: https://github.com/apache/mynewt-mcumgr/pull/71
Changes needed due to overwrite of Zephyr fork of Tinycbor with
mynewt-core version.
Signed-off-by: Dominik Ermel <do...@nordicsemi.no>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-mcumgr] utzig commented on issue #71: ext: lib: mgmt:
Enabling Zephyr/mynewt-core version of tinycbor
Posted by GitBox <gi...@apache.org>.
utzig commented on issue #71: ext: lib: mgmt: Enabling Zephyr/mynewt-core version of tinycbor
URL: https://github.com/apache/mynewt-mcumgr/pull/71#issuecomment-598201979
> @utzig @sjanc can we merge this?
I honestly did not understand @de-nordic comment, but I believe you both know what you're doing!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-mcumgr] de-nordic commented on issue #71: ext: lib: mgmt:
Enabling Zephyr/mynewt-core version of tinycbor
Posted by GitBox <gi...@apache.org>.
de-nordic commented on issue #71: ext: lib: mgmt: Enabling Zephyr/mynewt-core version of tinycbor
URL: https://github.com/apache/mynewt-mcumgr/pull/71#issuecomment-598184371
>
>
> Is this dependent on the merge of [zephyrproject-rtos/tinycbor#11](https://github.com/zephyrproject-rtos/tinycbor/pull/11) ?
It is dependent for Zephyr, as zephyr will not compile if both changes (this and tinycbor) are done at the same time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-mcumgr] utzig commented on issue #71: ext: lib: mgmt:
Enabling Zephyr/mynewt-core version of tinycbor
Posted by GitBox <gi...@apache.org>.
utzig commented on issue #71: ext: lib: mgmt: Enabling Zephyr/mynewt-core version of tinycbor
URL: https://github.com/apache/mynewt-mcumgr/pull/71#issuecomment-598132547
Is this dependent on the merge of https://github.com/zephyrproject-rtos/tinycbor/pull/11 ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-mcumgr] utzig commented on issue #71: ext: lib: mgmt:
Enabling Zephyr/mynewt-core version of tinycbor
Posted by GitBox <gi...@apache.org>.
utzig commented on issue #71: ext: lib: mgmt: Enabling Zephyr/mynewt-core version of tinycbor
URL: https://github.com/apache/mynewt-mcumgr/pull/71#issuecomment-598203289
> I honestly did not understand @de-nordic comment, but I believe you both know what you're doing!
To be clear, this obviously only affects Zephyr, so there's no point in saying it. What was not clear to me is where the changes that add tinycbor from Mynewt on Zephyr are, but you both sure of the change, and I don't see anything wrong with it either!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-mcumgr] utzig merged pull request #71: ext: lib: mgmt:
Enabling Zephyr/mynewt-core version of tinycbor
Posted by GitBox <gi...@apache.org>.
utzig merged pull request #71: ext: lib: mgmt: Enabling Zephyr/mynewt-core version of tinycbor
URL: https://github.com/apache/mynewt-mcumgr/pull/71
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-mcumgr] carlescufi commented on issue #71: ext: lib: mgmt:
Enabling Zephyr/mynewt-core version of tinycbor
Posted by GitBox <gi...@apache.org>.
carlescufi commented on issue #71: ext: lib: mgmt: Enabling Zephyr/mynewt-core version of tinycbor
URL: https://github.com/apache/mynewt-mcumgr/pull/71#issuecomment-598203050
Thanks! @utzig we are trying to consolidate tinycbor so that it's the same as in mynewt.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-mcumgr] carlescufi commented on issue #71: ext: lib: mgmt:
Enabling Zephyr/mynewt-core version of tinycbor
Posted by GitBox <gi...@apache.org>.
carlescufi commented on issue #71: ext: lib: mgmt: Enabling Zephyr/mynewt-core version of tinycbor
URL: https://github.com/apache/mynewt-mcumgr/pull/71#issuecomment-598200772
@utzig @sjanc can we merge this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services