You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ws.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2013/01/28 19:57:12 UTC
[jira] [Commented] (AXIOM-435) Consistently implement support for
entity references
[ https://issues.apache.org/jira/browse/AXIOM-435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13564534#comment-13564534 ]
Hudson commented on AXIOM-435:
------------------------------
Integrated in ws-axiom-trunk #1413 (See [https://builds.apache.org/job/ws-axiom-trunk/1413/])
AXIOM-435: Removed dead code. (Revision 1439517)
Result = SUCCESS
veithen :
Files :
* /webservices/axiom/trunk/modules/axiom-dom/src/main/java/org/apache/axiom/om/impl/dom/TextNodeImpl.java
* /webservices/axiom/trunk/modules/axiom-impl/src/main/java/org/apache/axiom/om/impl/llom/OMTextImpl.java
> Consistently implement support for entity references
> ----------------------------------------------------
>
> Key: AXIOM-435
> URL: https://issues.apache.org/jira/browse/AXIOM-435
> Project: Axiom
> Issue Type: Improvement
> Components: API
> Affects Versions: 1.2.13
> Reporter: Andreas Veithen
> Assignee: Andreas Veithen
> Priority: Minor
> Fix For: 1.2.14
>
>
> Currently (unexpanded) entity references are represented as OMText instances with type=ENTITY_REFERENCE_NODE. This is a bad choice:
> * An entity reference doesn't necessarily represent character data: the expansion can e.g. produce elements. Representing it as an OMText is therefore conceptually wrong.
> * There is lots of code that checks for OMText and then uses OMText#getText() under the assumption that the return value represents character data. However, for an entity reference, getText() would return the entity name.
> It should also be noted that the test coverage for entity references is currently almost nonexistent. As a result, the code that handles entity references is inconsistent. E.g. OMStAXWrapper/SwitchingWrapper contains the following code:
> if ((currentEvent == START_ELEMENT)
> || (currentEvent == END_ELEMENT)
> || (currentEvent == ENTITY_REFERENCE)) {
> return ((OMElement) lastNode).getLocalName();
> } else {
> throw new IllegalStateException();
> }
> This is obviously incorrect.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org