You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by cloud-fan <gi...@git.apache.org> on 2017/01/16 02:27:58 UTC

[GitHub] spark pull request #16561: [SPARK-18801][SQL][FOLLOWUP] Alias the view with ...

Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16561#discussion_r96157156
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala ---
    @@ -198,9 +203,44 @@ case class CatalogTable(
     
       /**
        * Return the default database name we use to resolve a view, should be None if the CatalogTable
    -   * is not a View.
    +   * is not a View or created by older versions of Spark(before 2.2.0).
    +   */
    +  def viewDefaultDatabase: Option[String] = properties.get(VIEW_DEFAULT_DATABASE)
    +
    +  /**
    +   * Return the output column names of the query that creates a view, the column names are used to
    +   * resolve a view, should be None if the CatalogTable is not a View or created by older versions
    --- End diff --
    
    should be `Nil`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org