You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2015/09/07 18:04:36 UTC

Review Request 38160: Documented how to expedite event firing.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38160/
-----------------------------------------------------------

Review request for mesos, Bernd Mathiske and Ben Mahler.


Repository: mesos


Description
-------

See summary.


Diffs
-----

  docs/mesos-testing-patterns.md d0d92ff569012677043a03412462cf4384096ba9 

Diff: https://reviews.apache.org/r/38160/diff/


Testing
-------

doc rendered in Markdown


Thanks,

Alexander Rukletsov


Re: Review Request 38160: Documented how to expedite event firing.

Posted by Guangya Liu <gy...@gmail.com>.

> On 九月 8, 2015, 3:44 p.m., Guangya Liu wrote:
> > docs/mesos-testing-patterns.md, line 10
> > <https://reviews.apache.org/r/38160/diff/1/?file=1064801#file1064801line10>
> >
> >     What does "Naïve" means?
> 
> haosdent huang wrote:
>     Naïve waiting means just waiting until timeout. Like:
>     ```
>     AWAIT_READY(Future)
>     ```
>     would waiting `Future` to complete or timeout after 15 seconds.

Should not it be "Naive"? The "Naïve" does not like to be a english word?


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38160/#review98011
-----------------------------------------------------------


On 九月 7, 2015, 4:04 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38160/
> -----------------------------------------------------------
> 
> (Updated 九月 7, 2015, 4:04 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   docs/mesos-testing-patterns.md d0d92ff569012677043a03412462cf4384096ba9 
> 
> Diff: https://reviews.apache.org/r/38160/diff/
> 
> 
> Testing
> -------
> 
> doc rendered in Markdown
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Re: Review Request 38160: Documented how to expedite event firing.

Posted by haosdent huang <ha...@gmail.com>.

> On Sept. 8, 2015, 3:44 p.m., Guangya Liu wrote:
> > docs/mesos-testing-patterns.md, line 10
> > <https://reviews.apache.org/r/38160/diff/1/?file=1064801#file1064801line10>
> >
> >     What does "Naïve" means?
> 
> haosdent huang wrote:
>     Naïve waiting means just waiting until timeout. Like:
>     ```
>     AWAIT_READY(Future)
>     ```
>     would waiting `Future` to complete or timeout after 15 seconds.
> 
> Guangya Liu wrote:
>     Should not it be "Naive"? The "Naïve" does not like to be a english word?

https://en.wiktionary.org/wiki/na%C3%AFve


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38160/#review98011
-----------------------------------------------------------


On Sept. 7, 2015, 4:04 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38160/
> -----------------------------------------------------------
> 
> (Updated Sept. 7, 2015, 4:04 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   docs/mesos-testing-patterns.md d0d92ff569012677043a03412462cf4384096ba9 
> 
> Diff: https://reviews.apache.org/r/38160/diff/
> 
> 
> Testing
> -------
> 
> doc rendered in Markdown
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Re: Review Request 38160: Documented how to expedite event firing.

Posted by Alexander Rukletsov <ru...@gmail.com>.

> On Sept. 8, 2015, 3:44 p.m., Guangya Liu wrote:
> > docs/mesos-testing-patterns.md, line 10
> > <https://reviews.apache.org/r/38160/diff/1/?file=1064801#file1064801line10>
> >
> >     What does "Naïve" means?
> 
> haosdent huang wrote:
>     Naïve waiting means just waiting until timeout. Like:
>     ```
>     AWAIT_READY(Future)
>     ```
>     would waiting `Future` to complete or timeout after 15 seconds.
> 
> Guangya Liu wrote:
>     Should not it be "Naive"? The "Naïve" does not like to be a english word?
> 
> haosdent huang wrote:
>     https://en.wiktionary.org/wiki/na%C3%AFve

@gyliu: do you think I should expand the comment or change wording here? if not, mind dropping the issue? Thanks!


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38160/#review98011
-----------------------------------------------------------


On Sept. 7, 2015, 4:04 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38160/
> -----------------------------------------------------------
> 
> (Updated Sept. 7, 2015, 4:04 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   docs/mesos-testing-patterns.md d0d92ff569012677043a03412462cf4384096ba9 
> 
> Diff: https://reviews.apache.org/r/38160/diff/
> 
> 
> Testing
> -------
> 
> doc rendered in Markdown
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Re: Review Request 38160: Documented how to expedite event firing.

Posted by haosdent huang <ha...@gmail.com>.

> On Sept. 8, 2015, 3:44 p.m., Guangya Liu wrote:
> > docs/mesos-testing-patterns.md, line 10
> > <https://reviews.apache.org/r/38160/diff/1/?file=1064801#file1064801line10>
> >
> >     What does "Naïve" means?

Naïve waiting means just waiting until timeout. Like:
```
AWAIT_READY(Future)
```
would waiting `Future` to complete or timeout after 15 seconds.


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38160/#review98011
-----------------------------------------------------------


On Sept. 7, 2015, 4:04 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38160/
> -----------------------------------------------------------
> 
> (Updated Sept. 7, 2015, 4:04 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   docs/mesos-testing-patterns.md d0d92ff569012677043a03412462cf4384096ba9 
> 
> Diff: https://reviews.apache.org/r/38160/diff/
> 
> 
> Testing
> -------
> 
> doc rendered in Markdown
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Re: Review Request 38160: Documented how to expedite event firing.

Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38160/#review98011
-----------------------------------------------------------



docs/mesos-testing-patterns.md (line 10)
<https://reviews.apache.org/r/38160/#comment154157>

    What does "Naïve" means?


- Guangya Liu


On 九月 7, 2015, 4:04 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38160/
> -----------------------------------------------------------
> 
> (Updated 九月 7, 2015, 4:04 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   docs/mesos-testing-patterns.md d0d92ff569012677043a03412462cf4384096ba9 
> 
> Diff: https://reviews.apache.org/r/38160/diff/
> 
> 
> Testing
> -------
> 
> doc rendered in Markdown
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Re: Review Request 38160: Documented how to expedite event firing.

Posted by Alexander Rukletsov <ru...@gmail.com>.

> On Sept. 8, 2015, 2:34 p.m., Bernd Mathiske wrote:
> > docs/mesos-testing-patterns.md, line 55
> > <https://reviews.apache.org/r/38160/diff/1/?file=1064801#file1064801line55>
> >
> >     s/re-/

Good catch, thanks!


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38160/#review98005
-----------------------------------------------------------


On Sept. 7, 2015, 4:04 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38160/
> -----------------------------------------------------------
> 
> (Updated Sept. 7, 2015, 4:04 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   docs/mesos-testing-patterns.md d0d92ff569012677043a03412462cf4384096ba9 
> 
> Diff: https://reviews.apache.org/r/38160/diff/
> 
> 
> Testing
> -------
> 
> doc rendered in Markdown
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Re: Review Request 38160: Documented how to expedite event firing.

Posted by Bernd Mathiske <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38160/#review98005
-----------------------------------------------------------



docs/mesos-testing-patterns.md (line 16)
<https://reviews.apache.org/r/38160/#comment154152>

    s/the registration/registration
    s/registration request/a registration request



docs/mesos-testing-patterns.md (line 55)
<https://reviews.apache.org/r/38160/#comment154153>

    s/re-/


- Bernd Mathiske


On Sept. 7, 2015, 9:04 a.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38160/
> -----------------------------------------------------------
> 
> (Updated Sept. 7, 2015, 9:04 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   docs/mesos-testing-patterns.md d0d92ff569012677043a03412462cf4384096ba9 
> 
> Diff: https://reviews.apache.org/r/38160/diff/
> 
> 
> Testing
> -------
> 
> doc rendered in Markdown
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Re: Review Request 38160: Documented how to expedite event firing.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38160/#review100833
-----------------------------------------------------------


Patch looks great!

Reviews applied: [38161, 38160]

All tests passed.

- Mesos ReviewBot


On Sept. 28, 2015, 5:09 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38160/
> -----------------------------------------------------------
> 
> (Updated Sept. 28, 2015, 5:09 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   docs/mesos-testing-patterns.md d0d92ff569012677043a03412462cf4384096ba9 
> 
> Diff: https://reviews.apache.org/r/38160/diff/
> 
> 
> Testing
> -------
> 
> doc rendered in Markdown
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Re: Review Request 38160: Documented how to expedite event firing.

Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38160/#review100820
-----------------------------------------------------------

Ship it!


Ship It!

- haosdent huang


On Sept. 28, 2015, 5:09 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38160/
> -----------------------------------------------------------
> 
> (Updated Sept. 28, 2015, 5:09 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   docs/mesos-testing-patterns.md d0d92ff569012677043a03412462cf4384096ba9 
> 
> Diff: https://reviews.apache.org/r/38160/diff/
> 
> 
> Testing
> -------
> 
> doc rendered in Markdown
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Re: Review Request 38160: Documented how to expedite event firing.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38160/#review101214
-----------------------------------------------------------


Patch looks great!

Reviews applied: [38161, 38160]

All tests passed.

- Mesos ReviewBot


On Oct. 1, 2015, 10:07 a.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38160/
> -----------------------------------------------------------
> 
> (Updated Oct. 1, 2015, 10:07 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   docs/mesos-testing-patterns.md d0d92ff569012677043a03412462cf4384096ba9 
> 
> Diff: https://reviews.apache.org/r/38160/diff/
> 
> 
> Testing
> -------
> 
> doc rendered in Markdown
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Re: Review Request 38160: Documented how to expedite event firing.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38160/#review101320
-----------------------------------------------------------


Patch looks great!

Reviews applied: [38161, 38160]

All tests passed.

- Mesos ReviewBot


On Oct. 2, 2015, 1:26 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38160/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2015, 1:26 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   docs/mesos-testing-patterns.md d0d92ff569012677043a03412462cf4384096ba9 
> 
> Diff: https://reviews.apache.org/r/38160/diff/
> 
> 
> Testing
> -------
> 
> doc rendered in Markdown
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Re: Review Request 38160: Documented how to expedite event firing.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38160/#review101329
-----------------------------------------------------------


Patch looks great!

Reviews applied: [38161, 38952, 38160]

All tests passed.

- Mesos ReviewBot


On Oct. 2, 2015, 3:13 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38160/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2015, 3:13 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   docs/mesos-testing-patterns.md d0d92ff569012677043a03412462cf4384096ba9 
> 
> Diff: https://reviews.apache.org/r/38160/diff/
> 
> 
> Testing
> -------
> 
> doc rendered in Markdown
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Re: Review Request 38160: Documented how to expedite event firing.

Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38160/
-----------------------------------------------------------

(Updated Oct. 14, 2015, 3:51 p.m.)


Review request for mesos, Bernd Mathiske and Ben Mahler.


Changes
-------

Rebased.


Repository: mesos


Description
-------

See summary.


Diffs (updated)
-----

  docs/testing-patterns.md d0d92ff569012677043a03412462cf4384096ba9 

Diff: https://reviews.apache.org/r/38160/diff/


Testing
-------

doc rendered in Markdown


Thanks,

Alexander Rukletsov


Re: Review Request 38160: Documented how to expedite event firing.

Posted by Bernd Mathiske <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38160/#review101457
-----------------------------------------------------------

Ship it!


Ship It!

- Bernd Mathiske


On Oct. 2, 2015, 8:13 a.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38160/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2015, 8:13 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   docs/mesos-testing-patterns.md d0d92ff569012677043a03412462cf4384096ba9 
> 
> Diff: https://reviews.apache.org/r/38160/diff/
> 
> 
> Testing
> -------
> 
> doc rendered in Markdown
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Re: Review Request 38160: Documented how to expedite event firing.

Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38160/
-----------------------------------------------------------

(Updated Oct. 2, 2015, 3:13 p.m.)


Review request for mesos, Bernd Mathiske and Ben Mahler.


Changes
-------

Rebased.


Repository: mesos


Description
-------

See summary.


Diffs (updated)
-----

  docs/mesos-testing-patterns.md d0d92ff569012677043a03412462cf4384096ba9 

Diff: https://reviews.apache.org/r/38160/diff/


Testing
-------

doc rendered in Markdown


Thanks,

Alexander Rukletsov


Re: Review Request 38160: Documented how to expedite event firing.

Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38160/
-----------------------------------------------------------

(Updated Oct. 2, 2015, 1:26 p.m.)


Review request for mesos, Bernd Mathiske and Ben Mahler.


Changes
-------

Rebased.


Repository: mesos


Description
-------

See summary.


Diffs (updated)
-----

  docs/mesos-testing-patterns.md d0d92ff569012677043a03412462cf4384096ba9 

Diff: https://reviews.apache.org/r/38160/diff/


Testing
-------

doc rendered in Markdown


Thanks,

Alexander Rukletsov


Re: Review Request 38160: Documented how to expedite event firing.

Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38160/
-----------------------------------------------------------

(Updated Oct. 1, 2015, 10:07 a.m.)


Review request for mesos, Bernd Mathiske and Ben Mahler.


Changes
-------

Rebased.


Repository: mesos


Description
-------

See summary.


Diffs (updated)
-----

  docs/mesos-testing-patterns.md d0d92ff569012677043a03412462cf4384096ba9 

Diff: https://reviews.apache.org/r/38160/diff/


Testing
-------

doc rendered in Markdown


Thanks,

Alexander Rukletsov


Re: Review Request 38160: Documented how to expedite event firing.

Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38160/
-----------------------------------------------------------

(Updated Sept. 28, 2015, 5:09 p.m.)


Review request for mesos, Bernd Mathiske and Ben Mahler.


Changes
-------

Changed "naïve" to "simple" to avoid confusion.


Repository: mesos


Description
-------

See summary.


Diffs (updated)
-----

  docs/mesos-testing-patterns.md d0d92ff569012677043a03412462cf4384096ba9 

Diff: https://reviews.apache.org/r/38160/diff/


Testing
-------

doc rendered in Markdown


Thanks,

Alexander Rukletsov


Re: Review Request 38160: Documented how to expedite event firing.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38160/#review98204
-----------------------------------------------------------


Patch looks great!

Reviews applied: [38161, 38160]

All tests passed.

- Mesos ReviewBot


On Sept. 9, 2015, 2:28 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38160/
> -----------------------------------------------------------
> 
> (Updated Sept. 9, 2015, 2:28 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   docs/mesos-testing-patterns.md d0d92ff569012677043a03412462cf4384096ba9 
> 
> Diff: https://reviews.apache.org/r/38160/diff/
> 
> 
> Testing
> -------
> 
> doc rendered in Markdown
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Re: Review Request 38160: Documented how to expedite event firing.

Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38160/
-----------------------------------------------------------

(Updated Sept. 9, 2015, 2:28 p.m.)


Review request for mesos, Bernd Mathiske and Ben Mahler.


Changes
-------

Bernd's comments.


Repository: mesos


Description
-------

See summary.


Diffs (updated)
-----

  docs/mesos-testing-patterns.md d0d92ff569012677043a03412462cf4384096ba9 

Diff: https://reviews.apache.org/r/38160/diff/


Testing
-------

doc rendered in Markdown


Thanks,

Alexander Rukletsov


Re: Review Request 38160: Documented how to expedite event firing.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38160/#review97928
-----------------------------------------------------------


Patch looks great!

Reviews applied: [38161, 38160]

All tests passed.

- Mesos ReviewBot


On Sept. 7, 2015, 4:04 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38160/
> -----------------------------------------------------------
> 
> (Updated Sept. 7, 2015, 4:04 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   docs/mesos-testing-patterns.md d0d92ff569012677043a03412462cf4384096ba9 
> 
> Diff: https://reviews.apache.org/r/38160/diff/
> 
> 
> Testing
> -------
> 
> doc rendered in Markdown
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>