You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brpc.apache.org by GitBox <gi...@apache.org> on 2021/03/17 08:23:27 UTC
[GitHub] [incubator-brpc] SF-Zhou opened a new pull request #1359: Fix possible memory leak in socket.cpp
SF-Zhou opened a new pull request #1359:
URL: https://github.com/apache/incubator-brpc/pull/1359
When `bthread_start_background` fails to start, the closure `thrd_func` is not executed and released, which will cause a memory leak.
Fix: manually release when fail.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] TousakaRin commented on pull request #1359: Fix possible memory leak in socket.cpp
Posted by GitBox <gi...@apache.org>.
TousakaRin commented on pull request #1359:
URL: https://github.com/apache/incubator-brpc/pull/1359#issuecomment-881363973
Maybe it is better to use an unique_ptr?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org