You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2022/07/09 05:39:23 UTC

[GitHub] [zookeeper] tisonkun commented on a diff in pull request #1904: ZOOKEEPER-4573: Encapsulate request bytebuffer in Request

tisonkun commented on code in PR #1904:
URL: https://github.com/apache/zookeeper/pull/1904#discussion_r917225082


##########
zookeeper-server/src/main/java/org/apache/zookeeper/server/Request.java:
##########
@@ -78,7 +79,29 @@ public Request(long sessionId, int xid, int type, TxnHeader hdr, Record txn, lon
 
     public final int type;
 
-    public final ByteBuffer request;
+    private final ByteBuffer request;

Review Comment:
   This field will later be encapsulated in a `RequestSupplier` similar to @Randgalt done for `RequestPacker` here https://github.com/Randgalt/zookeeper/compare/wip-jute-rpc-generate...wip-jute-rpc-encapsulate.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org