You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2021/10/12 16:58:06 UTC

[GitHub] [hbase] nkalmar edited a comment on pull request #3737: HBASE-26340 - fix RegionSizeCalculator getLEngth to bytes instead of …

nkalmar edited a comment on pull request #3737:
URL: https://github.com/apache/hbase/pull/3737#issuecomment-941196132


   I assumed Size class method get(Unit unit) will return the value in teh given unit, but turns out it has just the same conversation basically, and we set it in MB so while we do get Byte unit back, it converts again from MB, but this time in Size class. We set regionszie in RegionMetricsBuilder: 
   setStoreFileSize(new Size(regionLoadPB.getStorefileSizeMB(), Size.Unit.MEGABYTE))
   
   But this is a much bigger impact change then I originally anticipated, and I have less and less belief this is something we want to change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org