You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "mawiesne (via GitHub)" <gi...@apache.org> on 2023/07/21 14:27:40 UTC
[GitHub] [commons-crypto] mawiesne opened a new pull request, #233: Fixes grammar and typos and optimizes JavaDoc
mawiesne opened a new pull request, #233:
URL: https://github.com/apache/commons-crypto/pull/233
- fixes grammar issues in JavaDoc and code comments.
- fixes some typos found along the way.
- improves JavaDoc, highlighting the keywords: `null`, `true`, `false`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-crypto] codecov-commenter commented on pull request #233: Fixes grammar and typos and optimizes JavaDoc
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #233:
URL: https://github.com/apache/commons-crypto/pull/233#issuecomment-1645682220
## [Codecov](https://app.codecov.io/gh/apache/commons-crypto/pull/233?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#233](https://app.codecov.io/gh/apache/commons-crypto/pull/233?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (3422e3e) into [master](https://app.codecov.io/gh/apache/commons-crypto/commit/e0d6fe0f601106278a37f22ac49d2e118b834478?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (e0d6fe0) will **increase** coverage by `0.38%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #233 +/- ##
============================================
+ Coverage 74.65% 75.04% +0.38%
- Complexity 445 448 +3
============================================
Files 38 38
Lines 1823 1823
Branches 181 181
============================================
+ Hits 1361 1368 +7
+ Misses 348 341 -7
Partials 114 114
```
| [Impacted Files](https://app.codecov.io/gh/apache/commons-crypto/pull/233?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...rc/main/java/org/apache/commons/crypto/Crypto.java](https://app.codecov.io/gh/apache/commons-crypto/pull/233?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY3J5cHRvL0NyeXB0by5qYXZh) | `80.48% <ø> (ø)` | |
| [...va/org/apache/commons/crypto/NativeCodeLoader.java](https://app.codecov.io/gh/apache/commons-crypto/pull/233?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY3J5cHRvL05hdGl2ZUNvZGVMb2FkZXIuamF2YQ==) | `50.00% <ø> (ø)` | |
| [...rc/main/java/org/apache/commons/crypto/OsInfo.java](https://app.codecov.io/gh/apache/commons-crypto/pull/233?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY3J5cHRvL09zSW5mby5qYXZh) | `66.12% <ø> (ø)` | |
| [...org/apache/commons/crypto/cipher/CryptoCipher.java](https://app.codecov.io/gh/apache/commons-crypto/pull/233?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY3J5cHRvL2NpcGhlci9DcnlwdG9DaXBoZXIuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...va/org/apache/commons/crypto/cipher/JceCipher.java](https://app.codecov.io/gh/apache/commons-crypto/pull/233?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY3J5cHRvL2NpcGhlci9KY2VDaXBoZXIuamF2YQ==) | `75.00% <ø> (ø)` | |
| [...java/org/apache/commons/crypto/cipher/OpenSsl.java](https://app.codecov.io/gh/apache/commons-crypto/pull/233?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY3J5cHRvL2NpcGhlci9PcGVuU3NsLmphdmE=) | `80.48% <ø> (ø)` | |
| [...rg/apache/commons/crypto/cipher/OpenSslCipher.java](https://app.codecov.io/gh/apache/commons-crypto/pull/233?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY3J5cHRvL2NpcGhlci9PcGVuU3NsQ2lwaGVyLmphdmE=) | `75.60% <ø> (ø)` | |
| [...ommons/crypto/cipher/OpenSslGaloisCounterMode.java](https://app.codecov.io/gh/apache/commons-crypto/pull/233?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY3J5cHRvL2NpcGhlci9PcGVuU3NsR2Fsb2lzQ291bnRlck1vZGUuamF2YQ==) | `66.66% <ø> (ø)` | |
| [...java/org/apache/commons/crypto/jna/OpenSslJna.java](https://app.codecov.io/gh/apache/commons-crypto/pull/233?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY3J5cHRvL2puYS9PcGVuU3NsSm5hLmphdmE=) | `60.00% <ø> (ø)` | |
| [...rg/apache/commons/crypto/jna/OpenSslJnaCipher.java](https://app.codecov.io/gh/apache/commons-crypto/pull/233?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY3J5cHRvL2puYS9PcGVuU3NsSm5hQ2lwaGVyLmphdmE=) | `80.24% <ø> (+3.70%)` | :arrow_up: |
| ... and [6 more](https://app.codecov.io/gh/apache/commons-crypto/pull/233?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [2 files with indirect coverage changes](https://app.codecov.io/gh/apache/commons-crypto/pull/233/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-crypto] mawiesne commented on pull request #233: Fixes grammar and typos and optimizes JavaDoc
Posted by "mawiesne (via GitHub)" <gi...@apache.org>.
mawiesne commented on PR #233:
URL: https://github.com/apache/commons-crypto/pull/233#issuecomment-1645688783
ping @kinow & @garydgregory
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-crypto] garydgregory merged pull request #233: Fixes grammar and typos and optimizes JavaDoc
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory merged PR #233:
URL: https://github.com/apache/commons-crypto/pull/233
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org