You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "Yikun (via GitHub)" <gi...@apache.org> on 2023/07/17 02:05:38 UTC
[GitHub] [spark] Yikun commented on a diff in pull request #42028: [SPARK-44451][BUILD] Make built document downloadable
Yikun commented on code in PR #42028:
URL: https://github.com/apache/spark/pull/42028#discussion_r1264782031
##########
.github/workflows/build_and_test.yml:
##########
@@ -686,6 +686,14 @@ jobs:
fi
cd docs
bundle exec jekyll build
+ cd ..
Review Comment:
Does this help? I thought there are separate workspace context in every step. So it seems could be removed.
##########
.github/workflows/build_and_test.yml:
##########
@@ -686,6 +686,14 @@ jobs:
fi
cd docs
bundle exec jekyll build
+ cd ..
+ - name: Tar documentation
+ run: tar cjf site.tar.bz2 docs/_site
+ - name: Upload documentation
+ uses: actions/upload-artifact@v3
Review Comment:
```
if: github.repository != 'apache/spark'
```
I am not sure do we want to add a condition in these two step like above to skip the upload progress in apache/repo (work in PR but not post merge commits, the PR trigger the job in personal repo rather than apache repo)?
##########
.github/workflows/build_and_test.yml:
##########
@@ -686,6 +686,14 @@ jobs:
fi
cd docs
bundle exec jekyll build
+ cd ..
+ - name: Tar documentation
+ run: tar cjf site.tar.bz2 docs/_site
+ - name: Upload documentation
+ uses: actions/upload-artifact@v3
+ with:
+ name: site
Review Comment:
```
retention-period: 1
```
As I mentioned before, I recommand to set `retention-period` to `1` to avoid potential artifact storage quota limited.
Background: I encounetered the issue like `Cannot upload artifacts. You may have exceeded your spending limit for storing artifacts with Actions or Packages.` [2], but there still no expilict description in github official doc to show the real limited quota [3].
[1] https://github.com/actions/upload-artifact#retention-period
[2] https://github.com/actions/upload-artifact/issues/307
[3] https://docs.github.com/en/actions/using-workflows/storing-workflow-data-as-artifacts#about-workflow-artifacts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org