You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Brian Wickman <wi...@twopensource.com> on 2014/01/17 20:24:06 UTC
Review Request 17063: Update tag-release to allow patch level increments.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17063/
-----------------------------------------------------------
Review request for Aurora and Kevin Sweeney.
Repository: aurora
Description
-------
Update tag-release to allow patch level increments.
(just now noticed I branched off the status checker change -- ignore that for now.)
Diffs
-----
build-support/release/tag-release 90dc5da2fcb515359174d289d69cac01009f6014
src/main/python/apache/aurora/executor/common/status_checker.py efffa8fda06afb830c5f65fb6eb15f4510225e96
Diff: https://reviews.apache.org/r/17063/diff/
Testing
-------
Nope
Thanks,
Brian Wickman
Re: Review Request 17063: Update tag-release to allow patch level increments.
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17063/#review33077
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Sweeney
On Jan. 28, 2014, 3:32 p.m., Brian Wickman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17063/
> -----------------------------------------------------------
>
> (Updated Jan. 28, 2014, 3:32 p.m.)
>
>
> Review request for Aurora and Kevin Sweeney.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Update tag-release to allow patch level increments.
>
> (just now noticed I branched off the status checker change -- ignore that for now.)
>
>
> Diffs
> -----
>
> KEYS 0313277754679da0e5e1d2075654eac9006ce448
> build-support/release/tag-release 90dc5da2fcb515359174d289d69cac01009f6014
>
> Diff: https://reviews.apache.org/r/17063/diff/
>
>
> Testing
> -------
>
> Nope
>
>
> Thanks,
>
> Brian Wickman
>
>
Re: Review Request 17063: Update tag-release to allow patch level increments.
Posted by Brian Wickman <wi...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17063/
-----------------------------------------------------------
(Updated Jan. 28, 2014, 11:32 p.m.)
Review request for Aurora and Kevin Sweeney.
Changes
-------
update all the things
Repository: aurora
Description
-------
Update tag-release to allow patch level increments.
(just now noticed I branched off the status checker change -- ignore that for now.)
Diffs (updated)
-----
KEYS 0313277754679da0e5e1d2075654eac9006ce448
build-support/release/tag-release 90dc5da2fcb515359174d289d69cac01009f6014
Diff: https://reviews.apache.org/r/17063/diff/
Testing
-------
Nope
Thanks,
Brian Wickman
Re: Review Request 17063: Update tag-release to allow patch level increments.
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17063/#review33068
-----------------------------------------------------------
build-support/release/tag-release
<https://reviews.apache.org/r/17063/#comment62305>
A dev tag should update .auroraversion so that generated artifacts have the tag in them. Without this the tag will point to a -snapshot.
- Kevin Sweeney
On Jan. 28, 2014, 3:11 p.m., Brian Wickman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17063/
> -----------------------------------------------------------
>
> (Updated Jan. 28, 2014, 3:11 p.m.)
>
>
> Review request for Aurora and Kevin Sweeney.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Update tag-release to allow patch level increments.
>
> (just now noticed I branched off the status checker change -- ignore that for now.)
>
>
> Diffs
> -----
>
> KEYS 0313277754679da0e5e1d2075654eac9006ce448
> build-support/release/tag-release 90dc5da2fcb515359174d289d69cac01009f6014
>
> Diff: https://reviews.apache.org/r/17063/diff/
>
>
> Testing
> -------
>
> Nope
>
>
> Thanks,
>
> Brian Wickman
>
>
Re: Review Request 17063: Update tag-release to allow patch level increments.
Posted by Brian Wickman <wi...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17063/
-----------------------------------------------------------
(Updated Jan. 28, 2014, 11:11 p.m.)
Review request for Aurora and Kevin Sweeney.
Changes
-------
update for major/dev tags. haven't incorporated feedback or even considered it yet.
Repository: aurora
Description
-------
Update tag-release to allow patch level increments.
(just now noticed I branched off the status checker change -- ignore that for now.)
Diffs (updated)
-----
KEYS 0313277754679da0e5e1d2075654eac9006ce448
build-support/release/tag-release 90dc5da2fcb515359174d289d69cac01009f6014
Diff: https://reviews.apache.org/r/17063/diff/
Testing
-------
Nope
Thanks,
Brian Wickman
Re: Review Request 17063: Update tag-release to allow patch level increments.
Posted by Jonathan Boulle <jo...@twopensource.com>.
> On Jan. 17, 2014, 7:27 p.m., Brian Wickman wrote:
> > build-support/release/tag-release, line 70
> > <https://reviews.apache.org/r/17063/diff/1/?file=427256#file427256line70>
> >
> > hmm - should this include patch too?
yes
- Jonathan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17063/#review32181
-----------------------------------------------------------
On Jan. 17, 2014, 7:24 p.m., Brian Wickman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17063/
> -----------------------------------------------------------
>
> (Updated Jan. 17, 2014, 7:24 p.m.)
>
>
> Review request for Aurora and Kevin Sweeney.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Update tag-release to allow patch level increments.
>
> (just now noticed I branched off the status checker change -- ignore that for now.)
>
>
> Diffs
> -----
>
> build-support/release/tag-release 90dc5da2fcb515359174d289d69cac01009f6014
> src/main/python/apache/aurora/executor/common/status_checker.py efffa8fda06afb830c5f65fb6eb15f4510225e96
>
> Diff: https://reviews.apache.org/r/17063/diff/
>
>
> Testing
> -------
>
> Nope
>
>
> Thanks,
>
> Brian Wickman
>
>
Re: Review Request 17063: Update tag-release to allow patch level increments.
Posted by Brian Wickman <wi...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17063/#review32181
-----------------------------------------------------------
build-support/release/tag-release
<https://reviews.apache.org/r/17063/#comment60900>
hmm - should this include patch too?
- Brian Wickman
On Jan. 17, 2014, 7:24 p.m., Brian Wickman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17063/
> -----------------------------------------------------------
>
> (Updated Jan. 17, 2014, 7:24 p.m.)
>
>
> Review request for Aurora and Kevin Sweeney.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Update tag-release to allow patch level increments.
>
> (just now noticed I branched off the status checker change -- ignore that for now.)
>
>
> Diffs
> -----
>
> build-support/release/tag-release 90dc5da2fcb515359174d289d69cac01009f6014
> src/main/python/apache/aurora/executor/common/status_checker.py efffa8fda06afb830c5f65fb6eb15f4510225e96
>
> Diff: https://reviews.apache.org/r/17063/diff/
>
>
> Testing
> -------
>
> Nope
>
>
> Thanks,
>
> Brian Wickman
>
>
Re: Review Request 17063: Update tag-release to allow patch level increments.
Posted by Jonathan Boulle <jo...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17063/#review32191
-----------------------------------------------------------
build-support/release/tag-release
<https://reviews.apache.org/r/17063/#comment60910>
I went with this approach originally (apparently https://reviews.apache.org/r/17026 went straight to spam) but ultimately reverted to keeping SNAPSHOT as always the next minor version - not sure what other opinions are
- Jonathan Boulle
On Jan. 17, 2014, 7:24 p.m., Brian Wickman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17063/
> -----------------------------------------------------------
>
> (Updated Jan. 17, 2014, 7:24 p.m.)
>
>
> Review request for Aurora and Kevin Sweeney.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Update tag-release to allow patch level increments.
>
> (just now noticed I branched off the status checker change -- ignore that for now.)
>
>
> Diffs
> -----
>
> build-support/release/tag-release 90dc5da2fcb515359174d289d69cac01009f6014
> src/main/python/apache/aurora/executor/common/status_checker.py efffa8fda06afb830c5f65fb6eb15f4510225e96
>
> Diff: https://reviews.apache.org/r/17063/diff/
>
>
> Testing
> -------
>
> Nope
>
>
> Thanks,
>
> Brian Wickman
>
>
Re: Review Request 17063: Update tag-release to allow patch level increments.
Posted by Bill Farner <wf...@apache.org>.
> On Jan. 17, 2014, 8:12 p.m., Maxim Khutornenko wrote:
> > build-support/release/tag-release, line 70
> > <https://reviews.apache.org/r/17063/diff/1/?file=427256#file427256line70>
> >
> > Should we even support patching off of master? What if there were interim commits past minor/major release that are adding features that don't qualify for a patch? Should we rather do hotfixing off of a tagged release with reverse integration into master?
+1, i could be overthinking, but i anticipated patch releases being ~always cherry-picking. So far i've been committing to master, cherry-picking/backporting.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17063/#review32193
-----------------------------------------------------------
On Jan. 17, 2014, 7:24 p.m., Brian Wickman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17063/
> -----------------------------------------------------------
>
> (Updated Jan. 17, 2014, 7:24 p.m.)
>
>
> Review request for Aurora and Kevin Sweeney.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Update tag-release to allow patch level increments.
>
> (just now noticed I branched off the status checker change -- ignore that for now.)
>
>
> Diffs
> -----
>
> build-support/release/tag-release 90dc5da2fcb515359174d289d69cac01009f6014
> src/main/python/apache/aurora/executor/common/status_checker.py efffa8fda06afb830c5f65fb6eb15f4510225e96
>
> Diff: https://reviews.apache.org/r/17063/diff/
>
>
> Testing
> -------
>
> Nope
>
>
> Thanks,
>
> Brian Wickman
>
>
Re: Review Request 17063: Update tag-release to allow patch level increments.
Posted by Jonathan Boulle <jo...@twopensource.com>.
> On Jan. 17, 2014, 8:12 p.m., Maxim Khutornenko wrote:
> > build-support/release/tag-release, line 70
> > <https://reviews.apache.org/r/17063/diff/1/?file=427256#file427256line70>
> >
> > Should we even support patching off of master? What if there were interim commits past minor/major release that are adding features that don't qualify for a patch? Should we rather do hotfixing off of a tagged release with reverse integration into master?
>
> Bill Farner wrote:
> +1, i could be overthinking, but i anticipated patch releases being ~always cherry-picking. So far i've been committing to master, cherry-picking/backporting.
Can you elaborate on the process for this? (or confirm that the below is correct):
- Check out latest patch at the given minor level, by tag (e.g. "git checkout 0.4.2")
- Cherry-pick desired commits from master (e.g. "git cherry-pick abcd1234")
- Create new tag (e.g. "git tag -u `git config user.email` -s -m "aurora-0.4.3 release." 0.4.3")
- Profit
Could we codify this in releases.md or similar..?
- Jonathan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17063/#review32193
-----------------------------------------------------------
On Jan. 17, 2014, 7:24 p.m., Brian Wickman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17063/
> -----------------------------------------------------------
>
> (Updated Jan. 17, 2014, 7:24 p.m.)
>
>
> Review request for Aurora and Kevin Sweeney.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Update tag-release to allow patch level increments.
>
> (just now noticed I branched off the status checker change -- ignore that for now.)
>
>
> Diffs
> -----
>
> build-support/release/tag-release 90dc5da2fcb515359174d289d69cac01009f6014
> src/main/python/apache/aurora/executor/common/status_checker.py efffa8fda06afb830c5f65fb6eb15f4510225e96
>
> Diff: https://reviews.apache.org/r/17063/diff/
>
>
> Testing
> -------
>
> Nope
>
>
> Thanks,
>
> Brian Wickman
>
>
Re: Review Request 17063: Update tag-release to allow patch level increments.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17063/#review32193
-----------------------------------------------------------
build-support/release/tag-release
<https://reviews.apache.org/r/17063/#comment60912>
Should we even support patching off of master? What if there were interim commits past minor/major release that are adding features that don't qualify for a patch? Should we rather do hotfixing off of a tagged release with reverse integration into master?
- Maxim Khutornenko
On Jan. 17, 2014, 7:24 p.m., Brian Wickman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17063/
> -----------------------------------------------------------
>
> (Updated Jan. 17, 2014, 7:24 p.m.)
>
>
> Review request for Aurora and Kevin Sweeney.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Update tag-release to allow patch level increments.
>
> (just now noticed I branched off the status checker change -- ignore that for now.)
>
>
> Diffs
> -----
>
> build-support/release/tag-release 90dc5da2fcb515359174d289d69cac01009f6014
> src/main/python/apache/aurora/executor/common/status_checker.py efffa8fda06afb830c5f65fb6eb15f4510225e96
>
> Diff: https://reviews.apache.org/r/17063/diff/
>
>
> Testing
> -------
>
> Nope
>
>
> Thanks,
>
> Brian Wickman
>
>