[GitHub] [iceberg] szehon-ho edited a comment on pull request #2240: Core: Auto promote sorted column metrics to truncate(16)

[GitBox <gi...@apache.org>]

szehon-ho edited a comment on pull request #2240:
URL: https://github.com/apache/iceberg/pull/2240#issuecomment-832537640


   Rebased, and as discussed, make method MetricsConfig.fromTable(table), and propagate the table arg up the various writer stacks.  This was helped by changes of #2362 (table propagation to Spark) and #2499 (SparkAppenderFactory builder using table).  
   
   This last change in particular aligns the other AppenderFactories (Flink/Generic) to also be constructed with tables, like SparkAppenderFactory.  Most of the other changes are test changes to accomodate this change of arguments to AppenderFactories to use Tables.
   
   The actual logic changes remain, are described in the earlier comments (if config does not specify explicitly a metric mode for sorted columns and default mode is None/Counts, then promote these column metric modes to Truncate(16))


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org