You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by le...@apache.org on 2020/11/19 05:44:26 UTC

svn commit: r1883630 - in /pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox: pdfparser/ pdfwriter/

Author: lehmi
Date: Thu Nov 19 05:44:26 2020
New Revision: 1883630

URL: http://svn.apache.org/viewvc?rev=1883630&view=rev
Log:
PDFBOX-5017: sonar fix

Modified:
    pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdfparser/EndstreamFilterStreamTest.java
    pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdfparser/PDFStreamParserTest.java
    pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdfparser/TestPDFParser.java
    pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdfwriter/COSWriterTest.java
    pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdfwriter/COSWriterXRefEntryTest.java
    pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdfwriter/ContentStreamWriterTest.java

Modified: pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdfparser/EndstreamFilterStreamTest.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdfparser/EndstreamFilterStreamTest.java?rev=1883630&r1=1883629&r2=1883630&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdfparser/EndstreamFilterStreamTest.java (original)
+++ pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdfparser/EndstreamFilterStreamTest.java Thu Nov 19 05:44:26 2020
@@ -39,10 +39,10 @@ import org.junit.jupiter.api.Test;
  *
  * @author Tilman Hausherr
  */
-public class EndstreamFilterStreamTest
+class EndstreamFilterStreamTest
 {
     @Test
-    public void testEndstreamFilterStream() throws IOException
+    void testEndstreamFilterStream() throws IOException
     {
         EndstreamFilterStream feos = new EndstreamFilterStream();
         byte[] tab1 = { 1, 2, 3, 4 };
@@ -100,7 +100,7 @@ public class EndstreamFilterStreamTest
     }
 
     @Test
-    public void testPDFBox2079EmbeddedFile() throws IOException
+    void testPDFBox2079EmbeddedFile() throws IOException
     {
         // there should be 17660 bytes in the zip file.
         // in PDFBox 1.8.5, windows newline is appended to the byte stream

Modified: pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdfparser/PDFStreamParserTest.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdfparser/PDFStreamParserTest.java?rev=1883630&r1=1883629&r2=1883630&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdfparser/PDFStreamParserTest.java (original)
+++ pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdfparser/PDFStreamParserTest.java Thu Nov 19 05:44:26 2020
@@ -29,7 +29,7 @@ import static org.junit.jupiter.api.Asse
  *
  * @author Tilman Hausherr
  */
-public class PDFStreamParserTest
+class PDFStreamParserTest
 {
 
     /**
@@ -40,7 +40,7 @@ public class PDFStreamParserTest
      * @throws IOException
      */
     @Test
-    public void testInlineImages() throws IOException
+    void testInlineImages() throws IOException
     {
         testInlineImage2ops("ID\n12345EI Q", "12345", "Q");
         testInlineImage2ops("ID\n12345EI EMC", "12345", "EMC");

Modified: pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdfparser/TestPDFParser.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdfparser/TestPDFParser.java?rev=1883630&r1=1883629&r2=1883630&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdfparser/TestPDFParser.java (original)
+++ pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdfparser/TestPDFParser.java Thu Nov 19 05:44:26 2020
@@ -33,12 +33,12 @@ import org.apache.pdfbox.rendering.PDFRe
 import org.apache.pdfbox.util.DateConverter;
 import org.junit.jupiter.api.Test;
 
-public class TestPDFParser
+class TestPDFParser
 {
     private static final File TARGETPDFDIR = new File("target/pdfs");
 
     @Test
-    public void testPDFParserMissingCatalog() throws URISyntaxException
+    void testPDFParserMissingCatalog() throws URISyntaxException
     {
         // PDFBOX-3060
         try
@@ -60,7 +60,7 @@ public class TestPDFParser
      * @throws IOException
      */
     @Test
-    public void testPDFBox3208() throws IOException
+    void testPDFBox3208() throws IOException
     {
         try (PDDocument doc = Loader
                 .loadPDF(new File(TARGETPDFDIR, "PDFBOX-3208-L33MUTT2SVCWGCS6UIYL5TH3PNPXHIS6.pdf")))
@@ -84,7 +84,7 @@ public class TestPDFParser
      * @throws IOException
      */
     @Test
-    public void testPDFBox3940() throws IOException
+    void testPDFBox3940() throws IOException
     {
         try (PDDocument doc = Loader.loadPDF(new File(TARGETPDFDIR, "PDFBOX-3940-079977.pdf")))
         {
@@ -103,7 +103,7 @@ public class TestPDFParser
      * PDFBOX-3783: test parsing of file with trash after %%EOF.
      */
     @Test
-    public void testPDFBox3783()
+    void testPDFBox3783()
     {
         try
         {
@@ -125,7 +125,7 @@ public class TestPDFParser
      * @throws IOException 
      */
     @Test
-    public void testPDFBox3785() throws IOException
+    void testPDFBox3785() throws IOException
     {
         try (PDDocument doc = Loader.loadPDF(new File(TARGETPDFDIR, "PDFBOX-3785-202097.pdf")))
         {
@@ -137,7 +137,7 @@ public class TestPDFParser
      * PDFBOX-3947: test parsing of file with broken object stream.
      */
     @Test
-    public void testPDFBox3947()
+    void testPDFBox3947()
     {
         try
         {
@@ -153,7 +153,7 @@ public class TestPDFParser
      * PDFBOX-3948: test parsing of file with object stream containing some unexpected newlines.
      */
     @Test
-    public void testPDFBox3948()
+    void testPDFBox3948()
     {
         try
         {
@@ -171,7 +171,7 @@ public class TestPDFParser
      * PDFBOX-3949: test parsing of file with incomplete object stream.
      */
     @Test
-    public void testPDFBox3949()
+    void testPDFBox3949()
     {
         try
         {
@@ -191,7 +191,7 @@ public class TestPDFParser
      * @throws IOException 
      */
     @Test
-    public void testPDFBox3950() throws IOException
+    void testPDFBox3950() throws IOException
     {
         try (PDDocument doc = Loader
                 .loadPDF(new File(TARGETPDFDIR, "PDFBOX-3950-23EGDHXSBBYQLKYOKGZUOVYVNE675PRD.pdf")))
@@ -222,7 +222,7 @@ public class TestPDFParser
      * @throws IOException 
      */
     @Test
-    public void testPDFBox3951() throws IOException
+    void testPDFBox3951() throws IOException
     {
         try (PDDocument doc = Loader
                 .loadPDF(new File(TARGETPDFDIR, "PDFBOX-3951-FIHUZWDDL2VGPOE34N6YHWSIGSH5LVGZ.pdf")))
@@ -237,7 +237,7 @@ public class TestPDFParser
      * @throws IOException 
      */
     @Test
-    public void testPDFBox3964() throws IOException
+    void testPDFBox3964() throws IOException
     {
         try (PDDocument doc = Loader
                 .loadPDF(new File(TARGETPDFDIR, "PDFBOX-3964-c687766d68ac766be3f02aaec5e0d713_2.pdf")))
@@ -253,7 +253,7 @@ public class TestPDFParser
      * @throws IOException
      */
     @Test
-    public void testPDFBox3977() throws IOException
+    void testPDFBox3977() throws IOException
     {
         try (PDDocument doc = Loader
                 .loadPDF(new File(TARGETPDFDIR, "PDFBOX-3977-63NGFQRI44HQNPIPEJH5W2TBM6DJZWMI.pdf")))
@@ -271,7 +271,7 @@ public class TestPDFParser
      * Test parsing the "genko_oc_shiryo1.pdf" file, which is susceptible to regression.
      */
     @Test
-    public void testParseGenko()
+    void testParseGenko()
     {
         try
         {
@@ -288,7 +288,7 @@ public class TestPDFParser
      * ArrayIndexOutOfBoundsException before the bug was fixed.
      */
     @Test
-    public void testPDFBox4338()
+    void testPDFBox4338()
     {
         try
         {
@@ -305,7 +305,7 @@ public class TestPDFParser
      * NullPointerException before the bug was fixed.
      */
     @Test
-    public void testPDFBox4339()
+    void testPDFBox4339()
     {
         try
         {
@@ -324,7 +324,7 @@ public class TestPDFParser
      * @throws IOException
      */
     @Test
-    public void testPDFBox4153() throws IOException
+    void testPDFBox4153() throws IOException
     {
         try (PDDocument doc = Loader.loadPDF(new File(TARGETPDFDIR, "PDFBOX-4153-WXMDXCYRWFDCMOSFQJ5OAJIAFXYRZ5OA.pdf")))
         {
@@ -340,7 +340,7 @@ public class TestPDFParser
      * @throws IOException
      */
     @Test
-    public void testPDFBox4490() throws IOException
+    void testPDFBox4490() throws IOException
     {
         try (PDDocument doc = Loader.loadPDF(new File(TARGETPDFDIR, "PDFBOX-4490.pdf")))
         {

Modified: pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdfwriter/COSWriterTest.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdfwriter/COSWriterTest.java?rev=1883630&r1=1883629&r2=1883630&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdfwriter/COSWriterTest.java (original)
+++ pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdfwriter/COSWriterTest.java Thu Nov 19 05:44:26 2020
@@ -23,7 +23,7 @@ import org.apache.pdfbox.pdmodel.PDDocum
 import org.apache.pdfbox.pdmodel.PDPage;
 import org.junit.jupiter.api.Test;
 
-public class COSWriterTest
+class COSWriterTest
 {
     /**
      * PDFBOX-4241: check whether the output stream is closed twice.
@@ -31,7 +31,7 @@ public class COSWriterTest
      * @throws IOException 
      */
     @Test
-    public void testPDFBox4241() throws IOException
+    void testPDFBox4241() throws IOException
     {
         try (PDDocument doc = new PDDocument())
         {

Modified: pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdfwriter/COSWriterXRefEntryTest.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdfwriter/COSWriterXRefEntryTest.java?rev=1883630&r1=1883629&r2=1883630&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdfwriter/COSWriterXRefEntryTest.java (original)
+++ pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdfwriter/COSWriterXRefEntryTest.java Thu Nov 19 05:44:26 2020
@@ -20,10 +20,10 @@ import static org.junit.jupiter.api.Asse
 
 import org.junit.jupiter.api.Test;
 
-public class COSWriterXRefEntryTest
+class COSWriterXRefEntryTest
 {
     @Test
-    public void compareToInputNullOutputNegative()
+    void compareToInputNullOutputNegative()
     {
         // Arrange
         final COSWriterXRefEntry objectUnderTest = new COSWriterXRefEntry(0L, null, null);

Modified: pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdfwriter/ContentStreamWriterTest.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdfwriter/ContentStreamWriterTest.java?rev=1883630&r1=1883629&r2=1883630&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdfwriter/ContentStreamWriterTest.java (original)
+++ pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdfwriter/ContentStreamWriterTest.java Thu Nov 19 05:44:26 2020
@@ -42,7 +42,7 @@ import org.junit.jupiter.api.Test;
  *
  * @author Tilman Hausherr
  */
-public class ContentStreamWriterTest
+class ContentStreamWriterTest
 {
     private final File testDirIn = new File("target/test-output/contentstream/in");
     private final File testDirOut = new File("target/test-output/contentstream/out");
@@ -79,7 +79,7 @@ public class ContentStreamWriterTest
      * @throws java.io.IOException
      */
     @Test
-    public void testPDFBox4750() throws IOException
+    void testPDFBox4750() throws IOException
     {
         String filename = "PDFBOX-4750.pdf";
         File file = new File("target/pdfs", filename);