[jira] Closed: (MCHANGES-145) Make it possible to run the announcement goals only once for a multi-module project

["Dennis Lundberg (JIRA)" <ji...@codehaus.org>]

     [ http://jira.codehaus.org/browse/MCHANGES-145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dennis Lundberg closed MCHANGES-145.
------------------------------------

    Resolution: Fixed

I opted for a different approach than the attached patch. This is based on the same principle that has been used successfully in the Assembly Plugin. See Brian's blog post about it http://www.sonatype.com/people/2009/05/how-to-make-a-plugin-run-once-during-a-build/

A little refactoring was required to make it work for both announcement-generate and announcement-mail goals.

Fixed in [r884563|http://svn.apache.org/viewvc?view=revision&revision=884563].

> Make it possible to run the announcement goals only once for a multi-module project
> -----------------------------------------------------------------------------------
>
>                 Key: MCHANGES-145
>                 URL: http://jira.codehaus.org/browse/MCHANGES-145
>             Project: Maven 2.x Changes Plugin
>          Issue Type: New Feature
>          Components: announcement
>    Affects Versions: 2.1
>         Environment: maven 2.0.9
> JDK 1.6.011
> WinXP
>            Reporter: Jean-Paul GUIGUI
>            Assignee: Dennis Lundberg
>             Fix For: 2.3
>
>         Attachments: MCHANGES-145-CORRECT.patch, MCHANGES-145.patch
>
>
> If the pom.xml is containing some sub-modules, the goal changes:announcement-mail is trying to send it for each module, and fail because it could not find the template.
>    Announcement template C:\Dev\MyProject\SubmoduleA\target\announcement\announcement.vm not found...
> Should be possible to configure the pom to send only the email for the root project.
> Working with "mvn --non-recursive" option, but we need to be able to configure this behaviour into the pom.xml 
> The same issue for the changes:announcement-generate, but it's only a warning and the build can finish successfully.
> Should include something like:
> 	/**
> 	 * @parameter expression="${project}"
> 	 **/
> 	private MavenProject          mavenProject;
> 	/**
> 	 * If true, will generate the changes only for the root module in case of project with sub-modules.
> 	 * 
> 	 * @parameter expression="${plugin.aggregate}" default-value = "false"
> 	 */
> 	private boolean               aggregate;
> public void execute() {
> 			if (!mavenProject.isExecutionRoot() && aggregate) {
> 				// Execute only for the main module in case of project with sub-modules
> 				return;
> 			}
>                        ..................
> }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira