You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2013/08/06 22:06:29 UTC

Review Request 13343: Fixed process::collect to handle an empty list.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13343/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman and Vinod Kone.


Repository: mesos-git


Description
-------

See above. It's also possible to fix CollectProcess to handle an empty list.


Diffs
-----

  3rdparty/libprocess/include/process/collect.hpp a08fb20ae42dc70770ce4e7c732ece5d37b93a4f 
  3rdparty/libprocess/src/tests/process_tests.cpp 1d49c87bf43ba6d70f392910099ac297e451db33 

Diff: https://reviews.apache.org/r/13343/diff/


Testing
-------

Added a test to catch this.


Thanks,

Ben Mahler

Re: Review Request 13343: Fixed process::collect to handle an empty list.

Posted by Benjamin Hindman <be...@berkeley.edu>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13343/#review24744
-----------------------------------------------------------

Ship it!


Ship It!

- Benjamin Hindman


On Aug. 6, 2013, 8:06 p.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13343/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2013, 8:06 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See above. It's also possible to fix CollectProcess to handle an empty list.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/collect.hpp a08fb20ae42dc70770ce4e7c732ece5d37b93a4f 
>   3rdparty/libprocess/src/tests/process_tests.cpp 1d49c87bf43ba6d70f392910099ac297e451db33 
> 
> Diff: https://reviews.apache.org/r/13343/diff/
> 
> 
> Testing
> -------
> 
> Added a test to catch this.
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>