You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/20 14:14:42 UTC

[GitHub] [spark] AngersZhuuuu opened a new pull request #32259: [SPARK-35113][SQL] Support ANSI intervals in the Hash expression

AngersZhuuuu opened a new pull request #32259:
URL: https://github.com/apache/spark/pull/32259


   ### What changes were proposed in this pull request?
   Support ANSI interval in HashExpression and add UT
   
   ### Why are the changes needed?
   Support ANSI interval in HashExpression
   
   ### Does this PR introduce _any_ user-facing change?
   User can pass ANSI interval in HashExpression function
   
   ### How was this patch tested?
   Added UT
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #32259: [SPARK-35113][SQL] Support ANSI intervals in the Hash expression

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32259:
URL: https://github.com/apache/spark/pull/32259#issuecomment-823356316


   Kubernetes integration test unable to build dist.
   
   exiting with code: 1
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42217/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32259: [SPARK-35113][SQL] Support ANSI intervals in the Hash expression

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32259:
URL: https://github.com/apache/spark/pull/32259#issuecomment-823527180


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137690/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #32259: [SPARK-35113][SQL] Support ANSI intervals in the Hash expression

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32259:
URL: https://github.com/apache/spark/pull/32259#issuecomment-823724338


   **[Test build #137709 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137709/testReport)** for PR 32259 at commit [`ac51cf6`](https://github.com/apache/spark/commit/ac51cf6950c948a1a4550f4a00b27d6a6dfc1cb6).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AngersZhuuuu commented on pull request #32259: [SPARK-35113][SQL] Support ANSI intervals in the Hash expression

Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #32259:
URL: https://github.com/apache/spark/pull/32259#issuecomment-823309539


   FYI @MaxGekk 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] MaxGekk commented on pull request #32259: [SPARK-35113][SQL] Support ANSI intervals in the Hash expression

Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #32259:
URL: https://github.com/apache/spark/pull/32259#issuecomment-823771731


   +1, LGTM. Merging to master.
   Thank you, @AngersZhuuuu .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #32259: [SPARK-35113][SQL] Support ANSI intervals in the Hash expression

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32259:
URL: https://github.com/apache/spark/pull/32259#issuecomment-823806495


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137709/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #32259: [SPARK-35113][SQL] Support ANSI intervals in the Hash expression

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32259:
URL: https://github.com/apache/spark/pull/32259#issuecomment-823503038


   **[Test build #137690 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137690/testReport)** for PR 32259 at commit [`d131dbb`](https://github.com/apache/spark/commit/d131dbbf27ee5c274a1f61e5acec22fc6602d396).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #32259: [SPARK-35113][SQL] Support ANSI intervals in the Hash expression

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32259:
URL: https://github.com/apache/spark/pull/32259#issuecomment-823527180


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137690/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32259: [SPARK-35113][SQL] Support ANSI intervals in the Hash expression

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32259:
URL: https://github.com/apache/spark/pull/32259#issuecomment-823747175


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42237/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #32259: [SPARK-35113][SQL] Support ANSI intervals in the Hash expression

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32259:
URL: https://github.com/apache/spark/pull/32259#issuecomment-823356358


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42217/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #32259: [SPARK-35113][SQL] Support ANSI intervals in the Hash expression

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32259:
URL: https://github.com/apache/spark/pull/32259#issuecomment-823747175


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42237/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #32259: [SPARK-35113][SQL] Support ANSI intervals in the Hash expression

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32259:
URL: https://github.com/apache/spark/pull/32259#issuecomment-823311929


   **[Test build #137690 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137690/testReport)** for PR 32259 at commit [`d131dbb`](https://github.com/apache/spark/commit/d131dbbf27ee5c274a1f61e5acec22fc6602d396).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32259: [SPARK-35113][SQL] Support ANSI intervals in the Hash expression

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32259:
URL: https://github.com/apache/spark/pull/32259#issuecomment-823806495


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137709/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32259: [SPARK-35113][SQL] Support ANSI intervals in the Hash expression

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32259:
URL: https://github.com/apache/spark/pull/32259#issuecomment-823356358


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42217/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #32259: [SPARK-35113][SQL] Support ANSI intervals in the Hash expression

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32259:
URL: https://github.com/apache/spark/pull/32259#issuecomment-823311929


   **[Test build #137690 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137690/testReport)** for PR 32259 at commit [`d131dbb`](https://github.com/apache/spark/commit/d131dbbf27ee5c274a1f61e5acec22fc6602d396).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #32259: [SPARK-35113][SQL] Support ANSI intervals in the Hash expression

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32259:
URL: https://github.com/apache/spark/pull/32259#issuecomment-823724338


   **[Test build #137709 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137709/testReport)** for PR 32259 at commit [`ac51cf6`](https://github.com/apache/spark/commit/ac51cf6950c948a1a4550f4a00b27d6a6dfc1cb6).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #32259: [SPARK-35113][SQL] Support ANSI intervals in the Hash expression

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32259:
URL: https://github.com/apache/spark/pull/32259#issuecomment-823805626


   **[Test build #137709 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137709/testReport)** for PR 32259 at commit [`ac51cf6`](https://github.com/apache/spark/commit/ac51cf6950c948a1a4550f4a00b27d6a6dfc1cb6).
    * This patch **fails PySpark unit tests**.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] MaxGekk closed pull request #32259: [SPARK-35113][SQL] Support ANSI intervals in the Hash expression

Posted by GitBox <gi...@apache.org>.
MaxGekk closed pull request #32259:
URL: https://github.com/apache/spark/pull/32259


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AngersZhuuuu commented on pull request #32259: [SPARK-35113][SQL] Support ANSI intervals in the Hash expression

Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #32259:
URL: https://github.com/apache/spark/pull/32259#issuecomment-823724205


   > Could you add comments about ANSI types like
   > 
   > https://github.com/apache/spark/blob/0945baf90660a101ae0f86a39d4c91ca74ae5ee3/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/hash.scala#L250
   
   Done


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #32259: [SPARK-35113][SQL] Support ANSI intervals in the Hash expression

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32259:
URL: https://github.com/apache/spark/pull/32259#issuecomment-823747153






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org