[jira] [Commented] (BEAM-409) Incorrect use of Math.ceil in ApproximateQuantiles

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15524220#comment-15524220 ] 

ASF GitHub Bot commented on BEAM-409:
-------------------------------------

Github user JasonMWhite closed the pull request at:

    https://github.com/apache/incubator-beam/pull/853


> Incorrect use of Math.ceil in ApproximateQuantiles
> --------------------------------------------------
>
>                 Key: BEAM-409
>                 URL: https://issues.apache.org/jira/browse/BEAM-409
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Scott Wegner
>            Priority: Minor
>              Labels: findbugs, newbie, starter
>
> [FindBugs ICAST_INT_CAST_TO_DOUBLE_PASSED_TO_CEIL|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml#L274]: Integral value cast to double and then passed to Math.ceil
> Applies to: [ApproximateQuanitles|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/ApproximateQuantiles.java#L349].
> This is a good starter bug. When fixing, please remove the corresponding entries from [findbugs-filter.xml|https://github.com/apache/incubator-beam/blob/master/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml] and verify the build passes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)