[GitHub] [incubator-iotdb] fanhualta commented on a change in pull request #430: [IOTDB-193]Create schema automatically

[GitBox <gi...@apache.org>]

fanhualta commented on a change in pull request #430: [IOTDB-193]Create schema automatically
URL: https://github.com/apache/incubator-iotdb/pull/430#discussion_r332920804
 
 

 ##########
 File path: server/src/main/java/org/apache/iotdb/db/metadata/MTree.java
 ##########
 @@ -653,6 +650,38 @@ boolean checkFileNameByPath(String path) {
     return false;
   }
 
+  /**
+   * Check whether the given deviceId exists in the MTree
+   *
+   * @return true when the deviceId exists in the MTree and the prefix of it is storage group seriesPath
+   * @exception
+   * throws StorageGroupException when none of prefixes of the deviceId are set as the storage group seriesPath
+   * throws PathErrorException when the deviceId is not correct in the MTree
+   *        however one of prefixes of it is storage group seriesPath
+   */
+  boolean checkDeviceId(String deviceId) throws StorageGroupException, PathErrorException {
 
 Review comment:
   The return values are not used in your code, and all errors are thrown out with exceptions.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services