You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by ffbin <gi...@git.apache.org> on 2015/08/04 14:42:15 UTC
[GitHub] flink pull request: [FLINK-2483]Add default branch of switch(sched...
GitHub user ffbin opened a pull request:
https://github.com/apache/flink/pull/984
[FLINK-2483]Add default branch of switch(scheduleMode) in scheduleForExecution function
The scheduleMode in executionGraph is get from JobGraph, and JobGraph has not check the scheduleMode.So the default branch is necessary to avoid invalid scheduleMode.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ffbin/flink FLINK-2483
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/984.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #984
----
commit bbd83a26935fbeee1e4f9ee00d9ffcedcd8c2a6c
Author: ffbin <86...@qq.com>
Date: 2015-08-04T12:12:46Z
[FLINK-2483]Add default branch of switch(scheduleMode) in scheduleForExecution function
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2483]Add default branch of switch(sched...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/984
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2483]Add default branch of switch(sched...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/984#issuecomment-127595762
this change is not necessary imo. both in ExecutionGraph and JobGraph, scheduleMode is initialized to a proper ScheduleMode. setScheduleMode requires a ScheduleMode as an argument, so there's no issue here aswell. only possible problem i can see is passing null to setScheduleMode, but that's catched in the switch statement anyway.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2483]Add default branch of switch(sched...
Posted by uce <gi...@git.apache.org>.
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/984#issuecomment-129367535
I think this is good to merge as a sanity check to catch cases where `JobGraph` and `ExecutionGraph` become out of sync regarding the `ScheduleMode`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2483]Add default branch of switch(sched...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/984#issuecomment-129562015
Fair sanity check, will merge this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---