You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "jackylee-ch (via GitHub)" <gi...@apache.org> on 2026/10/03 14:27:00 UTC
[PR] docs: fix malformed rustdoc for bit_and/bit_or/bit_xor expr fns [datafusion]
jackylee-ch opened a new pull request, #25997:
URL: https://github.com/apache/datafusion/pull/25997
## Which issue does this PR close?
- N/A
## Rationale for this change
The `bit_and`/`bit_or`/`bit_xor` expr helpers build their rustdoc in the `make_bitwise_udaf_expr_and_func!` macro by `concat!`-ing `"Returns the bitwise"`, `stringify!($OPR_TYPE)` and `"of a group of values"` with no separators. Since `stringify!(BitwiseOperationType::And)` is `BitwiseOperationType :: And`, docs.rs renders `Returns the bitwiseBitwiseOperationType :: Andof a group of values`.
## What changes are included in this PR?
The macro now takes a readable operation name (`"AND"`/`"OR"`/`"XOR"`), producing `Returns the bitwise AND of a group of values`.
## What is the testing strategy for this PR?
`cargo doc -p datafusion-functions-aggregate`: the three expr fns now render `Returns the bitwise {AND,OR,XOR} of a group of values`.
## Are there any user-facing changes?
Corrected rustdoc for the `bit_and`/`bit_or`/`bit_xor` expression functions. No behavior change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] docs: fix malformed rustdoc for bit_and/bit_or/bit_xor expr fns [datafusion]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #25997:
URL: https://github.com/apache/datafusion/pull/25997#issuecomment-5970233022
## [Codecov](https://app.codecov.io/gh/apache/datafusion/pull/25997?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 82.64%. Comparing base ([`7c67e4c`](https://app.codecov.io/gh/apache/datafusion/commit/7c67e4cf185dffc9fc6fe2c8c058d9894e2535d4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`bc13904`](https://app.codecov.io/gh/apache/datafusion/commit/bc13904b779b62008e02261ff91446844d5f6bc9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on main.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #25997 +/- ##
==========================================
- Coverage 82.64% 82.64% -0.01%
==========================================
Files 1147 1147
Lines 445491 445502 +11
Branches 445491 445502 +11
==========================================
+ Hits 368162 368164 +2
- Misses 54972 54979 +7
- Partials 22357 22359 +2
```
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/datafusion/pull/25997?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] docs: fix malformed rustdoc for bit_and/bit_or/bit_xor expr fns [datafusion]
Posted by "jackylee-ch (via GitHub)" <gi...@apache.org>.
jackylee-ch closed pull request #25997: docs: fix malformed rustdoc for bit_and/bit_or/bit_xor expr fns
URL: https://github.com/apache/datafusion/pull/25997
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org