You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "Gary D. Gregory (Jira)" <ji...@apache.org> on 2019/12/30 13:51:00 UTC
[jira] [Commented] (HTTPCLIENT-2043) Don't name factory
classes/interfaces "*Provider"
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17005324#comment-17005324 ]
Gary D. Gregory commented on HTTPCLIENT-2043:
---------------------------------------------
[~michael-o], sure, I should be able to get to it tonight.
> Don't name factory classes/interfaces "*Provider"
> -------------------------------------------------
>
> Key: HTTPCLIENT-2043
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-2043
> Project: HttpComponents HttpClient
> Issue Type: Task
> Components: HttpClient (classic)
> Affects Versions: 5.0 Beta6
> Reporter: Michael Osipov
> Priority: Major
>
> Both {{CookieSpecProvider}} and {{AuthSchemeProvider}} are documented as factories. If so, they should be named {{*Factory}} as well as their descendants.
> [~ggregory], as discussed on the mailing list, do you want to pick this one up?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org