[GitHub] [pulsar] massakam commented on a change in pull request #12401: [PIP 79][common,broker,client] Change PartitionedTopicStats to aggregate by producerName

[GitBox <gi...@apache.org>]

massakam commented on a change in pull request #12401:
URL: https://github.com/apache/pulsar/pull/12401#discussion_r744409675



##########
File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/AdminApiTest2.java
##########
@@ -2231,4 +2232,170 @@ public void testFailedUpdatePartitionedTopic() throws Exception {
         // validate subscription is created for new partition.
         assertNotNull(admin.topics().getStats(partitionedTopicName + "-partition-" + 6).getSubscriptions().get(subName1));
     }
+
+    @Test
+    public void testPartitionedStatsAggregationByProducerName() throws Exception {
+        final String topic = "persistent://prop-xyz/ns1/test-partitioned-stats-aggregation-by-producer-name";
+        admin.topics().createPartitionedTopic(topic, 10);
+
+        @Cleanup
+        PulsarClient client = PulsarClient.builder().serviceUrl(pulsar.getWebServiceAddress()).build();

Review comment:
       Is it not possible to use `pulsarClient` declared in the super class?
   https://github.com/apache/pulsar/blob/6382be84ae023edeae1ccc996d70391e8b01aec4/pulsar-broker/src/test/java/org/apache/pulsar/broker/auth/MockedPulsarServiceBaseTest.java#L87




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org