You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/08/17 19:59:00 UTC

[GitHub] [superset] etr2460 opened a new issue #16298: Support `Extra Controls` on the Time-Series Area Chart for feature parity

etr2460 opened a new issue #16298:
URL: https://github.com/apache/superset/issues/16298


   **Is your feature request related to a problem? Please describe.**
   The new time series area chart doesn't allow the viewer of a chart on a dashboard to toggle between a stacked view (with the metric values) and the expanded view (showing percent contribution). This is a really commonly used feature on the nvd3 area chart that should be supported in the new one for feature parity.
   
   The control on the nvd3 area chart:
   ![image](https://user-images.githubusercontent.com/7409244/129792061-bf2ea1e1-7cfc-41ae-865a-7aa7590fb4d7.png)
   
   
   **Describe the solution you'd like**
   Allow a chart viewer to switch between stacked and expanded views for the area chart using a control on the chart itself
   
   cc: @junlincc and maybe @villebro? Not sure who's owning the echarts migration


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] junlincc edited a comment on issue #16298: [echarts]Support `Extra Controls` on the Time-Series Area Chart for feature parity

Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on issue #16298:
URL: https://github.com/apache/superset/issues/16298#issuecomment-900812285


   @stephenLYZ i don't think echarts offer those option out of the box, feel free to open a PR in Echarts and we can expedite it. 
   In terms of UI, they dont have to be under "extra control", we can use 
   antd radio or button 
   <img width="306" alt="Screen Shot 2021-08-17 at 10 00 50 PM" src="https://user-images.githubusercontent.com/67837651/129839826-9a4083f7-a2fb-4e1b-9ce7-707d6ed46377.png">
   
   
   cc @villebro 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] junlincc commented on issue #16298: Support `Extra Controls` on the Time-Series Area Chart for feature parity

Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #16298:
URL: https://github.com/apache/superset/issues/16298#issuecomment-900812285


   @stephenLYZ i don't think echarts offer those option out of the box, feel free to open a PR in Echarts and we can expedite it. 
   
   cc @villebro 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] junlincc commented on issue #16298: [echarts]Support `Extra Controls` on the Time-Series Area Chart for feature parity

Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #16298:
URL: https://github.com/apache/superset/issues/16298#issuecomment-901372724


   @stephenLYZ ^^ lmk if you've seen this issue, take your time to finish other tasks first. thank you thank you!🙏


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] junlincc edited a comment on issue #16298: [echarts]Support `Extra Controls` on the Time-Series Area Chart for feature parity

Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on issue #16298:
URL: https://github.com/apache/superset/issues/16298#issuecomment-900812285


   @stephenLYZ i don't think echarts offer those option out of the box, feel free to open a PR in Echarts and we can expedite it. 
   In terms of UI, they dont have to be under "extra control", we can use 
   antd radio or button, maybe button for better consistency. 
   <img width="306" alt="Screen Shot 2021-08-17 at 10 00 50 PM" src="https://user-images.githubusercontent.com/67837651/129839826-9a4083f7-a2fb-4e1b-9ce7-707d6ed46377.png">
   
   
   cc @villebro 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] junlincc edited a comment on issue #16298: Support `Extra Controls` on the Time-Series Area Chart for feature parity

Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on issue #16298:
URL: https://github.com/apache/superset/issues/16298#issuecomment-900811837






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] junlincc commented on issue #16298: Support `Extra Controls` on the Time-Series Area Chart for feature parity

Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #16298:
URL: https://github.com/apache/superset/issues/16298#issuecomment-900811837


   @etr2460 absolutely! it's in our todo list. will get to it asap. please file issues if you see anything is missing in new time-series bar, area and line. we would love to get to feature parity asap 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] junlincc edited a comment on issue #16298: Support `Extra Controls` on the Time-Series Area Chart for feature parity

Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on issue #16298:
URL: https://github.com/apache/superset/issues/16298#issuecomment-900811837


   @etr2460 absolutely! it's in our todo list. will get to it asap. please file issues if you see anything is missing in new time-series bar, area and line. we would love to get to full feature parity within a month or so. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] junlincc commented on issue #16298: Support `Extra Controls` on the Time-Series Area Chart for feature parity

Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #16298:
URL: https://github.com/apache/superset/issues/16298#issuecomment-900811837






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org