You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/10/17 00:51:01 UTC
[GitHub] [arrow-rs] brianrackle opened a new pull request #831: Adding ability to parse float from number with leading decimal
brianrackle opened a new pull request #831:
URL: https://github.com/apache/arrow-rs/pull/831
# Which issue does this PR close?
Closes #830
# Rationale for this change
The issue this fixes results in real-world data sets being incorrectly inferred as strings when they are floats.
# What changes are included in this PR?
Modifying the regular expression to make the digit proceeding the decimal optional
# Are there any user-facing changes?
CSV inferred schemas which include floating-point data doesn't need a proceeding zero for floats between 0 and 1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] codecov-commenter edited a comment on pull request #831: Adding ability to parse float from number with leading decimal
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #831:
URL: https://github.com/apache/arrow-rs/pull/831#issuecomment-944854468
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] brianrackle commented on pull request #831: Adding ability to parse float from number with leading decimal
Posted by GitBox <gi...@apache.org>.
brianrackle commented on pull request #831:
URL: https://github.com/apache/arrow-rs/pull/831#issuecomment-959766866
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on pull request #831: Adding ability to parse float from number with leading decimal
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #831:
URL: https://github.com/apache/arrow-rs/pull/831#issuecomment-945789552
filed https://github.com/apache/arrow-rs/issues/838 for nightly test failures (there is a PR up so hopefully once that is merged, we can rebase this branch and have it pass too)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] codecov-commenter edited a comment on pull request #831: Adding ability to parse float from number with leading decimal
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #831:
URL: https://github.com/apache/arrow-rs/pull/831#issuecomment-944854468
# [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/831?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#831](https://codecov.io/gh/apache/arrow-rs/pull/831?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f8a2dc1) into [master](https://codecov.io/gh/apache/arrow-rs/commit/05eb63f81ddbcfd9f597f893d200c3cda742262d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (05eb63f) will **decrease** coverage by `0.14%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/arrow-rs/pull/831?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #831 +/- ##
==========================================
- Coverage 82.45% 82.31% -0.15%
==========================================
Files 168 168
Lines 48175 48092 -83
==========================================
- Hits 39723 39587 -136
- Misses 8452 8505 +53
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-rs/pull/831?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [arrow/src/csv/reader.rs](https://codecov.io/gh/apache/arrow-rs/pull/831/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2Nzdi9yZWFkZXIucnM=) | `90.01% <100.00%> (-1.77%)` | :arrow_down: |
| [arrow/src/array/transform/fixed\_binary.rs](https://codecov.io/gh/apache/arrow-rs/pull/831/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L3RyYW5zZm9ybS9maXhlZF9iaW5hcnkucnM=) | `75.00% <0.00%> (-3.95%)` | :arrow_down: |
| [parquet/src/schema/visitor.rs](https://codecov.io/gh/apache/arrow-rs/pull/831/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvc2NoZW1hL3Zpc2l0b3IucnM=) | `67.10% <0.00%> (-2.64%)` | :arrow_down: |
| [arrow/src/compute/kernels/cast\_utils.rs](https://codecov.io/gh/apache/arrow-rs/pull/831/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2NvbXB1dGUva2VybmVscy9jYXN0X3V0aWxzLnJz) | `87.50% <0.00%> (-2.50%)` | :arrow_down: |
| [parquet/src/encodings/decoding.rs](https://codecov.io/gh/apache/arrow-rs/pull/831/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvZW5jb2RpbmdzL2RlY29kaW5nLnJz) | `90.45% <0.00%> (-2.02%)` | :arrow_down: |
| [arrow/src/datatypes/ffi.rs](https://codecov.io/gh/apache/arrow-rs/pull/831/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2RhdGF0eXBlcy9mZmkucnM=) | `70.85% <0.00%> (-2.02%)` | :arrow_down: |
| [parquet/src/arrow/arrow\_reader.rs](https://codecov.io/gh/apache/arrow-rs/pull/831/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvYXJyb3cvYXJyb3dfcmVhZGVyLnJz) | `89.32% <0.00%> (-1.95%)` | :arrow_down: |
| [arrow/src/ffi.rs](https://codecov.io/gh/apache/arrow-rs/pull/831/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2ZmaS5ycw==) | `84.69% <0.00%> (-1.89%)` | :arrow_down: |
| [arrow/src/util/data\_gen.rs](https://codecov.io/gh/apache/arrow-rs/pull/831/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL3V0aWwvZGF0YV9nZW4ucnM=) | `75.44% <0.00%> (-1.66%)` | :arrow_down: |
| ... and [70 more](https://codecov.io/gh/apache/arrow-rs/pull/831/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-rs/pull/831?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/831?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [05eb63f...f8a2dc1](https://codecov.io/gh/apache/arrow-rs/pull/831?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] Jimexist commented on a change in pull request #831: Adding ability to parse float from number with leading decimal
Posted by GitBox <gi...@apache.org>.
Jimexist commented on a change in pull request #831:
URL: https://github.com/apache/arrow-rs/pull/831#discussion_r730219270
##########
File path: arrow/src/csv/reader.rs
##########
@@ -1341,6 +1341,7 @@ mod tests {
assert_eq!(infer_field_schema("\"123\""), DataType::Utf8);
assert_eq!(infer_field_schema("10"), DataType::Int64);
assert_eq!(infer_field_schema("10.2"), DataType::Float64);
+ assert_eq!(infer_field_schema(".2"), DataType::Float64);
Review comment:
Can you also try to cover cases like '2.'?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on a change in pull request #831: Adding ability to parse float from number with leading decimal
Posted by GitBox <gi...@apache.org>.
alamb commented on a change in pull request #831:
URL: https://github.com/apache/arrow-rs/pull/831#discussion_r745513654
##########
File path: arrow/src/csv/reader.rs
##########
@@ -1341,6 +1341,7 @@ mod tests {
assert_eq!(infer_field_schema("\"123\""), DataType::Utf8);
assert_eq!(infer_field_schema("10"), DataType::Int64);
assert_eq!(infer_field_schema("10.2"), DataType::Float64);
+ assert_eq!(infer_field_schema(".2"), DataType::Float64);
Review comment:
As it isn't clear what to do in this case, filed https://github.com/apache/arrow-rs/issues/929 to track this as a follow on work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] codecov-commenter edited a comment on pull request #831: Adding ability to parse float from number with leading decimal
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #831:
URL: https://github.com/apache/arrow-rs/pull/831#issuecomment-944854468
# [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/831?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#831](https://codecov.io/gh/apache/arrow-rs/pull/831?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (62289e9) into [master](https://codecov.io/gh/apache/arrow-rs/commit/d4bf0b64f4f8d072094f2f89256fced471c43ad8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d4bf0b6) will **increase** coverage by `0.03%`.
> The diff coverage is `90.51%`.
[](https://codecov.io/gh/apache/arrow-rs/pull/831?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #831 +/- ##
==========================================
+ Coverage 82.57% 82.60% +0.03%
==========================================
Files 168 168
Lines 47946 48041 +95
==========================================
+ Hits 39593 39686 +93
- Misses 8353 8355 +2
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-rs/pull/831?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [arrow/src/array/array\_map.rs](https://codecov.io/gh/apache/arrow-rs/pull/831/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L2FycmF5X21hcC5ycw==) | `81.50% <ø> (ø)` | |
| [arrow/src/array/equal/mod.rs](https://codecov.io/gh/apache/arrow-rs/pull/831/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L2VxdWFsL21vZC5ycw==) | `93.45% <ø> (ø)` | |
| [arrow/src/array/equal/utils.rs](https://codecov.io/gh/apache/arrow-rs/pull/831/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L2VxdWFsL3V0aWxzLnJz) | `74.00% <ø> (ø)` | |
| [arrow/src/compute/kernels/limit.rs](https://codecov.io/gh/apache/arrow-rs/pull/831/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2NvbXB1dGUva2VybmVscy9saW1pdC5ycw==) | `100.00% <ø> (ø)` | |
| [arrow/src/record\_batch.rs](https://codecov.io/gh/apache/arrow-rs/pull/831/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL3JlY29yZF9iYXRjaC5ycw==) | `92.65% <ø> (ø)` | |
| [arrow/src/util/integration\_util.rs](https://codecov.io/gh/apache/arrow-rs/pull/831/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL3V0aWwvaW50ZWdyYXRpb25fdXRpbC5ycw==) | `70.10% <ø> (ø)` | |
| [integration-testing/src/lib.rs](https://codecov.io/gh/apache/arrow-rs/pull/831/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZWdyYXRpb24tdGVzdGluZy9zcmMvbGliLnJz) | `0.00% <0.00%> (ø)` | |
| [parquet/src/arrow/arrow\_writer.rs](https://codecov.io/gh/apache/arrow-rs/pull/831/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvYXJyb3cvYXJyb3dfd3JpdGVyLnJz) | `98.07% <ø> (ø)` | |
| [parquet/src/arrow/levels.rs](https://codecov.io/gh/apache/arrow-rs/pull/831/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvYXJyb3cvbGV2ZWxzLnJz) | `83.56% <ø> (ø)` | |
| [arrow/src/array/array.rs](https://codecov.io/gh/apache/arrow-rs/pull/831/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L2FycmF5LnJz) | `83.38% <64.06%> (-0.25%)` | :arrow_down: |
| ... and [32 more](https://codecov.io/gh/apache/arrow-rs/pull/831/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-rs/pull/831?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/831?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f14d213...62289e9](https://codecov.io/gh/apache/arrow-rs/pull/831?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] brianrackle commented on pull request #831: Adding ability to parse float from number with leading decimal
Posted by GitBox <gi...@apache.org>.
brianrackle commented on pull request #831:
URL: https://github.com/apache/arrow-rs/pull/831#issuecomment-964331921
@alamb thanks, I believe I have the PR ready. Thanks for helping me get this change in. I will follow up on the other ticket with more info when I get a chance to look into it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on pull request #831: Adding ability to parse float from number with leading decimal
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #831:
URL: https://github.com/apache/arrow-rs/pull/831#issuecomment-945780644
Filed https://github.com/apache/arrow-rs/issues/838 for the CI failures
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] codecov-commenter edited a comment on pull request #831: Adding ability to parse float from number with leading decimal
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #831:
URL: https://github.com/apache/arrow-rs/pull/831#issuecomment-944854468
# [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/831?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#831](https://codecov.io/gh/apache/arrow-rs/pull/831?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f8a2dc1) into [master](https://codecov.io/gh/apache/arrow-rs/commit/05eb63f81ddbcfd9f597f893d200c3cda742262d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (05eb63f) will **decrease** coverage by `0.14%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/arrow-rs/pull/831?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #831 +/- ##
==========================================
- Coverage 82.45% 82.31% -0.15%
==========================================
Files 168 168
Lines 48175 48092 -83
==========================================
- Hits 39723 39587 -136
- Misses 8452 8505 +53
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-rs/pull/831?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [arrow/src/csv/reader.rs](https://codecov.io/gh/apache/arrow-rs/pull/831/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2Nzdi9yZWFkZXIucnM=) | `90.01% <100.00%> (-1.77%)` | :arrow_down: |
| [arrow/src/array/transform/fixed\_binary.rs](https://codecov.io/gh/apache/arrow-rs/pull/831/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L3RyYW5zZm9ybS9maXhlZF9iaW5hcnkucnM=) | `75.00% <0.00%> (-3.95%)` | :arrow_down: |
| [parquet/src/schema/visitor.rs](https://codecov.io/gh/apache/arrow-rs/pull/831/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvc2NoZW1hL3Zpc2l0b3IucnM=) | `67.10% <0.00%> (-2.64%)` | :arrow_down: |
| [arrow/src/compute/kernels/cast\_utils.rs](https://codecov.io/gh/apache/arrow-rs/pull/831/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2NvbXB1dGUva2VybmVscy9jYXN0X3V0aWxzLnJz) | `87.50% <0.00%> (-2.50%)` | :arrow_down: |
| [parquet/src/encodings/decoding.rs](https://codecov.io/gh/apache/arrow-rs/pull/831/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvZW5jb2RpbmdzL2RlY29kaW5nLnJz) | `90.45% <0.00%> (-2.02%)` | :arrow_down: |
| [arrow/src/datatypes/ffi.rs](https://codecov.io/gh/apache/arrow-rs/pull/831/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2RhdGF0eXBlcy9mZmkucnM=) | `70.85% <0.00%> (-2.02%)` | :arrow_down: |
| [parquet/src/arrow/arrow\_reader.rs](https://codecov.io/gh/apache/arrow-rs/pull/831/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvYXJyb3cvYXJyb3dfcmVhZGVyLnJz) | `89.32% <0.00%> (-1.95%)` | :arrow_down: |
| [arrow/src/ffi.rs](https://codecov.io/gh/apache/arrow-rs/pull/831/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2ZmaS5ycw==) | `84.69% <0.00%> (-1.89%)` | :arrow_down: |
| [arrow/src/util/data\_gen.rs](https://codecov.io/gh/apache/arrow-rs/pull/831/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL3V0aWwvZGF0YV9nZW4ucnM=) | `75.44% <0.00%> (-1.66%)` | :arrow_down: |
| ... and [70 more](https://codecov.io/gh/apache/arrow-rs/pull/831/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-rs/pull/831?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/831?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [05eb63f...f8a2dc1](https://codecov.io/gh/apache/arrow-rs/pull/831?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] brianrackle commented on pull request #831: Adding ability to parse float from number with leading decimal
Posted by GitBox <gi...@apache.org>.
brianrackle commented on pull request #831:
URL: https://github.com/apache/arrow-rs/pull/831#issuecomment-959766866
It looks like workflows are still awaiting approval
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on a change in pull request #831: Adding ability to parse float from number with leading decimal
Posted by GitBox <gi...@apache.org>.
alamb commented on a change in pull request #831:
URL: https://github.com/apache/arrow-rs/pull/831#discussion_r734961556
##########
File path: arrow/src/csv/reader.rs
##########
@@ -1341,6 +1341,7 @@ mod tests {
assert_eq!(infer_field_schema("\"123\""), DataType::Utf8);
assert_eq!(infer_field_schema("10"), DataType::Int64);
assert_eq!(infer_field_schema("10.2"), DataType::Float64);
+ assert_eq!(infer_field_schema(".2"), DataType::Float64);
Review comment:
@brianrackle can you please rebase this PR (it should then pass CI) and let us know if you will be able to add the test that @Jimexist suggests?
I am starting to prepare for the 6.1 release (I plan to build the release candidate late next week) and would like to get this in if possibkel
##########
File path: arrow/src/csv/reader.rs
##########
@@ -1341,6 +1341,7 @@ mod tests {
assert_eq!(infer_field_schema("\"123\""), DataType::Utf8);
assert_eq!(infer_field_schema("10"), DataType::Int64);
assert_eq!(infer_field_schema("10.2"), DataType::Float64);
+ assert_eq!(infer_field_schema(".2"), DataType::Float64);
Review comment:
@brianrackle can you please rebase this PR (it should then pass CI) and let us know if you will be able to add the test that @Jimexist suggests?
I am starting to prepare for the 6.1 release (I plan to build the release candidate late next week) and would like to get this in if possible
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on pull request #831: Adding ability to parse float from number with leading decimal
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #831:
URL: https://github.com/apache/arrow-rs/pull/831#issuecomment-959791042
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on pull request #831: Adding ability to parse float from number with leading decimal
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #831:
URL: https://github.com/apache/arrow-rs/pull/831#issuecomment-959791042
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] brianrackle commented on pull request #831: Adding ability to parse float from number with leading decimal
Posted by GitBox <gi...@apache.org>.
brianrackle commented on pull request #831:
URL: https://github.com/apache/arrow-rs/pull/831#issuecomment-959766866
It looks like workflows are still awaiting approval
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] codecov-commenter commented on pull request #831: Adding ability to parse float from number with leading decimal
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #831:
URL: https://github.com/apache/arrow-rs/pull/831#issuecomment-944854468
# [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/831?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#831](https://codecov.io/gh/apache/arrow-rs/pull/831?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (62289e9) into [master](https://codecov.io/gh/apache/arrow-rs/commit/d4bf0b64f4f8d072094f2f89256fced471c43ad8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d4bf0b6) will **increase** coverage by `0.03%`.
> The diff coverage is `90.51%`.
[](https://codecov.io/gh/apache/arrow-rs/pull/831?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #831 +/- ##
==========================================
+ Coverage 82.57% 82.60% +0.03%
==========================================
Files 168 168
Lines 47946 48041 +95
==========================================
+ Hits 39593 39686 +93
- Misses 8353 8355 +2
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-rs/pull/831?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [arrow/src/array/array\_map.rs](https://codecov.io/gh/apache/arrow-rs/pull/831/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L2FycmF5X21hcC5ycw==) | `81.50% <ø> (ø)` | |
| [arrow/src/array/equal/mod.rs](https://codecov.io/gh/apache/arrow-rs/pull/831/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L2VxdWFsL21vZC5ycw==) | `93.45% <ø> (ø)` | |
| [arrow/src/array/equal/utils.rs](https://codecov.io/gh/apache/arrow-rs/pull/831/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L2VxdWFsL3V0aWxzLnJz) | `74.00% <ø> (ø)` | |
| [arrow/src/compute/kernels/limit.rs](https://codecov.io/gh/apache/arrow-rs/pull/831/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2NvbXB1dGUva2VybmVscy9saW1pdC5ycw==) | `100.00% <ø> (ø)` | |
| [arrow/src/record\_batch.rs](https://codecov.io/gh/apache/arrow-rs/pull/831/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL3JlY29yZF9iYXRjaC5ycw==) | `92.65% <ø> (ø)` | |
| [arrow/src/util/integration\_util.rs](https://codecov.io/gh/apache/arrow-rs/pull/831/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL3V0aWwvaW50ZWdyYXRpb25fdXRpbC5ycw==) | `70.10% <ø> (ø)` | |
| [integration-testing/src/lib.rs](https://codecov.io/gh/apache/arrow-rs/pull/831/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZWdyYXRpb24tdGVzdGluZy9zcmMvbGliLnJz) | `0.00% <0.00%> (ø)` | |
| [parquet/src/arrow/arrow\_writer.rs](https://codecov.io/gh/apache/arrow-rs/pull/831/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvYXJyb3cvYXJyb3dfd3JpdGVyLnJz) | `98.07% <ø> (ø)` | |
| [parquet/src/arrow/levels.rs](https://codecov.io/gh/apache/arrow-rs/pull/831/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvYXJyb3cvbGV2ZWxzLnJz) | `83.56% <ø> (ø)` | |
| [arrow/src/array/array.rs](https://codecov.io/gh/apache/arrow-rs/pull/831/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L2FycmF5LnJz) | `83.38% <64.06%> (-0.25%)` | :arrow_down: |
| ... and [32 more](https://codecov.io/gh/apache/arrow-rs/pull/831/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-rs/pull/831?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/831?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f14d213...62289e9](https://codecov.io/gh/apache/arrow-rs/pull/831?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on pull request #831: Adding ability to parse float from number with leading decimal
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #831:
URL: https://github.com/apache/arrow-rs/pull/831#issuecomment-959791042
Workflows started
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on a change in pull request #831: Adding ability to parse float from number with leading decimal
Posted by GitBox <gi...@apache.org>.
alamb commented on a change in pull request #831:
URL: https://github.com/apache/arrow-rs/pull/831#discussion_r745519857
##########
File path: arrow/src/csv/reader.rs
##########
@@ -1341,6 +1341,7 @@ mod tests {
assert_eq!(infer_field_schema("\"123\""), DataType::Utf8);
assert_eq!(infer_field_schema("10"), DataType::Int64);
assert_eq!(infer_field_schema("10.2"), DataType::Float64);
+ assert_eq!(infer_field_schema(".2"), DataType::Float64);
Review comment:
@brackle-lattice - here is a PR to your branch to pickup changes from master as well as add a test showing what happens with `2.` (it is parsed as `Utf8`). https://github.com/brianrackle/arrow-rs/pull/1 (github shows the full diff which is somewhat silly, as it is a merge commit and then a 2 line change). I think what that change this PR will be ready to go
If you don't have time to merge it I can also create a new PR with the changes too to get it into arrow-rs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on pull request #831: Adding ability to parse float from number with leading decimal
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #831:
URL: https://github.com/apache/arrow-rs/pull/831#issuecomment-960021321
The integration test failure is unrelated. @brianrackle can you clarify your plans for https://github.com/apache/arrow-rs/pull/831#discussion_r734961556 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb merged pull request #831: Adding ability to parse float from number with leading decimal
Posted by GitBox <gi...@apache.org>.
alamb merged pull request #831:
URL: https://github.com/apache/arrow-rs/pull/831
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] codecov-commenter edited a comment on pull request #831: Adding ability to parse float from number with leading decimal
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #831:
URL: https://github.com/apache/arrow-rs/pull/831#issuecomment-944854468
# [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/831?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#831](https://codecov.io/gh/apache/arrow-rs/pull/831?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b0b9a15) into [master](https://codecov.io/gh/apache/arrow-rs/commit/d4bf0b64f4f8d072094f2f89256fced471c43ad8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d4bf0b6) will **increase** coverage by `0.03%`.
> The diff coverage is `90.53%`.
[](https://codecov.io/gh/apache/arrow-rs/pull/831?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #831 +/- ##
==========================================
+ Coverage 82.57% 82.60% +0.03%
==========================================
Files 168 168
Lines 47946 48041 +95
==========================================
+ Hits 39593 39686 +93
- Misses 8353 8355 +2
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-rs/pull/831?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [arrow/src/array/array\_map.rs](https://codecov.io/gh/apache/arrow-rs/pull/831/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L2FycmF5X21hcC5ycw==) | `81.50% <ø> (ø)` | |
| [arrow/src/array/equal/mod.rs](https://codecov.io/gh/apache/arrow-rs/pull/831/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L2VxdWFsL21vZC5ycw==) | `93.45% <ø> (ø)` | |
| [arrow/src/array/equal/utils.rs](https://codecov.io/gh/apache/arrow-rs/pull/831/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L2VxdWFsL3V0aWxzLnJz) | `74.00% <ø> (ø)` | |
| [arrow/src/compute/kernels/limit.rs](https://codecov.io/gh/apache/arrow-rs/pull/831/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2NvbXB1dGUva2VybmVscy9saW1pdC5ycw==) | `100.00% <ø> (ø)` | |
| [arrow/src/record\_batch.rs](https://codecov.io/gh/apache/arrow-rs/pull/831/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL3JlY29yZF9iYXRjaC5ycw==) | `92.65% <ø> (ø)` | |
| [arrow/src/util/integration\_util.rs](https://codecov.io/gh/apache/arrow-rs/pull/831/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL3V0aWwvaW50ZWdyYXRpb25fdXRpbC5ycw==) | `70.10% <ø> (ø)` | |
| [integration-testing/src/lib.rs](https://codecov.io/gh/apache/arrow-rs/pull/831/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZWdyYXRpb24tdGVzdGluZy9zcmMvbGliLnJz) | `0.00% <0.00%> (ø)` | |
| [parquet/src/arrow/arrow\_writer.rs](https://codecov.io/gh/apache/arrow-rs/pull/831/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvYXJyb3cvYXJyb3dfd3JpdGVyLnJz) | `98.07% <ø> (ø)` | |
| [parquet/src/arrow/levels.rs](https://codecov.io/gh/apache/arrow-rs/pull/831/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvYXJyb3cvbGV2ZWxzLnJz) | `83.56% <ø> (ø)` | |
| [arrow/src/array/array.rs](https://codecov.io/gh/apache/arrow-rs/pull/831/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L2FycmF5LnJz) | `83.38% <64.06%> (-0.25%)` | :arrow_down: |
| ... and [32 more](https://codecov.io/gh/apache/arrow-rs/pull/831/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-rs/pull/831?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/831?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f14d213...b0b9a15](https://codecov.io/gh/apache/arrow-rs/pull/831?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] brackle-lattice commented on a change in pull request #831: Adding ability to parse float from number with leading decimal
Posted by GitBox <gi...@apache.org>.
brackle-lattice commented on a change in pull request #831:
URL: https://github.com/apache/arrow-rs/pull/831#discussion_r744929541
##########
File path: arrow/src/csv/reader.rs
##########
@@ -1341,6 +1341,7 @@ mod tests {
assert_eq!(infer_field_schema("\"123\""), DataType::Utf8);
assert_eq!(infer_field_schema("10"), DataType::Int64);
assert_eq!(infer_field_schema("10.2"), DataType::Float64);
+ assert_eq!(infer_field_schema(".2"), DataType::Float64);
Review comment:
Taking a look at the JSON parser in more detail and running some tests to see how the JSON parser deals with a case like '2.'. Reason being is that I think '2.' is a little less clear how to handle because that value can be represented by an Int, so the question is does the presence of a decimal automatically infer Float or should there be some laziness to upgrading from Int to Float and only done when necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on pull request #831: Adding ability to parse float from number with leading decimal
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #831:
URL: https://github.com/apache/arrow-rs/pull/831#issuecomment-945095005
The tests were failing with
```
Run export CARGO_HOME="/github/home/.cargo"
Updating crates.io index
error: failed to select a version for the requirement `comfy-table = "^4.0"`
candidate versions found which didn't match: 2.1.0, 2.0.0, 1.6.0, ...
location searched: crates.io index
required by package `arrow v7.0.0-SNAPSHOT (/__w/arrow-rs/arrow-rs/arrow)`
Error: Process completed with exit code 101.
```
I have triggered the tests to re-run so hopefully they will pass on the next run
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] brianrackle commented on a change in pull request #831: Adding ability to parse float from number with leading decimal
Posted by GitBox <gi...@apache.org>.
brianrackle commented on a change in pull request #831:
URL: https://github.com/apache/arrow-rs/pull/831#discussion_r730319211
##########
File path: arrow/src/csv/reader.rs
##########
@@ -1341,6 +1341,7 @@ mod tests {
assert_eq!(infer_field_schema("\"123\""), DataType::Utf8);
assert_eq!(infer_field_schema("10"), DataType::Int64);
assert_eq!(infer_field_schema("10.2"), DataType::Float64);
+ assert_eq!(infer_field_schema(".2"), DataType::Float64);
Review comment:
sure, your suggesting that should also be inferred and parsed as a valid float as well right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org