You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Namit Jain (JIRA)" <ji...@apache.org> on 2008/12/03 23:33:44 UTC
[jira] Created: (HIVE-111) join without a ON clause dies
join without a ON clause dies
-----------------------------
Key: HIVE-111
URL: https://issues.apache.org/jira/browse/HIVE-111
Project: Hadoop Hive
Issue Type: Bug
Components: Query Processor
Reporter: Namit Jain
Assignee: Namit Jain
join without a ON clause dies
For eg: the following query:
select x.* from x JOIN y
results in a null pointer exception.
It should be treated as a cartesian product
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-111) join without a ON clause dies
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Namit Jain updated HIVE-111:
----------------------------
Status: Patch Available (was: Open)
> join without a ON clause dies
> -----------------------------
>
> Key: HIVE-111
> URL: https://issues.apache.org/jira/browse/HIVE-111
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Namit Jain
> Assignee: Namit Jain
> Attachments: patch.txt, patch1.txt
>
>
> join without a ON clause dies
> For eg: the following query:
> select x.* from x JOIN y
> results in a null pointer exception.
> It should be treated as a cartesian product
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-111) join without a ON clause dies
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Namit Jain updated HIVE-111:
----------------------------
Attachment: patch.txt
> join without a ON clause dies
> -----------------------------
>
> Key: HIVE-111
> URL: https://issues.apache.org/jira/browse/HIVE-111
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Namit Jain
> Assignee: Namit Jain
> Attachments: patch.txt
>
>
> join without a ON clause dies
> For eg: the following query:
> select x.* from x JOIN y
> results in a null pointer exception.
> It should be treated as a cartesian product
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-111) join without a ON clause dies
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Namit Jain updated HIVE-111:
----------------------------
Status: Patch Available (was: Open)
did a svn up and generated the patch again after resolving conflicts
Zheng, can you commit now ?
> join without a ON clause dies
> -----------------------------
>
> Key: HIVE-111
> URL: https://issues.apache.org/jira/browse/HIVE-111
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Namit Jain
> Assignee: Namit Jain
> Attachments: patch.txt, patch1.txt, patch3.txt
>
>
> join without a ON clause dies
> For eg: the following query:
> select x.* from x JOIN y
> results in a null pointer exception.
> It should be treated as a cartesian product
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-111) join without a ON clause dies
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-111:
--------------------------------
Fix Version/s: 0.3.0
> join without a ON clause dies
> -----------------------------
>
> Key: HIVE-111
> URL: https://issues.apache.org/jira/browse/HIVE-111
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Namit Jain
> Assignee: Namit Jain
> Fix For: 0.3.0
>
> Attachments: patch.txt, patch1.txt, patch3.txt, patch4.txt
>
>
> join without a ON clause dies
> For eg: the following query:
> select x.* from x JOIN y
> results in a null pointer exception.
> It should be treated as a cartesian product
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-111) join without a ON clause dies
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12653542#action_12653542 ]
Namit Jain commented on HIVE-111:
---------------------------------
removed the assert - will enable asserts in a separate patch
> join without a ON clause dies
> -----------------------------
>
> Key: HIVE-111
> URL: https://issues.apache.org/jira/browse/HIVE-111
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Namit Jain
> Assignee: Namit Jain
> Attachments: patch.txt, patch1.txt
>
>
> join without a ON clause dies
> For eg: the following query:
> select x.* from x JOIN y
> results in a null pointer exception.
> It should be treated as a cartesian product
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-111) join without a ON clause dies
Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12654157#action_12654157 ]
Zheng Shao commented on HIVE-111:
---------------------------------
Committed revision 724047.
Thanks Namit. Please update the internal svn with the reduced test case output.
> join without a ON clause dies
> -----------------------------
>
> Key: HIVE-111
> URL: https://issues.apache.org/jira/browse/HIVE-111
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Namit Jain
> Assignee: Namit Jain
> Attachments: patch.txt, patch1.txt, patch3.txt, patch4.txt
>
>
> join without a ON clause dies
> For eg: the following query:
> select x.* from x JOIN y
> results in a null pointer exception.
> It should be treated as a cartesian product
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-111) join without a ON clause dies
Posted by "Raghotham Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12653604#action_12653604 ]
Raghotham Murthy commented on HIVE-111:
---------------------------------------
+1
looks good.
> join without a ON clause dies
> -----------------------------
>
> Key: HIVE-111
> URL: https://issues.apache.org/jira/browse/HIVE-111
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Namit Jain
> Assignee: Namit Jain
> Attachments: patch.txt, patch1.txt
>
>
> join without a ON clause dies
> For eg: the following query:
> select x.* from x JOIN y
> results in a null pointer exception.
> It should be treated as a cartesian product
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-111) join without a ON clause dies
Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zheng Shao updated HIVE-111:
----------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
HIVE-111. Support join without a ON clause. (Namit through zshao)
> join without a ON clause dies
> -----------------------------
>
> Key: HIVE-111
> URL: https://issues.apache.org/jira/browse/HIVE-111
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Namit Jain
> Assignee: Namit Jain
> Attachments: patch.txt, patch1.txt, patch3.txt, patch4.txt
>
>
> join without a ON clause dies
> For eg: the following query:
> select x.* from x JOIN y
> results in a null pointer exception.
> It should be treated as a cartesian product
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-111) join without a ON clause dies
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Namit Jain updated HIVE-111:
----------------------------
Status: Open (was: Patch Available)
> join without a ON clause dies
> -----------------------------
>
> Key: HIVE-111
> URL: https://issues.apache.org/jira/browse/HIVE-111
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Namit Jain
> Assignee: Namit Jain
> Attachments: patch.txt, patch1.txt, patch3.txt, patch4.txt
>
>
> join without a ON clause dies
> For eg: the following query:
> select x.* from x JOIN y
> results in a null pointer exception.
> It should be treated as a cartesian product
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-111) join without a ON clause dies
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Namit Jain updated HIVE-111:
----------------------------
Status: Open (was: Patch Available)
> join without a ON clause dies
> -----------------------------
>
> Key: HIVE-111
> URL: https://issues.apache.org/jira/browse/HIVE-111
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Namit Jain
> Assignee: Namit Jain
> Attachments: patch.txt, patch1.txt
>
>
> join without a ON clause dies
> For eg: the following query:
> select x.* from x JOIN y
> results in a null pointer exception.
> It should be treated as a cartesian product
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-111) join without a ON clause dies
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Namit Jain updated HIVE-111:
----------------------------
Attachment: patch3.txt
> join without a ON clause dies
> -----------------------------
>
> Key: HIVE-111
> URL: https://issues.apache.org/jira/browse/HIVE-111
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Namit Jain
> Assignee: Namit Jain
> Attachments: patch.txt, patch1.txt, patch3.txt
>
>
> join without a ON clause dies
> For eg: the following query:
> select x.* from x JOIN y
> results in a null pointer exception.
> It should be treated as a cartesian product
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-111) join without a ON clause dies
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Namit Jain updated HIVE-111:
----------------------------
Attachment: patch4.txt
> join without a ON clause dies
> -----------------------------
>
> Key: HIVE-111
> URL: https://issues.apache.org/jira/browse/HIVE-111
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Namit Jain
> Assignee: Namit Jain
> Attachments: patch.txt, patch1.txt, patch3.txt, patch4.txt
>
>
> join without a ON clause dies
> For eg: the following query:
> select x.* from x JOIN y
> results in a null pointer exception.
> It should be treated as a cartesian product
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-111) join without a ON clause dies
Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12653943#action_12653943 ]
Zheng Shao commented on HIVE-111:
---------------------------------
Just found that the output file is 6M? Can we make the test case output a bit smaller?
Otherwise the source tree will be growing too much unnecessarily.
> join without a ON clause dies
> -----------------------------
>
> Key: HIVE-111
> URL: https://issues.apache.org/jira/browse/HIVE-111
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Namit Jain
> Assignee: Namit Jain
> Attachments: patch.txt, patch1.txt, patch3.txt
>
>
> join without a ON clause dies
> For eg: the following query:
> select x.* from x JOIN y
> results in a null pointer exception.
> It should be treated as a cartesian product
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-111) join without a ON clause dies
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Namit Jain updated HIVE-111:
----------------------------
Status: Patch Available (was: Open)
> join without a ON clause dies
> -----------------------------
>
> Key: HIVE-111
> URL: https://issues.apache.org/jira/browse/HIVE-111
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Namit Jain
> Assignee: Namit Jain
> Attachments: patch.txt
>
>
> join without a ON clause dies
> For eg: the following query:
> select x.* from x JOIN y
> results in a null pointer exception.
> It should be treated as a cartesian product
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-111) join without a ON clause dies
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12653073#action_12653073 ]
Namit Jain commented on HIVE-111:
---------------------------------
[junit] Running org.apache.hadoop.hive.metastore.TestTablePath
[junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 0.039 sec
[junit] Running org.apache.hadoop.hive.serde2.TestTCTLSeparatedProtocol
[junit] Tests run: 5, Failures: 0, Errors: 0, Time elapsed: 0.188 sec
[junit] Running org.apache.hadoop.hive.serde2.objectinspector.TestThriftObjectInspectors
[junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 0.194 sec
[junit] Running org.apache.hadoop.hive.serde.TestThriftSerDe
[junit] Tests run: 4, Failures: 0, Errors: 0, Time elapsed: 0.023 sec
[junit] Running org.apache.hadoop.hive.metastore.TestTruncate
[junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 0.075 sec
[junit] Running org.apache.hadoop.hive.serde2.objectinspector.TestUnionStructObjectInspecto\
r
[junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 0.176 sec
Logs at /tmp/hivetest_6380
All tests passed!
> join without a ON clause dies
> -----------------------------
>
> Key: HIVE-111
> URL: https://issues.apache.org/jira/browse/HIVE-111
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Namit Jain
> Assignee: Namit Jain
> Attachments: patch.txt
>
>
> join without a ON clause dies
> For eg: the following query:
> select x.* from x JOIN y
> results in a null pointer exception.
> It should be treated as a cartesian product
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-111) join without a ON clause dies
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Namit Jain updated HIVE-111:
----------------------------
Status: Patch Available (was: Open)
reduced the test and generated the patch again
> join without a ON clause dies
> -----------------------------
>
> Key: HIVE-111
> URL: https://issues.apache.org/jira/browse/HIVE-111
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Namit Jain
> Assignee: Namit Jain
> Attachments: patch.txt, patch1.txt, patch3.txt, patch4.txt
>
>
> join without a ON clause dies
> For eg: the following query:
> select x.* from x JOIN y
> results in a null pointer exception.
> It should be treated as a cartesian product
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-111) join without a ON clause dies
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Namit Jain updated HIVE-111:
----------------------------
Status: Open (was: Patch Available)
> join without a ON clause dies
> -----------------------------
>
> Key: HIVE-111
> URL: https://issues.apache.org/jira/browse/HIVE-111
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Namit Jain
> Assignee: Namit Jain
> Attachments: patch.txt, patch1.txt, patch3.txt
>
>
> join without a ON clause dies
> For eg: the following query:
> select x.* from x JOIN y
> results in a null pointer exception.
> It should be treated as a cartesian product
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-111) join without a ON clause dies
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Namit Jain updated HIVE-111:
----------------------------
Attachment: patch1.txt
> join without a ON clause dies
> -----------------------------
>
> Key: HIVE-111
> URL: https://issues.apache.org/jira/browse/HIVE-111
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Namit Jain
> Assignee: Namit Jain
> Attachments: patch.txt, patch1.txt
>
>
> join without a ON clause dies
> For eg: the following query:
> select x.* from x JOIN y
> results in a null pointer exception.
> It should be treated as a cartesian product
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-111) join without a ON clause dies
Posted by "Raghotham Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12653458#action_12653458 ]
Raghotham Murthy commented on HIVE-111:
---------------------------------------
you should also get rid of the assert at line 2349: assert joinCond != null;
In general looks like asserts are not being enabled. we have tons of asserts all over the code - but they may not be firing.
> join without a ON clause dies
> -----------------------------
>
> Key: HIVE-111
> URL: https://issues.apache.org/jira/browse/HIVE-111
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Namit Jain
> Assignee: Namit Jain
> Attachments: patch.txt
>
>
> join without a ON clause dies
> For eg: the following query:
> select x.* from x JOIN y
> results in a null pointer exception.
> It should be treated as a cartesian product
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.