You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/08/14 09:13:09 UTC
[GitHub] [dubbo-go-hessian2] cvictory opened a new pull request #218: attachment type from map[string]stiring to map[string]interface{} [from dubbo 2.7.6]
cvictory opened a new pull request #218:
URL: https://github.com/apache/dubbo-go-hessian2/pull/218
1. attachment类型从attachment type from map[string]stiring 到 map[string]interface{} ，和dubbo java对齐
2.功能分成两部分，一部分会在dubbo-go里提交，一部分需要修改hessian.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] cvictory commented on pull request #218: [refer dubbo 2.7.6] attachment type from map[string]stiring to map[string]interface{}
Posted by GitBox <gi...@apache.org>.
cvictory commented on pull request #218:
URL: https://github.com/apache/dubbo-go-hessian2/pull/218#issuecomment-674378090
> @cvictory pls check the travis failure.
找了好久，没找到错误原因啊。
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] codecov-commenter commented on pull request #218: [refer dubbo 2.7.6] attachment type from map[string]stiring to map[string]interface{}
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #218:
URL: https://github.com/apache/dubbo-go-hessian2/pull/218#issuecomment-674630283
# [Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/218?src=pr&el=h1) Report
> Merging [#218](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/218?src=pr&el=desc) into [master](https://codecov.io/gh/apache/dubbo-go-hessian2/commit/9e91fc9a7de335e427999bd3cd9cd60ef0304169&el=desc) will **increase** coverage by `0.13%`.
> The diff coverage is `76.19%`.
[](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/218?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #218 +/- ##
==========================================
+ Coverage 67.03% 67.17% +0.13%
==========================================
Files 24 24
Lines 2900 2906 +6
==========================================
+ Hits 1944 1952 +8
+ Misses 742 741 -1
+ Partials 214 213 -1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/218?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [hessian.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/218/diff?src=pr&el=tree#diff-aGVzc2lhbi5nbw==) | `48.14% <50.00%> (ø)` | |
| [response.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/218/diff?src=pr&el=tree#diff-cmVzcG9uc2UuZ28=) | `58.17% <66.66%> (+1.80%)` | :arrow_up: |
| [request.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/218/diff?src=pr&el=tree#diff-cmVxdWVzdC5nbw==) | `61.32% <100.00%> (+0.36%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/218?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/218?src=pr&el=footer). Last update [9e91fc9...fab853b](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/218?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] wongoo commented on pull request #218: [refer dubbo 2.7.6] attachment type from map[string]stiring to map[string]interface{}
Posted by GitBox <gi...@apache.org>.
wongoo commented on pull request #218:
URL: https://github.com/apache/dubbo-go-hessian2/pull/218#issuecomment-674405056
> > @cvictory pls check the travis failure.
>
> 找了好久，没找到错误原因啊。
```
$ go fmt && [[ -z `git status -s` ]]
binary.go
response.go
The command "go fmt && [[ -z `git status -s` ]]" exited with 1.
The command "/tmp/tools/license/license-header-checker -v -a -r -i vendor /tmp/tools/license/license.txt . go && [[ -z `git status -s` ]]" exited with 1.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] wongoo commented on a change in pull request #218: [refer dubbo 2.7.6] attachment type from map[string]stiring to map[string]interface{}
Posted by GitBox <gi...@apache.org>.
wongoo commented on a change in pull request #218:
URL: https://github.com/apache/dubbo-go-hessian2/pull/218#discussion_r471209384
##########
File path: request.go
##########
@@ -345,6 +345,8 @@ func ToMapStringString(origin map[interface{}]interface{}) map[string]string {
if vv, ok := v.(string); ok {
Review comment:
not need to check now， just assign
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] cvictory merged pull request #218: [refer dubbo 2.7.6] attachment type from map[string]stiring to map[string]interface{}
Posted by GitBox <gi...@apache.org>.
cvictory merged pull request #218:
URL: https://github.com/apache/dubbo-go-hessian2/pull/218
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] cvictory commented on pull request #218: [refer dubbo 2.7.6] attachment type from map[string]stiring to map[string]interface{}
Posted by GitBox <gi...@apache.org>.
cvictory commented on pull request #218:
URL: https://github.com/apache/dubbo-go-hessian2/pull/218#issuecomment-674633545
> > > @cvictory pls check the travis failure.
> >
> >
> > 找了好久，没找到错误原因啊。
>
> ```
> $ go fmt && [[ -z `git status -s` ]]
> binary.go
> response.go
> The command "go fmt && [[ -z `git status -s` ]]" exited with 1.
>
> The command "/tmp/tools/license/license-header-checker -v -a -r -i vendor /tmp/tools/license/license.txt . go && [[ -z `git status -s` ]]" exited with 1.
> ```
发现是有一个文件没有格式化。。
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] AlexStocks commented on pull request #218: [refer dubbo 2.7.6] attachment type from map[string]stiring to map[string]interface{}
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on pull request #218:
URL: https://github.com/apache/dubbo-go-hessian2/pull/218#issuecomment-674352361
@cvictory pls check the travis failure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] cvictory commented on a change in pull request #218: [refer dubbo 2.7.6] attachment type from map[string]stiring to map[string]interface{}
Posted by GitBox <gi...@apache.org>.
cvictory commented on a change in pull request #218:
URL: https://github.com/apache/dubbo-go-hessian2/pull/218#discussion_r471211760
##########
File path: request.go
##########
@@ -345,6 +345,8 @@ func ToMapStringString(origin map[interface{}]interface{}) map[string]string {
if vv, ok := v.(string); ok {
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org