You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4php-dev@logging.apache.org by ca...@apache.org on 2008/06/04 17:21:26 UTC

svn commit: r663192 - /incubator/log4php/trunk/src/main/php/LoggerPropertyConfigurator.php

Author: carnold
Date: Wed Jun  4 08:21:26 2008
New Revision: 663192

URL: http://svn.apache.org/viewvc?rev=663192&view=rev
Log:
LOG4PHP-13: LoggerPropertyConfigurator: Only variables should be assigned by reference

Modified:
    incubator/log4php/trunk/src/main/php/LoggerPropertyConfigurator.php

Modified: incubator/log4php/trunk/src/main/php/LoggerPropertyConfigurator.php
URL: http://svn.apache.org/viewvc/incubator/log4php/trunk/src/main/php/LoggerPropertyConfigurator.php?rev=663192&r1=663191&r2=663192&view=diff
==============================================================================
--- incubator/log4php/trunk/src/main/php/LoggerPropertyConfigurator.php (original)
+++ incubator/log4php/trunk/src/main/php/LoggerPropertyConfigurator.php Wed Jun  4 08:21:26 2008
@@ -129,7 +129,7 @@
      */
     public static function configure($url = '') {
         $configurator = new LoggerPropertyConfigurator();
-        $repository =& LoggerManager::getLoggerRepository();
+        $repository = LoggerManager::getLoggerRepository();
         return $configurator->doConfigure($url, $repository);
     }
 
@@ -436,7 +436,7 @@
                 "Could not find root logger information. Is this OK?"
             );
         } else {
-            $root =& $hierarchy->getRootLogger();
+            $root = $hierarchy->getRootLogger();
             // synchronized(root) {
                 $this->parseCategory(
                 $props, 
@@ -582,7 +582,7 @@
      */
     function &parseAppender($props, $appenderName)
     {
-        $appender =& LoggerAppender::singleton($appenderName);
+        $appender = LoggerAppender::singleton($appenderName);
         if($appender !== null) {
             LoggerLog::debug(
                 "LoggerPropertyConfigurator::parseAppender() ".
@@ -595,7 +595,7 @@
         $layoutPrefix = $prefix . ".layout";
         $appenderClass = @$props[$prefix];
         if (!empty($appenderClass)) {
-            $appender =& LoggerAppender::singleton($appenderName, $appenderClass);
+            $appender = LoggerAppender::singleton($appenderName, $appenderClass);
             if($appender === null) {
                 LoggerLog::warn(
                     "LoggerPropertyConfigurator::parseAppender() ".