[GitHub] [incubator-mxnet] nswamy edited a comment on issue #14372: Memory fixes. Resolves #10867, and resolves #14080

[GitBox <gi...@apache.org>]

nswamy edited a comment on issue #14372: Memory fixes. Resolves #10867, and resolves #14080
URL: https://github.com/apache/incubator-mxnet/pull/14372#issuecomment-477359084
 
 
   summary of offline discussion:
   * The method is private, this needs to be re-evaluate if we can do without adding scope twice into threadlocal. (ResourceScope:L162)
   * There is a bug in using method that closes the passed in scope(it should not), we will track a JIRA to track and resolve.
   * Also noting that checking the map could impact the performance, with assumption that we won't have too many ResourceScope in action on each thread at at time, at this time this solution is acceptable.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services